Issue #3511123 by catch, berdir: Remove cache tag checksum assertions from performance tests

core/modules/navigation/tests/src/FunctionalJavascript/PerformanceTest.php

@@ -88,9 +88,8 @@ public function testLogin(): void {
         'dynamic_page_cache' => 2,
       ],
       'CacheDeleteCount' => 0,
-      'CacheTagChecksumCount' => 3,
-      'CacheTagIsValidCount' => 30,
       'CacheTagInvalidationCount' => 0,
+      'CacheTagLookupQueryCount' => 20,
       'ScriptCount' => 2,
       'ScriptBytes' => 215500,
       'StylesheetCount' => 1,

core/modules/navigation/tests/src/FunctionalJavascript/TopBarPerformanceTest.php

@@ -74,8 +74,6 @@ public function testTopBarPerformance(): void {
       'CacheGetCount' => $performance_data_before_top_bar->getCacheGetCount(),
       'CacheSetCount' => $performance_data_before_top_bar->getCacheSetCount(),
       'CacheDeleteCount' => $performance_data_before_top_bar->getCacheDeleteCount(),
-      'CacheTagChecksumCount' => $performance_data_before_top_bar->getCacheTagChecksumCount(),
-      'CacheTagIsValidCount' => $performance_data_before_top_bar->getCacheTagIsValidCount(),
       'CacheTagInvalidationCount' => $performance_data_before_top_bar->getCacheTagInvalidationCount(),
     ], $performance_data_after_top_bar);
   }

core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryAuthenticatedPerformanceTest.php

@@ -61,8 +61,6 @@ public function testFrontPageAuthenticatedWarmCache(): void {
       ],
       'CacheSetCount' => 0,
       'CacheDeleteCount' => 0,
-      'CacheTagChecksumCount' => 0,
-      'CacheTagIsValidCount' => 10,
       'CacheTagInvalidationCount' => 0,
       'CacheTagLookupQueryCount' => 2,
       'ScriptCount' => 1,

core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryFrontPagePerformanceTest.php

@@ -73,8 +73,6 @@ protected function testFrontPageHotCache(): void {
       'CacheGetCount' => 1,
       'CacheSetCount' => 0,
       'CacheDeleteCount' => 0,
-      'CacheTagChecksumCount' => 0,
-      'CacheTagIsValidCount' => 1,
       'CacheTagInvalidationCount' => 0,
       'CacheTagLookupQueryCount' => 1,
       'ScriptCount' => 1,

core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryNodePagePerformanceTest.php

@@ -66,8 +66,7 @@ protected function testNodePageHotCache(): void {
       'CacheGetCount' => 1,
       'CacheSetCount' => 0,
       'CacheDeleteCount' => 0,
-      'CacheTagChecksumCount' => 0,
-      'CacheTagIsValidCount' => 1,
+      'CacheTagLookupQueryCount' => 1,
     ];
     $this->assertMetrics($expected, $performance_data);
   }

core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php

@@ -142,8 +142,6 @@ protected function testAnonymous(): void {
       ],
       'CacheSetCount' => 45,
       'CacheDeleteCount' => 0,
-      'CacheTagChecksumCount' => 38,
-      'CacheTagIsValidCount' => 43,
       'CacheTagInvalidationCount' => 0,
       'CacheTagLookupQueryCount' => 21,
       'CacheTagGroupedLookups' => [
@@ -202,8 +200,6 @@ protected function testAnonymous(): void {
     ];
     $recorded_queries = $performance_data->getQueries();
     $this->assertSame($expected_queries, $recorded_queries);
-    $this->assertCountBetween(24, 25, $performance_data->getCacheTagChecksumCount());
-    $this->assertCountBetween(38, 39, $performance_data->getCacheTagIsValidCount());
     $expected = [
       'QueryCount' => 10,
       'CacheGetCount' => 92,
@@ -266,8 +262,6 @@ protected function testAnonymous(): void {
       'CacheGetCount' => 80,
       'CacheSetCount' => 17,
       'CacheDeleteCount' => 0,
-      'CacheTagChecksumCount' => 23,
-      'CacheTagIsValidCount' => 33,
       'CacheTagInvalidationCount' => 0,
       'CacheTagLookupQueryCount' => 16,
       'StylesheetCount' => 1,
@@ -323,8 +317,6 @@ protected function testLogin(): void {
       'CacheGetCount' => 84,
       'CacheSetCount' => 1,
       'CacheDeleteCount' => 1,
-      'CacheTagChecksumCount' => 1,
-      'CacheTagIsValidCount' => 37,
       'CacheTagInvalidationCount' => 0,
       'CacheTagLookupQueryCount' => 17,
       'CacheTagGroupedLookups' => [
@@ -402,8 +394,6 @@ protected function testLoginBlock(): void {
       'CacheGetCount' => 103,
       'CacheSetCount' => 1,
       'CacheDeleteCount' => 1,
-      'CacheTagChecksumCount' => 1,
-      'CacheTagIsValidCount' => 41,
       'CacheTagInvalidationCount' => 0,
       'CacheTagLookupQueryCount' => 19,
     ];

core/tests/Drupal/Tests/PerformanceData.php

@@ -331,8 +331,15 @@ public function setCacheTagChecksumCount(int $count): void {
    *
    * @return int
    *   The number of cache tag checksum checks recorded.
+   *
+   * @deprecated in drupal:11.2.0 and is removed from drupal:12.0.0. There is
+   *   no direct replacement.
+   *
+   * @see https://www.drupal.org/node/3511149
    */
   public function getCacheTagChecksumCount(): int {
+    @trigger_error(__METHOD__ . 'is deprecated in drupal:11.2.0 and is removed from drupal:12.0.0. There is no direct replacement. See https://www.drupal.org/node/3511149', E_DEPRECATED);
+
     return $this->cacheTagChecksumCount;
   }
 
@@ -351,8 +358,14 @@ public function setCacheTagIsValidCount(int $count): void {
    *
    * @return int
    *   The number of cache tag isValid checks recorded.
+   *
+   * @deprecated in drupal:11.2.0 and is removed from drupal:12.0.0. There is
+   * no direct replacement.
+   *
+   * @see https://www.drupal.org/node/3511149
    */
   public function getCacheTagIsValidCount(): int {
+    @trigger_error(__METHOD__ . 'is deprecated in drupal:11.2.0 and is removed from drupal:12.0.0. There is no direct replacement. See https://www.drupal.org/node/3511149', E_DEPRECATED);
     return $this->cacheTagIsValidCount;
   }
 

core/tests/Drupal/Tests/PerformanceTestTrait.php

@@ -699,8 +699,7 @@ protected function getMetrics(PerformanceData $performance_data): array {
       'CacheGetCount' => $performance_data->getCacheGetCount(),
       'CacheSetCount' => $performance_data->getCacheSetCount(),
       'CacheDeleteCount' => $performance_data->getCacheDeleteCount(),
-      'CacheTagChecksumCount' => $performance_data->getCacheTagChecksumCount(),
-      'CacheTagIsValidCount' => $performance_data->getCacheTagIsValidCount(),
+      'CacheTagLookupQueryCount' => $performance_data->getCacheTagLookupQueryCount(),
       'CacheTagInvalidationCount' => $performance_data->getCacheTagInvalidationCount(),
     ];
   }