Skip to content
Snippets Groups Projects

Resolve #3116481 "Convert entityviewsdatatest to kernel test"

Open Resolve #3116481 "Convert entityviewsdatatest to kernel test"
issue/drupal-3116481:3116481-convert-entityviewsdatatest-to-kernel-test into 9.3.x
6 unresolved threads
Open Joachim Noreiko requested to merge issue/drupal-3116481:3116481-convert-entityviewsdatatest-to-kernel-test into 9.3.x
6 unresolved threads

Closes #3116481

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/modules/views/tests/src/Unit/EntityViewsDataTest.php → core/modules/views/tests/src/Kernel/Entity/EntityViewsDataTest.php
214 180 $this->assertEquals(['entity_test_list_cache_context'], $data['entity_test']['table']['base']['cache_contexts']);
215 181 $this->assertEquals('Entity test', $data['entity_test']['table']['base']['title']);
216 182
183 // TODO: change these to assertArrayNotHasKey().
  • daffie
    daffie @daffie started a thread on the diff
    • core/modules/views/tests/src/Unit/EntityViewsDataTest.php → core/modules/views/tests/src/Kernel/Entity/EntityViewsDataTest.php
    162
    163 if ($base_fields) {
    164 ViewsTestEntity::setMockedBaseFieldDefinitions($definition->id(), $base_fields);
    198 165 }
    199 return $base_fields;
    200 166 }
    201 167
    202 168 /**
    203 169 * Tests base tables.
    204 170 */
    205 171 public function testBaseTables() {
    206 $data = $this->viewsData->getViewsData();
    172 $data = $this->entityTypeManager->getHandler('entity_test', 'views_data')->getViewsData();
    207 173
    208 174 $this->assertEquals('entity_test', $data['entity_test']['table']['entity type']);
    209 175 $this->assertEquals(FALSE, $data['entity_test']['table']['entity revision']);
  • daffie
    daffie @daffie started a thread on the diff
    • core/modules/views/tests/src/Unit/EntityViewsDataTest.php → core/modules/views/tests/src/Kernel/Entity/EntityViewsDataTest.php
    264 233 ->set('revision_data_table', NULL)
    265 234 ->set('id', 'entity_test_mulrev')
    266 235 ->setKey('revision', 'revision_id');
    267 $this->viewsData->setEntityType($entity_type);
    268 236
    269 $data = $this->viewsData->getViewsData();
    237 $this->setUpEntityType($entity_type);
    238
    239 $data = $this->entityTypeManager->getHandler('entity_test_mulrev', 'views_data')->getViewsData();
    270 240
    271 241 $this->assertEquals('Entity test revisions', $data['entity_test_mulrev_revision']['table']['base']['title']);
    272 242 $this->assertEquals('revision_id', $data['entity_test_mulrev_revision']['table']['base']['field']);
    273 243
    274 244 $this->assertEquals(FALSE, $data['entity_test']['table']['entity revision']);
  • daffie
    daffie @daffie started a thread on the diff
    • core/modules/views/tests/src/Unit/EntityViewsDataTest.php → core/modules/views/tests/src/Kernel/Entity/EntityViewsDataTest.php
    264 233 ->set('revision_data_table', NULL)
    265 234 ->set('id', 'entity_test_mulrev')
    266 235 ->setKey('revision', 'revision_id');
    267 $this->viewsData->setEntityType($entity_type);
    268 236
    269 $data = $this->viewsData->getViewsData();
    237 $this->setUpEntityType($entity_type);
    238
    239 $data = $this->entityTypeManager->getHandler('entity_test_mulrev', 'views_data')->getViewsData();
    270 240
    271 241 $this->assertEquals('Entity test revisions', $data['entity_test_mulrev_revision']['table']['base']['title']);
    272 242 $this->assertEquals('revision_id', $data['entity_test_mulrev_revision']['table']['base']['field']);
    273 243
    274 244 $this->assertEquals(FALSE, $data['entity_test']['table']['entity revision']);
    275 245 $this->assertEquals('entity_test_mulrev', $data['entity_test_mulrev_revision']['table']['entity type']);
    276 246 $this->assertEquals(TRUE, $data['entity_test_mulrev_revision']['table']['entity revision']);
  • daffie
    daffie @daffie started a thread on the diff
    • core/modules/views/tests/src/Unit/EntityViewsDataTest.php → core/modules/views/tests/src/Kernel/Entity/EntityViewsDataTest.php
    266 235 ->setKey('revision', 'revision_id');
    267 $this->viewsData->setEntityType($entity_type);
    268 236
    269 $data = $this->viewsData->getViewsData();
    237 $this->setUpEntityType($entity_type);
    238
    239 $data = $this->entityTypeManager->getHandler('entity_test_mulrev', 'views_data')->getViewsData();
    270 240
    271 241 $this->assertEquals('Entity test revisions', $data['entity_test_mulrev_revision']['table']['base']['title']);
    272 242 $this->assertEquals('revision_id', $data['entity_test_mulrev_revision']['table']['base']['field']);
    273 243
    274 244 $this->assertEquals(FALSE, $data['entity_test']['table']['entity revision']);
    275 245 $this->assertEquals('entity_test_mulrev', $data['entity_test_mulrev_revision']['table']['entity type']);
    276 246 $this->assertEquals(TRUE, $data['entity_test_mulrev_revision']['table']['entity revision']);
    277 247 $this->assertEquals('entity_test_mulrev', $data['entity_test_mulrev_revision']['table']['entity type']);
    278 248 $this->assertEquals(TRUE, $data['entity_test_mulrev_revision']['table']['entity revision']);
  • daffie
    daffie @daffie started a thread on the diff
    • core/modules/views/tests/src/Unit/EntityViewsDataTest.php → core/modules/views/tests/src/Kernel/Entity/EntityViewsDataTest.php
    285 255 $revision_data = $data['entity_test_mulrev_revision'];
    286 256 $this->assertCount(1, $revision_data['table']['join']);
    287 257 $this->assertEquals(['entity_test' => ['left_field' => 'revision_id', 'field' => 'revision_id', 'type' => 'INNER']], $revision_data['table']['join']);
    288 258 $this->assertFalse(isset($data['data_table']));
    Please register or sign in to reply