Skip to content
Snippets Groups Projects

Order tests by method count and type

Open Order tests by method count and type
issue/drupal-3470179:3470179-account-for-test into 11.x
2 unresolved threads
Open catch requested to merge issue/drupal-3470179:3470179-account-for-test into 11.x
2 unresolved threads

(cherry picked from commit b771eb96)

Closes #3470179

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/modules/workspaces/tests/src/Kernel/WorkspaceIntegrationTest.php
24 24 * Tests a complete publishing scenario across different workspaces.
25 25 *
26 26 * @group #slow
27 * @group workspaces
  • Dave Long
    Dave Long @longwave started a thread on an old version of the diff
    • core/scripts/run-tests.sh
    1082 * The test class name.
    1083 */
    1084 function get_test_type_weight(string $class): int {
    1085 if (is_a($class, WebDriverTestBase::class, TRUE)) {
    1086 return 3;
    1087 }
    1088 if (is_a($class, BrowserTestBase::class, TRUE)) {
    1089 return 2;
    1090 }
    1091 if (is_a($class, BuildTestBase::class, TRUE)) {
    1092 return 2;
    1093 }
    1094 if (is_a($class, KernelTestBase::class, TRUE)) {
    1095 return 1;
    1096 }
    1097 return 0;
    • Comment on lines +1085 to +1097
      Dave Long
      Dave Long @longwave
      Maintainer
      Suggested change
      1085 if (is_a($class, WebDriverTestBase::class, TRUE)) {
      1086 return 3;
      1087 }
      1088 if (is_a($class, BrowserTestBase::class, TRUE)) {
      1089 return 2;
      1090 }
      1091 if (is_a($class, BuildTestBase::class, TRUE)) {
      1092 return 2;
      1093 }
      1094 if (is_a($class, KernelTestBase::class, TRUE)) {
      1095 return 1;
      1096 }
      1097 return 0;
      1085 return match(TRUE) {
      1086 is_a($class, WebDriverTestBase::class, TRUE) => 3,
      1087 is_a($class, BrowserTestBase::class, TRUE) => 2,
      1088 is_a($class, BuildTestBase::class, TRUE) => 2,
      1089 is_a($class, KernelTestBase::class, TRUE) => 1,
      1090 default => 0,
      1091 }
    • Dave Long
      Dave Long @longwave
      Maintainer

      or even

      Suggested change
      1085 if (is_a($class, WebDriverTestBase::class, TRUE)) {
      1086 return 3;
      1087 }
      1088 if (is_a($class, BrowserTestBase::class, TRUE)) {
      1089 return 2;
      1090 }
      1091 if (is_a($class, BuildTestBase::class, TRUE)) {
      1092 return 2;
      1093 }
      1094 if (is_a($class, KernelTestBase::class, TRUE)) {
      1095 return 1;
      1096 }
      1097 return 0;
      1085 return match(TRUE) {
      1086 is_subclass_of($class, WebDriverTestBase::class) => 3,
      1087 is_subclass_of($class, BrowserTestBase::class) => 2,
      1088 is_subclass_of($class, BuildTestBase::class) => 2,
      1089 is_subclass_of($class, KernelTestBase::class) => 1,
      1090 default => 0,
      1091 }
    • quietone changed this line in version 17 of the diff

      changed this line in version 17 of the diff

    • Please register or sign in to reply
  • quietone added 1 commit

    added 1 commit

    Compare with previous version

  • Dave Long
  • Dave Long added 1 commit

    added 1 commit

    • 74972675 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

    • Please register or sign in to reply