Skip to content
Snippets Groups Projects

covert to MR

Closes #3029729

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
40 40 *
41 41 * Each tag to check should be supplied as a separate argument.
42 42 *
43 * @todo Restore PHPDoc of variadic argument in Drupal 8.8, see
44 * https://www.drupal.org/project/drupal/issues/3029729
43 * phpcs:ignore
44 * @param string ...$tags
  • Would it be more clear to change it to @param string[] ...$tags?

  • Author Maintainer

    That would be saying that the input is an array, such as $query->hasAllTags(['test', 'other']). But that is not the case, as shown from this line from a test $this->assertTrue($query->hasAllTags('test', 'other'), 'hasAllTags() returned true.');

    So, I think this is correct.

  • Please register or sign in to reply
  • daffie
    daffie @daffie started a thread on the diff
  • 50 *
    51 * @todo Remove PHPCS ignore and uncomment new method parameters before
    52 * drupal:12.0.0. See https://www.drupal.org/project/drupal/issues/3501046.
    49 53 */
    50 public function hasAllTags();
    54 public function hasAllTags(/* string ...$tags*/);
    51 55
    52 56 /**
    53 57 * Determines if a given query has any specified tag.
    54 58 *
    55 59 * Each tag to check should be supplied as a separate argument.
    56 60 *
    57 * @todo Restore PHPDoc of variadic argument in Drupal 8.8, see
    58 * https://www.drupal.org/project/drupal/issues/3029729
    61 * phpcs:ignore
    62 * @param string ...$tags
  • 2 very minor nitpicks

  • quietone added 197 commits

    added 197 commits

    Compare with previous version

  • added 88 commits

    Compare with previous version

  • 32 32 # Symfony 7.2
    33 33 %Since symfony/http-foundation 7.2: NativeSessionStorage's "sid_length" option is deprecated and will be ignored in Symfony 8.0.%
    34 34 %Since symfony/http-foundation 7.2: NativeSessionStorage's "sid_bits_per_character" option is deprecated and will be ignored in Symfony 8.0.%
    35
    36 # PHPUnit 12.
    Please register or sign in to reply
    Loading