Skip to content
Snippets Groups Projects

Deprecate teaser variable for node.html.twig.

Closed Deprecate teaser variable for node.html.twig.
issue/drupal-3458183:3458183-deprecate-variablesteaser into 11.x
1 open thread
Closed
catchrequested to merge
issue/drupal-3458183:3458183-deprecate-variablesteaser into 11.x
1 open thread

Closes #3458183

Merge request reports

Merged results pipeline #212868 passed

Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal

#212872

    Merged results pipeline passed for 41979548

    Code Quality is loading
    Test summary results are being parsed
    Full report

    Closed by quietonequietone 10 months ago (Sep 13, 2024 3:53am UTC)

    Loading

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    core/themes/olivero/olivero.theme
    97 97 function olivero_preprocess_node(&$variables) {
    98 98 // Remove the "Add new comment" link on teasers or when the comment form is
    99 99 // displayed on the page.
    100 if ($variables['teaser'] || !empty($variables['content']['comments']['comment_form'])) {
    100 if ($variables['view_mode'] === 'teaser' || !empty($variables['content']['comments']['comment_form'])) {
    • Comment on lines -100 to +100
      A
      Alex Pott @alexpott
      Maintainer

      I think the only way we're going to be able to deprecate stuff like this and have it automatically detected is to use PHPStan. I guess we should open an issue against mglaman's thing to be able to do this.

    • Please register or sign in to reply
  • quietone closed

    closed

    • Please register or sign in to reply