Skip to content
Snippets Groups Projects

#3082672 Form prefix/suffix redesign in Claro

Adding a merge request to help with the review process.

Edited by Javier Reartes

Merge request reports

Members who can merge are allowed to add commits.
Ready to merge by members who can write to the target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Javier Reartes changed title from Form prefix/suffix redesign in Claro to #3082672 Form prefix/suffix redesign in Claro

    changed title from Form prefix/suffix redesign in Claro to #3082672 Form prefix/suffix redesign in Claro

  • reopened

  • Javier Reartes changed target branch from 9.3.x to 9.4.x

    changed target branch from 9.3.x to 9.4.x

  • Javier Reartes added 805 commits

    added 805 commits

    Compare with previous version

  • Javier Reartes added 22 commits

    added 22 commits

    Compare with previous version

  • added 1 commit

    • 1f88a6bc - Revert "Merge branch '3082672-form-prefixsuffix-redesign' of...

    Compare with previous version

  • reopened

  • added 1 commit

    • 3170e397 - consolidating values into a variable

    Compare with previous version

  • added 1 commit

    • 0fc8f4eb - Removing changes on Seven theme

    Compare with previous version

  • added 1 commit

    • 35a4d229 - Removing changes on Seven theme

    Compare with previous version

  • Javier Reartes added 2 commits

    added 2 commits

    • ca2f2944 - removing changes to Seven theme
    • d1b88414 - Merge branch '3082672-form-prefixsuffix-redesign' of...

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Javier Reartes added 1 commit

    added 1 commit

    • ba39be86 - Switching mutation observer by intersection observer to better target visibility changes

    Compare with previous version

  • Javier Reartes added 1 commit

    added 1 commit

    • c75c659e - Namespacing class and behavior

    Compare with previous version

  • Javier Reartes added 1 commit

    added 1 commit

    Compare with previous version

  • Javier Reartes added 157 commits

    added 157 commits

    Compare with previous version

  • Javier Reartes added 1 commit

    added 1 commit

    Compare with previous version

  • Javier Reartes added 1 commit

    added 1 commit

    Compare with previous version

  • Andrew Berry added 33 commits

    added 33 commits

    Compare with previous version

  • Yogesh Pawar added 3 commits

    added 3 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Yogesh Pawar added 19 commits

    added 19 commits

    Compare with previous version

  • Ben Mullins added 28 commits

    added 28 commits

    • f0eeb865...5b666681 - 26 commits from branch project:9.4.x
    • 6f39edf0 - rebuild assets
    • faceafab - Merge remote-tracking branch 'origin/9.4.x' into 3082672-form-prefixsuffix-redesign

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • f9c89158 - more thoroughly remove jquery once

    Compare with previous version

  • Andrew Berry added 28 commits

    added 28 commits

    Compare with previous version

  • Andrew Berry added 2 commits

    added 2 commits

    Compare with previous version

  • Andrew Berry added 1 commit

    added 1 commit

    • 5ef22bf1 - Fix inline-form.css accidentally removed from seven test

    Compare with previous version

  • Andrew Berry added 13 commits

    added 13 commits

    Compare with previous version

  • Javier Reartes resolved all threads

    resolved all threads

  • Javier Reartes added 145 commits

    added 145 commits

    • bb2bd7d1...ac0d6c60 - 59 commits from branch project:9.4.x
    • 33527a5f - Drupal 9.5.x-dev
    • e894995a - Issue #2168711 by yogeshmpawar, droplet, mariancalinro, bnjmnm, peterpoe,...
    • 73b7efeb - Issue #3277274 by richardrobinson, saki007ster, ApocalypticJake, bnjmnm,...
    • 3fe2e7f3 - Issue #2995367 by quietone, xjm, Lendude: Fix update module test fixture names...
    • 5ffd6ae6 - Issue #3277309 by phjou, mradcliffe, benjifisher, markie: Update links to...
    • 79a302da - Issue #3226016 by Gauravmahlawat, Libbna: Olivero: use multi-class array for...
    • 02ffcc43 - Issue #3270709 by Shashwat Purav, Chi, apaderno: Remove reference to...
    • 7ef5ad66 - Issue #3272516 by Wim Leers, yogeshmpawar, bnjmnm, catch: Deprecate...
    • fc89b10f - Issue #2958358 by Mile23, alexpott: Remove Drupal\Component\Utility's...
    • 7a35abe9 - Issue #3230541 by cliddell, jday, yogeshmpawar, neclimdul, cmlara, Charlie ChX...
    • 5d068a48 - Revert "Issue #3230541 by cliddell, jday, yogeshmpawar, neclimdul, cmlara,...
    • c88351cf - Issue #3230541 by cliddell, jday, yogeshmpawar, neclimdul, cmlara, Charlie ChX...
    • ad870924 - Issue #3266912 by nod_, Wim Leers, lauriii, xjm, mmjvb: Review version...
    • 9c956d43 - Issue #3278568 by lauriii, Spokje: Add Seven and Bartik block configuration to optional config
    • 4b54cc5e - Issue #3278565 by lauriii, Spokje: Remove Claro block configuration from Standard
    • 20e0d59e - Issue #3278215 by Spokje, lauriii, eojthebrave, Berdir: (Not so) Random test...
    • 07230e83 - Issue #3278696 by Spokje: Rename Oliveros block.block.book_navigation.yml and...
    • a9ca452a - Issue #3278732 by Spokje, lauriii: Remove Claro block configuration from Umami
    • c0bad151 - Issue #3278163 by xjm, nod_, lauriii: yarn upgrade for latest security vulnerabilities
    • 9cc4bbec - Issue #3278162 by longwave, xjm, mallezie, Spokje: Update Composer...
    • b077d55c - Issue #3278394 by Wim Leers, bnjmnm: HTMLRestrictions' diff operation bug:...
    • e169a237 - Issue #3275237 by hooroomoo, lauriii, Wim Leers, nod_: Don't convert, instead...
    • 05b4b091 - Issue #3253955 by benjifisher, kristiaanvandeneynde, AaronMcHale: Let modules...
    • 1b9a758b - Issue #3251709 by cindytwilliams, andregp, ankithashetty, ckrina, saschaeggi:...
    • 1015c1b3 - Issue #3279640 by alexpott, Spokje, mherchel, lauriii, catch: Standard install...
    • 23e599ba - Issue #3279788 by alexpott: PHP 7.3 testing on Drupal 9.4.x and 9.5.x is...
    • 004fa86e - Issue #3278246 by lauriii, alexpott, nod_, justafish: Deprecate...
    • ab035217 - Issue #3269657 by hooroomoo, Wim Leers: [drupalMedia] The CKEditor 4 → 5...
    • b4011fbf - Issue #3206226 by Wim Leers, mglaman, lauriii, alexpott: Make updating changes...
    • 3fe2df71 - Issue #3253286 by lauriii, ckrina, bnjmnm, xjm: Remove unnecessary template...
    • b8df4178 - Issue #3278786 by lauriii, nod_: Update production JavaScript dependencies to latest minors
    • 06f6126b - Issue #3279850 by alexpott, dww, lauriii: Theme post updates are not...
    • 3070c83b - Issue #3101922 by bnjmnm, nod_, lauriii: Find replacement for Modernizr...
    • ac1dc4bb - Issue #3259593 by hooroomoo, Dom., Wim Leers, lauriii: Alignment being...
    • f88b9582 - Issue #3279840 by Spokje, mallezie, alexpott: Fix...
    • 00991b9d - Issue #3280359 by bnjmnm: Make jQuery.form internal
    • 3f6a61e7 - Issue #3252100 by amateescu, catch, Tim Bozeman: Set revision_default when publishing
    • 7942ea78 - Issue #3277311 by nod_, Wim Leers, catch, larowlan: Deprecate and mark internal contextual JS API
    • 7ab84336 - Issue #3276218 by lauriii: Follow-up to #3268318: Enable link manual decorator...
    • 78d9626f - Issue #2917239 by Lendude, dww, iStryker: Form is built when not using fields
    • b72a2b11 - Issue #2314443 by olli, Lendude, immaculatexavier, dawehner: Changing view...
    • 70c11f89 - Issue #3278032 by andregp, bkline@rksystems.com: Remove dead code from ContentTranslationController
    • 2d3c1013 - Issue #3277557 by galactus86, mherchel, rootwork: Olivero: Progress indicator...
    • d9a2db8b - Issue #3272354 by danflanagan8: Filter tests should not rely on Classy
    • 1f1cdd2c - Issue #3276839 by Spokje, mondrake: Remove leftover dumpHeaders property
    • 5859d6d5 - Issue #3270081 by franck_lorancy, quietone, Cottser: Fix indentation in doc...
    • a3562c9e - Issue #3278314 by acbramley: InlineBlockUsageInterface::getUsage can return...
    • f4a02958 - Issue #3275530 by danflanagan8: Language Tests should not rely on Classy
    • 0a5c3527 - Issue #3272558 by danflanagan8: Content Translation tests should not rely on Classy
    • 3f231c5d - Issue #3279103 by bradjones1: Test cleanup: Remove dead code from JsonApiFunctionalTest
    • 537c2798 - Issue #3276652 by andregp, eojthebrave, markie, catch, danflanagan8:...
    • eabf471d - Issue #3272543 by danflanagan8, larowlan: History tests should not rely on Classy
    • b74c35f5 - Issue #3272336 by danflanagan8: File tests should not rely on Classy
    • 1c89f62b - Issue #3272581 by danflanagan8: Image tests should not rely on Classy
    • 9e6666fb - Issue #3218562 by bradjones1, yogeshmpawar, Lendude, catch: Fix typo in/rename SearchSimplifyTest
    • 93135724 - Issue #3279502 by webflo: Fix invalid @property annotations
    • 7eda63ab - Issue #3277552 by Hebl, Asha Nair, rootwork, Charles Belov: Seven is missing...
    • 6d19feb1 - Issue #3280614 by Spokje: (Not so) Random test failures QuickEditFileTest
    • ff78b804 - Issue #2580263 by Berdir, nils.destoop, catch, Cottser, larowlan: Find a way...
    • debf7027 - Issue #3112283 by ravi.shankar, mpdonadio, andregp, daffie, jhedstrom,...
    • ec5b3639 - Issue #332796 by voleger, dww, Steve Dondley, ykhadilkar, Dave Reid,...
    • a9d27d15 - Issue #3260920 by tstoeckler: Contact's MessageEntityTest wrongly uses 'edit'...
    • 9ca2366c - Issue #3276565 by dww, larowlan: Add larowlan as maintainer of contextual.module
    • d5cb46bb - Issue #3250582 by huzooka, Matroskeen, danflanagan8, ravi.shankar, quietone,...
    • 8faa516a - Issue #3280602 by larowlan, DanielVeza, Wim Leers, mstrelan: Exceptions for...
    • 387143aa - Issue #3272956 by xjm, Wim Leers, tedbow, dww: Hardcode security coverage EOL...
    • 37f6b990 - Issue #3268746 by quietone, xjm: Fix missing newlines for...
    • da098e32 - Issue #3232714 by paulocs, vsujeetkumar, mondrake, longwave, quietone,...
    • 91f04e6e - Issue #3262874 by Spokje, longwave, ankithashetty, catch, andypost: Update Coder to 8.3.15
    • 4a392a17 - Issue #3280882 by mondrake, mallezie: KernelTestBase::tearDown() cleanup...
    • dd723d01 - Issue #3225966 by claudiu.cristea, xjm, Mixologic, neclimdul, alexpott,...
    • d6160168 - Issue #3058409 by guilhermevp, joachim, ravi.shankar, quietone, init90,...
    • a3056c87 - Issue #3270936 by Spokje, quietone, andypost, lauriii: Deprecate Color module
    • 6a2a3a4e - Issue #2580723 by AdamPS, Berdir, andypost, darvanen, larowlan, alexpott,...
    • ef284073 - Issue #3245553 by quietone, danflanagan8: Fix migration of localized D6 menu links
    • 304c695a - Issue #3270842 by javi-er, sharayurajput, ckrina, WagnerMelo, saschaeggi:...
    • ab69d9ae - Issue #3274080 by mherchel, andy-blum, lauriii: Olivero's mobile menu...
    • 90932101 - Issue #3260007 by mondrake, yogeshmpawar, daffie, andypost: Decouple...
    • 761e2df5 - Issue #2513524 by andregp, JeroenT, Bill Choy, TR, tstoeckler, dawehner, Wim...
    • 03bfbe68 - Revert "Issue #3260007 by mondrake, yogeshmpawar, daffie, andypost: Decouple...
    • 9c6d3d2d - Issue #3279693 by mherchel, andy-blum: Olivero: Hyperlinks with "button" or...
    • 9fe14155 - Issue #3246755 by mherchel, yogeshmpawar, Libbna, cindytwilliams, zenimagine:...
    • 7ecb8bd0 - Issue #3279703 by VIGHNESH SADAGOPAL, Binoli Lalani, Stockfoot, Maninders,...
    • d851e0cf - Issue #3282050 by Spokje: Failing HEAD on PHP 7.3 on ComposerIntegrationTest::testComposerLockHash
    • 00865356 - Merge branch '9.4.x' into 3082672-form-prefixsuffix-redesign
    • 37affc57 - Merge branch '9.5.x' into 3082672-form-prefixsuffix-redesign

    Compare with previous version

  • Javier Reartes changed target branch from 9.4.x to 9.5.x

    changed target branch from 9.4.x to 9.5.x

  • added 1 commit

    Compare with previous version

  • Javier Reartes added 24 commits

    added 24 commits

    Compare with previous version

  • Javier Reartes added 23 commits

    added 23 commits

    Compare with previous version

  • 52 .js .form-item__suffix--stacked {
    53 order: 1; /* This enforces stacking and does not change focus order */
    54 border-top-width: 0;
    55 border-left-width: 1px;
    56 border-radius: 0 0 2px 2px;
    57 }
    58
    59 .form-item__affix--stacked {
    60 position: relative;
    61 white-space: normal;
    62 }
    63
    64 .form-item--error .form-item__affix {
    65 color: #dc2323;
    66 border-color: #dc2323;
    67 background: var(--color-minimumred);
  • 66 box-sizing: border-box;
    67 max-width: 100%;
    68 border-radius: 2px;
    69 }
    70
    71 /* Ensures the focus ring is not covered by the suffix. */
    72 .form-item__wrapper--with-affix .form-element:focus {
    73 z-index: 1;
    74 }
    75
    76 /* These full width pseudo elements are used for enforcing consistent wrapping. */
    77 .form-item__wrapper--with-affix::after,
    78 .form-item__wrapper--with-affix::before {
    79 width: 100%;
    80 content: "";
    81 }
  • Javier Reartes added 265 commits

    added 265 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Javier Reartes added 48 commits

    added 48 commits

    Compare with previous version

  • Javier Reartes changed target branch from 9.5.x to 10.1.x

    changed target branch from 9.5.x to 10.1.x

  • Lauri Timmanee changed target branch from 10.1.x to 9.5.x

    changed target branch from 10.1.x to 9.5.x

  • Please register or sign in to reply
    Loading