Skip to content
Snippets Groups Projects

Issue #3449181 The content overview Views view filters out unpublished content

Closed Issue #3449181 The content overview Views view filters out unpublished content
issue/drupal-3449181:3449181-content_overview_access_fix into 11.x
1 open thread
Closed
Dezső Biczórequested to merge
issue/drupal-3449181:3449181-content_overview_access_fix into 11.x
1 open thread

Closes #3449181

Edited by Dezső Biczó

Merge request reports

Merge request pipeline #464455 passed

Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-3449181

#464460

    Merge request pipeline passed for d1f28be6

    Approval is optional
    Code Quality is loading
    Test summary results are being parsed
    Full report

    Closed by Lee RowlandsLee Rowlands 5 months ago (Apr 4, 2025 3:18am UTC)

    Merge details

    • The changes were not merged into 11.x.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Dezső Biczó
  • Dezső Biczó
    Dezső Biczó @mxr576
    Author

    I wanted to get rid of the Status filter completely and embed the "view own" logic to node_query_node_access_alter() but that was a road with a bunch of unexpected challenges... and I also realized that explicit status filtering shall not happen that layer. So I fixed the status filter... better ideas a very much welcomed, if there is any.

  • Dezső Biczó added 1 commit

    added 1 commit

    • c2464751 - Improve test coverage around unpublished node access checks

    Compare with previous version

  • Dezső Biczó added 16 commits

    added 16 commits

    Compare with previous version

  • Dezső Biczó
  • Dezső Biczó added 2 commits

    added 2 commits

    • 33735304 - Add failing tests
    • 87191bdd - Ensure that unpublished nodes with access are not filtered out

    Compare with previous version

  • Dezső Biczó added 49 commits

    added 49 commits

    • 87191bdd...35ca6308 - 46 commits from branch project:11.x
    • f1ebb1de - Add failing tests
    • 6b375f9d - Ensure that unpublished nodes with access are not filtered out
    • c04a8c23 - KISS, bail out instead when node access is in use

    Compare with previous version

    Toggle commit list
  • quietone
  • quietone
  • quietone
  • quietone added 1 commit

    added 1 commit

    • 8d5d6639 - Apply 3 suggestion(s) to 2 file(s)

    Compare with previous version

  • Dezső Biczó added 156 commits

    added 156 commits

    • 8d5d6639...afdee270 - 153 commits from branch project:11.x
    • fbf470d6 - Add failing tests
    • 7f05a584 - Ensure that unpublished nodes with access are not filtered out
    • 7c7e3e1a - KISS, bail out instead when node access is in use

    Compare with previous version

    Toggle commit list
  • Dezső Biczó added 47 commits

    added 47 commits

    • 7c7e3e1a...4c82b7ea - 44 commits from branch project:11.x
    • a01ac79e - Add failing tests
    • 06f57d1f - Ensure that unpublished nodes with access are not filtered out
    • 2ac7012f - KISS, bail out instead when node access is in use

    Compare with previous version

    Toggle commit list
  • Dezső Biczó added 1 commit

    added 1 commit

    • 99941cd2 - Do not alter help text when there are no node access modules enabled

    Compare with previous version

  • Dezső Biczó added 13 commits

    added 13 commits

    • 99941cd2...fbe398b5 - 8 commits from branch project:11.x
    • 35daeeac - Add failing tests
    • 37c75864 - Ensure that unpublished nodes with access are not filtered out
    • 273de3e2 - KISS, bail out instead when node access is in use
    • fbc2fc87 - Do not alter help text when there are no node access modules enabled
    • bbb71fa0 - Display modules that implement node access that inactivated the filter

    Compare with previous version

    Toggle commit list
  • Dezső Biczó added 1 commit

    added 1 commit

    • cfdb689a - Use uasort() instead of asort()

    Compare with previous version

  • Dezső Biczó changed title from Issue #3439909 by SolimanHarkas, vensires: Fix Taxonomy tests that rely on... to Issue #3449181 The content overview Views view filters out unpublished content

    changed title from Issue #3439909 by SolimanHarkas, vensires: Fix Taxonomy tests that rely on... to Issue #3449181 The content overview Views view filters out unpublished content

  • Dezső Biczó changed the description

    changed the description

  • quietone
  • quietone
  • quietone
  • quietone
  • quietone
  • quietone
  • quietone
  • quietone
  • quietone
  • quietone
  • quietone
  • quietone
  • quietone
  • quietone
  • quietone
  • quietone
  • Dezső Biczó added 1 commit

    added 1 commit

    • 92465ee0 - Apply 11 suggestion(s) to 4 file(s)

    Compare with previous version

  • Dezső Biczó added 1 commit

    added 1 commit

    • 0985d046 - Apply 11 suggestion(s) to 4 file(s)

    Compare with previous version

  • Dezső Biczó added 183 commits

    added 183 commits

    • 0985d046...bf4ae811 - 176 commits from branch project:11.x
    • dcaabbae - Add failing tests
    • ebaaa73e - Ensure that unpublished nodes with access are not filtered out
    • 3f0c82c0 - KISS, bail out instead when node access is in use
    • 237504c0 - Do not alter help text when there are no node access modules enabled
    • 1bbc435a - Display modules that implement node access that inactivated the filter
    • f163977b - Use uasort() instead of asort()
    • cf039575 - Apply 11 suggestion(s) to 4 file(s)

    Compare with previous version

    Toggle commit list
  • Dezső Biczó
  • Dezső Biczó added 2 commits

    added 2 commits

    Compare with previous version

  • Dezső Biczó added 92 commits

    added 92 commits

    • 694d7e8a...2ad947f2 - 83 commits from branch project:11.x
    • d64cefed - Add failing tests
    • a4d5c9d0 - Ensure that unpublished nodes with access are not filtered out
    • 4de3d4f6 - KISS, bail out instead when node access is in use
    • a3ca821f - Do not alter help text when there are no node access modules enabled
    • d822b78e - Display modules that implement node access that inactivated the filter
    • 7f3a9adb - Use uasort() instead of asort()
    • c6495f75 - Apply 11 suggestion(s) to 4 file(s)
    • b05db01e - Oxford comma
    • 21ccb8c1 - Static functions

    Compare with previous version

    Toggle commit list
  • Dezső Biczó added 116 commits

    added 116 commits

    • 21ccb8c1...2546cebc - 107 commits from branch project:11.x
    • 7f44eea2 - Add failing tests
    • 491e4a0b - Ensure that unpublished nodes with access are not filtered out
    • 30490b6a - KISS, bail out instead when node access is in use
    • 390f4b2b - Do not alter help text when there are no node access modules enabled
    • f18b5897 - Display modules that implement node access that inactivated the filter
    • 526d73c2 - Use uasort() instead of asort()
    • 8e9f3854 - Apply 11 suggestion(s) to 4 file(s)
    • 00e86656 - Oxford comma
    • 27fcec42 - Static functions

    Compare with previous version

    Toggle commit list
  • Dezső Biczó added 1 commit

    added 1 commit

    • d6f6b4ca - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • Dezső Biczó added 118 commits

    added 118 commits

    • d6f6b4ca...eab46c49 - 116 commits from branch project:11.x
    • 2cc24129 - Fix code after a suggested change
    • 42432dbc - Merge remote-tracking branch 'origin/11.x' into 3449181-content_overview_access_fix

    Compare with previous version

  • Dezső Biczó added 1 commit

    added 1 commit

    • 3993ef99 - Check unpriviliged user's access

    Compare with previous version

  • Dezső Biczó added 1 commit

    added 1 commit

    • 23673bf5 - Another fix on the suggested change

    Compare with previous version

  • Len Swaneveld
  • Dezső Biczó added 1 commit

    added 1 commit

    • 787cc7e8 - Apply suggested class description change.

    Compare with previous version

  • quietone
  • quietone
  • quietone
  • Dezső Biczó added 1 commit

    added 1 commit

    • 6bb41153 - Change message text and extract method

    Compare with previous version

  • Dezső Biczó added 21 commits

    added 21 commits

    • 6bb41153...1f9191d2 - 19 commits from branch project:11.x
    • d5ebff3e - Merge remote-tracking branch 'origin/11.x' into 3449181-content_overview_access_fix
    • a4603f56 - DI new dependency with deprecation

    Compare with previous version

  • Dezső Biczó added 1 commit

    added 1 commit

    Compare with previous version

  • Dezső Biczó added 184 commits

    added 184 commits

    • 4c4ca01f...928a5cbd - 183 commits from branch project:11.x
    • 39716eeb - Merge remote-tracking branch 'origin/11.x' into 3449181-content_overview_access_fix

    Compare with previous version

  • Dezső Biczó added 1 commit

    added 1 commit

    • 971b3392 - Address https://www.drupal.org/node/3498345

    Compare with previous version

  • Dezső Biczó added 1 commit

    added 1 commit

    • 529154d3 - Address https://www.drupal.org/node/3498345 for real

    Compare with previous version

  • Dezső Biczó added 184 commits

    added 184 commits

    • 529154d3...6dd918c9 - 183 commits from branch project:11.x
    • 88a8a14a - Merge remote-tracking branch 'origin/11.x' into 3449181-content_overview_access_fix

    Compare with previous version

  • Dave Long
  • Dave Long
  • Prabhavathi Vanipenta added 1 commit

    added 1 commit

    • 4b9f81df - Added suggested change for triggering error.

    Compare with previous version

  • Prabhavathi Vanipenta added 1 commit

    added 1 commit

    Compare with previous version

  • Dezső Biczó added 73 commits

    added 73 commits

    • 1aadbca4...93ec7a93 - 72 commits from branch project:11.x
    • aa34bc2a - Merge remote-tracking branch 'origin/11.x' into 3449181-content_overview_access_fix

    Compare with previous version

  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
    Lee Rowlands @larowlan
    Maintainer

    Just a couple of minor things. I'll self apply these and see how tests go.

  • Lee Rowlands resolved all threads

    resolved all threads

  • Lee Rowlands added 1 commit

    added 1 commit

    • 43c6986d - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • Lee Rowlands
  • Lee Rowlands resolved all threads

    resolved all threads

  • Lee Rowlands added 1 commit

    added 1 commit

    • 9f142af3 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Dezső Biczó added 101 commits

    added 101 commits

    • 9f142af3...e0a4d441 - 99 commits from branch project:11.x
    • 8be2cb44 - Merge remote-tracking branch 'origin/11.x' into 3449181-content_overview_access_fix
    • f0083767 - Add check to admin/status page about views with redundant status filter

    Compare with previous version

  • Dezső Biczó
  • Dezső Biczó
  • Dezső Biczó added 2 commits

    added 2 commits

    • 1cc2d8ea - Add check to admin/status page about views with redundant status filter
    • 892da28b - Add a basic test to verify the requirement check

    Compare with previous version

  • Lee Rowlands resolved all threads

    resolved all threads

  • Lee Rowlands
    Lee Rowlands @larowlan started a thread on the diff
    • core/modules/node/tests/src/Kernel/NodeRequirementsStatusFilterWarningTest.php 0 → 100644
    1 <?php
    2
    3 declare(strict_types=1);
    4
    5 namespace Drupal\Tests\node\Kernel;
    6
    7 use Drupal\KernelTests\KernelTestBase;
    8 use Drupal\views\Entity\View;
    9
    10 /**
    11 * Tests redundant status filter warnings raised by node_requirements().
    12 *
    13 * @group node
    14 */
  • Lee Rowlands
  • Lee Rowlands left review comments

    left review comments

  • Dezső Biczó added 1 commit

    added 1 commit

    • 5a208e58 - Disable access checks at the query level

    Compare with previous version

  • Dezső Biczó added 1 commit

    added 1 commit

    • a18b94a1 - Implemented one more important test case

    Compare with previous version

  • Dezső Biczó added 1 commit

    added 1 commit

    • d1f28be6 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Lee Rowlands closed

    closed

    • Please register or sign in to reply