Skip to content
Snippets Groups Projects

Issue #2920285: Update module can get 'stuck' with 'no releases available'

Issue #2920285: Update module can get 'stuck' with 'no releases available'
issue/drupal-2920285:2920285-update-module-can into 9.4.x
2 open threads
Open
spokjerequested to merge
issue/drupal-2920285:2920285-update-module-can into 9.4.x
2 open threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/modules/update/tests/src/Functional/UpdateSemverCoreTest.php
427 427 $this->assertEquals(2, $queue->numberOfItems(), 'Queue contains two items');
428 428 // Try to add a project again.
429 429 update_create_fetch_task($projecta);
430 $this->assertEquals(2, $queue->numberOfItems(), 'Queue still contains two items');
430 $this->assertEquals(3, $queue->numberOfItems(), 'Queue still contains three items');
431 431
432 432 // Clear storage and try again.
433 433 update_storage_clear();
434 434 update_create_fetch_task($projecta);
435 $this->assertEquals(2, $queue->numberOfItems(), 'Queue contains two items');
435 $this->assertEquals(4, $queue->numberOfItems(), 'Queue contains four items');
  • Ted Bowman
    Ted Bowman @tedbow
    Developer

    There was never an explanation of why updating these test was the right solution to the failing test.

    Was the test before this asserting that bug behavior was happening and now this is the correct number of items that should be in the queue?

  • Please register or sign in to reply
  • Ted Bowman
    Ted Bowman @tedbow started a thread on the diff
    • core/modules/update/update.install
    87 87
    88 88 $queue = \Drupal::queue('update_fetch_tasks');
    89 89 $queue->deleteQueue();
    90
    91 \Drupal::keyValue('update_fetch_task')->deleteAll();
  • spokje changed the description

    changed the description

  • spokje changed target branch from 9.3.x to 9.4.x

    changed target branch from 9.3.x to 9.4.x

  • spokje added 622 commits

    added 622 commits

    Compare with previous version

  • spokje added 278 commits

    added 278 commits

    • 03745743...7b59ff86 - 276 commits from branch project:9.4.x
    • 21bb7c07 - Used 2920285-23.patch as base for the Merge Request.
    • 741455c4 - Added \Drupal::keyValue('update_fetch_task')->deleteAll(); to update_uninstall()

    Compare with previous version

  • spokje added 6 commits

    added 6 commits

    • 68c95d07 - 1 commit from branch project:9.4.x
    • ee4d523a - Used 2920285-23.patch as base for the Merge Request.
    • 7fa2cf3f - Added \Drupal::keyValue('update_fetch_task')->deleteAll(); to update_uninstall()
    • 03745743 - Merge branch '9.4.x' into 2920285-update-module-can
    • 1a47cf03 - Merge branch '9.4.x' into 2920285-update-module-can
    • 44fc2dee - Merge branch '2920285-update-module-can' of...

    Compare with previous version

    Toggle commit list
  • James Gilliland added 605 commits

    added 605 commits

    • 44fc2dee...fefb05b7 - 603 commits from branch project:9.4.x
    • 2249d671 - Used 2920285-23.patch as base for the Merge Request.
    • 33aba91f - Added \Drupal::keyValue('update_fetch_task')->deleteAll(); to update_uninstall()

    Compare with previous version

    • Please register or sign in to reply