Add starterkit functionality to Olivero (11.x)
Closes #3301173
Merge request reports
Activity
- Resolved by Andy Blum
added 1 commit
- b87ab560 - Point GenerateThemeTest to a different non-starterkit theme
- Resolved by Andy Blum
mentioned in merge request !2996 (closed)
added 1895 commits
-
b87ab560...1a2079a4 - 1894 commits from branch
project:11.x
- 0516a4a4 - Merge branch '11.x' into 3301173-11.x
-
b87ab560...1a2079a4 - 1894 commits from branch
added 1895 commits
-
b87ab560...1a2079a4 - 1894 commits from branch
project:11.x
- c4b0356c - Merge branch '11.x' into '3301173-11.x'
-
b87ab560...1a2079a4 - 1894 commits from branch
added 2 commits
added 1 commit
- a9544eb0 - Update tests to work on Olivero & derivative starterkit
- Resolved by Andy Blum
added 1 commit
- 644a51fc - don't pass HTTP_USER_AGENT when generating the theme
added 36 commits
-
644a51fc...1b74d431 - 35 commits from branch
project:11.x
- c2b26c60 - Merge branch '11.x' into 3301173-11.x
-
644a51fc...1b74d431 - 35 commits from branch
added 1 commit
- f0594063 - Move the theme generation to be before the Drupal installer
added 1 commit
- 46bb194e - Support separating apcu caches in nightwatch tests
added 1 commit
- 892f001d - Set uniqueApcuNamespace for all Olivero tests
added 1 commit
- d607f7ae - Remove "olivero" reference in stickyHeaderTest
Thanks for your efforts! Will this be merged into the next Drupal core release? Any idea when we finally will be able to use Olivero as a starterkit theme? Really looking forward to use this.
Edited by Michael Zumstein43 ]); 44 $process->setTimeout(60); 45 return $process; 46 } 18 47 19 48 /** 20 49 * {@inheritdoc} 21 50 */ 22 public function setup() { 51 public function setup(): void { 52 23 53 // Install required module for the Olivero front page. 24 54 $module_installer = \Drupal::service('module_installer'); 25 55 assert($module_installer instanceof ModuleInstallerInterface); 26 56 $module_installer->install(['olivero_test']); 57 $module_installer->install(['nightwatch_theme_install_utility']); - Comment on lines 56 to +57
changed this line in version 26 of the diff
20 49 * {@inheritdoc} 21 50 */ 22 public function setup() { 51 public function setup(): void { 52 23 53 // Install required module for the Olivero front page. 24 54 $module_installer = \Drupal::service('module_installer'); 25 55 assert($module_installer instanceof ModuleInstallerInterface); 26 56 $module_installer->install(['olivero_test']); 57 $module_installer->install(['nightwatch_theme_install_utility']); 27 58 28 59 // Install Olivero and set it as the default theme. 29 60 $theme_installer = \Drupal::service('theme_installer'); 30 61 assert($theme_installer instanceof ThemeInstallerInterface); 31 62 $theme_installer->install(['olivero'], TRUE); 63 $theme_installer->install(['test_custom_theme'], TRUE); - Comment on lines 62 to +63
changed this line in version 26 of the diff
23 23 * @param string $site_directory 24 24 * The site directory. 25 25 * 26 * @return void 27 * No return value. 28 * 26 29 * @see \Drupal\TestSite\TestSiteInstallTestScript 27 30 */ 28 public function preinstall($db_prefix, $site_directory); 31 public function preinstall($db_prefix, $site_directory): void; - Comment on lines -28 to +31
changed this line in version 26 of the diff
23 23 * @param string $site_directory 24 24 * The site directory. 25 25 * 26 * @return void 27 * No return value. 28 * changed this line in version 26 of the diff
24 24 * 25 25 * @see \Drupal\TestSite\TestSiteInstallTestScript 26 26 */ 27 public function setup(); 27 public function setup(): void; changed this line in version 26 of the diff
@alexpott those typehints are required for the tests to pass.
https://git.drupalcode.org/issue/drupal-3301173/-/jobs/5756433
------ --------------------------------------------------------------------- Line core/tests/Drupal/TestSite/TestPreinstallInterface.php ------ --------------------------------------------------------------------- 28 Method Drupal\TestSite\TestPreinstallInterface::preinstall() has no return type specified. 🪪 missingType.return ------ --------------------------------------------------------------------- ------ ----------------------------------------------------------------------- Line core/tests/Drupal/TestSite/TestSetupInterface.php ------ ----------------------------------------------------------------------- 27 Method Drupal\TestSite\TestSetupInterface::setup() has no return type specified. 🪪 missingType.return ------ -----------------------------------------------------------------------