Skip to content
Snippets Groups Projects

Add starterkit functionality to Olivero (11.x)

Closes #3301173

Merge request reports

Members who can merge are allowed to add commits.
Code Quality is loading
Test summary results are being parsed
Metrics reports are loading
Ready to merge by members who can write to the target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Andy Blum added 1 commit

    added 1 commit

    • 7585cc4e - Copy over test changes from previous MR

    Compare with previous version

  • Andy Blum added 1 commit

    added 1 commit

    Compare with previous version

  • Andy Blum added 1 commit

    added 1 commit

    • b87ab560 - Point GenerateThemeTest to a different non-starterkit theme

    Compare with previous version

  • Andy Blum
  • Andy Blum mentioned in merge request !2996 (closed)

    mentioned in merge request !2996 (closed)

  • What is the current state of this issue? Will Olivero theme be available as a starterkit theme in the foreseeable future? Thanks for clearing things up.

  • Hi there, any progress or insights here? Would be very welcome and helpful for (I guess) alot of people if we have a great basis (a11y menu ...) which we could build frontend solutions upon it. Thanks for your time!

  • Andy Blum added 1895 commits

    added 1895 commits

    Compare with previous version

  • Andy Blum added 1895 commits

    added 1895 commits

    Compare with previous version

  • Andy Blum added 1 commit

    added 1 commit

    Compare with previous version

  • Andy Blum added 2 commits

    added 2 commits

    Compare with previous version

  • Andy Blum added 1 commit

    added 1 commit

    • 3dfdaa41 - remove Symfony Finder import

    Compare with previous version

  • Andy Blum added 1 commit

    added 1 commit

    • a9544eb0 - Update tests to work on Olivero & derivative starterkit

    Compare with previous version

  • Andy Blum resolved all threads

    resolved all threads

  • Andy Blum added 1 commit

    added 1 commit

    Compare with previous version

  • Looks great to me!

  • Andy Blum added 1 commit

    added 1 commit

    Compare with previous version

  • Andy Blum
  • Andy Blum added 2 commits

    added 2 commits

    • ccb3b92b - Generate theme in simpletest folders
    • f8513159 - Dont install newly generated theme in test setup

    Compare with previous version

  • Andy Blum resolved all threads

    resolved all threads

  • Matt Glaman added 1 commit

    added 1 commit

    • 644a51fc - don't pass HTTP_USER_AGENT when generating the theme

    Compare with previous version

  • Andy Blum added 36 commits

    added 36 commits

    Compare with previous version

  • Andrew Berry added 1 commit

    added 1 commit

    • f0594063 - Move the theme generation to be before the Drupal installer

    Compare with previous version

  • Andrew Berry added 1 commit

    added 1 commit

    • 46bb194e - Support separating apcu caches in nightwatch tests

    Compare with previous version

  • Andy Blum added 1 commit

    added 1 commit

    Compare with previous version

  • Andrew Berry added 1 commit

    added 1 commit

    • 892f001d - Set uniqueApcuNamespace for all Olivero tests

    Compare with previous version

  • Andy Blum added 1 commit

    added 1 commit

    • f23ad19f - Install generated theme in setup script

    Compare with previous version

  • Andy Blum added 1 commit

    added 1 commit

    • d607f7ae - Remove "olivero" reference in stickyHeaderTest

    Compare with previous version

  • Andy Blum added 1 commit

    added 1 commit

    Compare with previous version

  • Andy Blum added 1 commit

    added 1 commit

    Compare with previous version

  • Andy Blum added 1 commit

    added 1 commit

    Compare with previous version

  • Thanks for your efforts! Will this be merged into the next Drupal core release? Any idea when we finally will be able to use Olivero as a starterkit theme? Really looking forward to use this.

    Edited by Michael Zumstein
  • Author Developer

    This is unlikely to be a part of 11.2 - As of mid-May there were more than 120 issues in the RTBC queue and the priority was largely going to be first-in-first-out.

    I don't have a ton of insight into that process, but I would anticipate this landing in time for 11.3 in December-ish

  • 43 ]);
    44 $process->setTimeout(60);
    45 return $process;
    46 }
    18 47
    19 48 /**
    20 49 * {@inheritdoc}
    21 50 */
    22 public function setup() {
    51 public function setup(): void {
    52
    23 53 // Install required module for the Olivero front page.
    24 54 $module_installer = \Drupal::service('module_installer');
    25 55 assert($module_installer instanceof ModuleInstallerInterface);
    26 56 $module_installer->install(['olivero_test']);
    57 $module_installer->install(['nightwatch_theme_install_utility']);
  • 20 49 * {@inheritdoc}
    21 50 */
    22 public function setup() {
    51 public function setup(): void {
    52
    23 53 // Install required module for the Olivero front page.
    24 54 $module_installer = \Drupal::service('module_installer');
    25 55 assert($module_installer instanceof ModuleInstallerInterface);
    26 56 $module_installer->install(['olivero_test']);
    57 $module_installer->install(['nightwatch_theme_install_utility']);
    27 58
    28 59 // Install Olivero and set it as the default theme.
    29 60 $theme_installer = \Drupal::service('theme_installer');
    30 61 assert($theme_installer instanceof ThemeInstallerInterface);
    31 62 $theme_installer->install(['olivero'], TRUE);
    63 $theme_installer->install(['test_custom_theme'], TRUE);
  • 23 23 * @param string $site_directory
    24 24 * The site directory.
    25 25 *
    26 * @return void
    27 * No return value.
    28 *
    26 29 * @see \Drupal\TestSite\TestSiteInstallTestScript
    27 30 */
    28 public function preinstall($db_prefix, $site_directory);
    31 public function preinstall($db_prefix, $site_directory): void;
  • 23 23 * @param string $site_directory
    24 24 * The site directory.
    25 25 *
    26 * @return void
    27 * No return value.
    28 *
  • 24 24 *
    25 25 * @see \Drupal\TestSite\TestSiteInstallTestScript
    26 26 */
    27 public function setup();
    27 public function setup(): void;
  • Alex Pott left review comments

    left review comments

  • Andy Blum added 1 commit

    added 1 commit

    Compare with previous version

  • Author Developer

    @alexpott those typehints are required for the tests to pass.

    https://git.drupalcode.org/issue/drupal-3301173/-/jobs/5756433

    ------ --------------------------------------------------------------------- 
      Line   core/tests/Drupal/TestSite/TestPreinstallInterface.php               
     ------ --------------------------------------------------------------------- 
      28     Method Drupal\TestSite\TestPreinstallInterface::preinstall() has no  
             return type specified.                                               
             🪪  missingType.return                                               
     ------ --------------------------------------------------------------------- 
     ------ ----------------------------------------------------------------------- 
      Line   core/tests/Drupal/TestSite/TestSetupInterface.php                      
     ------ ----------------------------------------------------------------------- 
      27     Method Drupal\TestSite\TestSetupInterface::setup() has no return type  
             specified.                                                             
             🪪  missingType.return                                                 
     ------ ----------------------------------------------------------------------- 
  • Please register or sign in to reply
    Loading