Fix @todo item.
1 open thread
Closes #3008943
Merge request reports
Activity
135 135 * The parent entity. 136 136 */ 137 137 public function handleEntityDelete(EntityInterface $entity) { 138 // @todo In https://www.drupal.org/node/3008943 call 139 // \Drupal\layout_builder\LayoutEntityHelperTrait::isLayoutCompatibleEntity(). 140 $this->usage->removeByLayoutEntity($entity); 138 if ($this->isLayoutCompatibleEntity($entity)) { 139 $this->usage->removeByLayoutEntity($entity); 140 } - Comment on lines -138 to +140
changed this line in version 2 of the diff
You're right to question the necessity of this check. I removed the
isLayoutCompatibleEntity($entity)
verification before callingremoveByLayoutEntity($entity)
, as it seemed redundant.I ran the full test suite, including kernel and functional tests for Layout Builder, and they all passed successfully without any errors. This indicates that calling removeByLayoutEntity() unconditionally does not introduce any issues.
Edited by Brandon Lira
added 1 commit
added 1811 commits
-
64bff19c...501bbdbe - 1809 commits from branch
project:11.x
- 61bd4dcc - Fix @todo item.
- 52ec6356 - Issue #3008943: Removed isLayoutCompatibleEntity() verification before calling...
-
64bff19c...501bbdbe - 1809 commits from branch
Please register or sign in to reply