New "Config validatability" GitLab CI job
Closes #3422641
Merge request reports
Activity
added 1 commit
-
9aed7d02 - Slightly adjust syntax because either GitLab CI or YAML does not seem to like this
-
9aed7d02 - Slightly adjust syntax because either GitLab CI or YAML does not seem to like this
added 1 commit
- d6d42e84 - Mark both `type: label` and `type: core.date_format.*` as NOT fully...
added 1 commit
- e3443159 - Restore validatability of `type: label` and `type: core.date_format.*`.
added 1 commit
454 - MR.json 455 script: 456 # Revert back to the tip of the branch this MR started from. 457 - git checkout $CI_MERGE_REQUEST_DIFF_BASE_SHA 458 # Composer-install Drush & the Config Inspector module. 459 - composer require drush/drush drupal/config_inspector 460 # Install Drupal's Standard install profile + the config inspector module. 461 - vendor/bin/drush site-install standard --yes --quiet --db-url=sqlite://sites/default/files/.ht.sqlite 462 - vendor/bin/drush pm:install config_inspector --yes --quiet 463 # Compute config validatability statistics for HEAD. 464 - vendor/bin/drush config:inspect --statistics > HEAD.json 465 # Return to the MR commit being tested, conditionally install updates, always rebuild the container. 466 - git checkout $CI_COMMIT_SHA 467 - git diff $CI_MERGE_REQUEST_DIFF_BASE_SHA $CI_COMMIT_SHA --name-only | grep -q '.install$\|.post_update\.php$' && echo '🤖 Installing DB updates…' && vendor/bin/drush updatedb --yes --quiet 468 - vendor/bin/drush cr --quiet 469 # Compute config validatability statistics for HEAD. changed this line in version 11 of the diff
added 1 commit
453 - HEAD.json 454 - MR.json 455 # This job must pass, but must also not disrupt Drupal core's CI if dependencies are not core-compatible. 456 allow_failure: 457 exit_codes: 458 # `composer require …` fails (implies no version available compatible with Drupal core) 459 - 100 460 # `drush pm:install config_inspector …` fails (implies failure during module installation) 461 - 101 462 script: 463 # Revert back to the tip of the branch this MR started from. 464 - git checkout $CI_MERGE_REQUEST_DIFF_BASE_SHA 465 # Composer-install Drush & the Config Inspector module. 466 - composer require drush/drush drupal/config_inspector || exit 100 467 # Install Drupal's Standard install profile + the config inspector module. 468 - vendor/bin/drush site-install standard --yes --quiet --db-url=sqlite://sites/default/files/.ht.sqlite So any modules that are not part of standard are not validated? So there will be things that are missed? And also there will be times this runs and it will not actually validate the changes?
This is why we've done config validate according to schema as part of the regular test infra. There'll be some much config that core can generate that this job misses.
-
So any modules that are not part of standard are not validated? So there will be things that are missed?
Correct.
And also there will be times this runs and it will not actually validate the changes?
Do you mean that if config/config schema that is changed in a MR that is not part of the Standard install profile, that this would be blissfully unaware? If so, the answer is "yes", for the same reason as above.
On it!
-
Done: 93dd0265
changed this line in version 16 of the diff
added 73 commits
-
64a5198e...36c3154f - 71 commits from branch
project:11.x - e934cfbc - Merge remote-tracking branch 'origin/11.x' into 3422641-PoC
- e7bb5683 - @longwave review: remove the word "validatability".
-
64a5198e...36c3154f - 71 commits from branch
added 1 commit
added 1 commit
-
ee607c0d -
-
ee607c0d -
added 122 commits
-
ee607c0d...1e827843 - 121 commits from branch
project:11.x - a2ef924e - Merge remote-tracking branch 'origin/11.x' into 3422641-PoC
-
ee607c0d...1e827843 - 121 commits from branch
added 1 commit
- 7b84194c - Revert all changes outside of `.gitlab-ci.yml`.
added 1 commit
