Issue #3421206: incorrect docs for LocaleConfigSubscriberTest::assertTranslation()
6 open threads
Updated the assertTranslation() method's annotation to correctly reflect its functionality.
Merge request reports
Activity
467 470 * @param string $langcode 468 471 * The language code. 469 472 * @param bool $customized 470 * Whether or not the string should be asserted to be customized or not 471 * customized. 473 * A boolean value that dictates if the method should assert the translation 474 * to be 'customized' (if true) or 'not customized' (if false). The default changed this line in version 2 of the diff
458 458 } 459 459 460 460 /** 461 * Ensures a translation exists and is marked as customized. 461 * Checks if a specific translation exists and asserts its customization status. 462 * 463 * This method asserts if a specific translation exists and if it is marked 464 * as 'customized' or 'not customized' based on the value passed to $customized. changed this line in version 2 of the diff
added 1 commit
458 458 } 459 459 460 460 /** 461 * Ensures a translation exists and is marked as customized. 461 * Checks if a specific translation exists and asserts its customization status. changed this line in version 3 of the diff
458 458 } 459 459 460 460 /** 461 * Ensures a translation exists and is marked as customized. 461 * Checks if a specific translation exists and asserts its customization status. 462 * 463 * This method asserts if a specific translation exists and if it is marked 464 * as customized or not customized based on the value passed to $customized. - Comment on lines +463 to +464
I don't think this adds any value, it just repeats what is said above.
Edited by Dave Long changed this line in version 3 of the diff
467 470 * @param string $langcode 468 471 * The language code. 469 472 * @param bool $customized 470 * Whether or not the string should be asserted to be customized or not 471 * customized. 473 * (optional) A boolean value that dictates if the method should assert the translation 474 * to be customized (if TRUE) or not customized (if FALSE). The default 475 * value is TRUE. - Comment on lines +473 to +475
This also needs rewrapping at 80 characters.
473 * (optional) A boolean value that dictates if the method should assert the translation 474 * to be customized (if TRUE) or not customized (if FALSE). The default 475 * value is TRUE. 473 * (optional) If TRUE, asserts that the translation is customised. If FALSE, 474 * asserts that the translation is not customised. Defaults to TRUE. changed this line in version 3 of the diff
added 1 commit
467 467 * @param string $langcode 468 468 * The language code. 469 469 * @param bool $customized 470 * Whether or not the string should be asserted to be customized or not 471 * customized. 470 * (optional) If TRUE/FALSE, asserts that the translation changed this line in version 8 of the diff
Please register or sign in to reply