Skip to content
Snippets Groups Projects

Issue #3414208 Add support for tagged_iterator to YamlFileLoader

Issue #3414208 Add support for tagged_iterator to YamlFileLoader
issue/drupal-3414208:3414208-tagged-iterator into 11.x
1 open thread
Closed
Kim Pepperrequested to merge
issue/drupal-3414208:3414208-tagged-iterator into 11.x
1 open thread

Closes #3414208

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dave Long added 50 commits

    added 50 commits

    Compare with previous version

    Toggle commit list
  • Kim Pepper resolved all threads

    resolved all threads

  • Kim Pepper added 24 commits

    added 24 commits

    Compare with previous version

  • Kim Pepper added 111 commits

    added 111 commits

    Compare with previous version

  • Kim Pepper added 2 commits

    added 2 commits

    Compare with previous version

  • Kim Pepper added 113 commits

    added 113 commits

    Compare with previous version

  • Kim Pepper added 1 commit

    added 1 commit

    Compare with previous version

  • Dave Long added 13 commits

    added 13 commits

    • 650b7ad7...f4bf71d6 - 6 commits from branch project:11.x
    • 89e4fa84 - Issue #3414208 Add support for tagged_iterator to YamlFileLoader
    • ff2b17b0 - Add PARSE_CUSTOM_TAGS flag
    • 13b29262 - Add dumper support
    • 785c31e3 - Revert "Add dumper support"
    • 7b812445 - Add support for lazy iterators to OptimizedPhpArrayDumper.
    • 47aed4e0 - Add YAML loader test for \!tagged_iterator.
    • 96977f81 - Add test coverage to ensure iterators remain lazy.

    Compare with previous version

    Toggle commit list
  • Dave Long added 1 commit

    added 1 commit

    • 617bff6a - Add test coverage to ensure iterators remain lazy.

    Compare with previous version

  • Kim Pepper added 1 commit

    added 1 commit

    • d80cb238 - Handle iterator type in PhpArrayContainer

    Compare with previous version

  • catch @catch started a thread on the diff
    • core/tests/Drupal/Tests/Component/DependencyInjection/Dumper/OptimizedPhpArrayDumperTest.php
    695 695 ];
    696 696 }
    697 697
    698 /**
    699 * Helper function to return a machine-optimized iterator.
    700 */
    701 protected static function getIterator($collection) {
    • catch @catch
      Maintainer
      Suggested change
      701 protected static function getIterator($collection) {
      701 protected static function getIterator($collection): \stdClass {
    • catch @catch
      Maintainer

      Could also use phpdoc for the $collector param.

      Although also if this is only used in one method, can it just be a closure defined directly in the method maybe? Saves writing docs that way.

    • catch @catch
      Maintainer

      Wait this is purely a helper for the test, scratch the above it's fine like it is here I think.

    • Please register or sign in to reply
  • Kim Pepper closed

    closed

    • Please register or sign in to reply