Skip to content
Snippets Groups Projects

Resolve #2509436 "Make cachepluginbasegenerateresultskey to"

2 unresolved threads

Closes #2509436

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • dimitriskr added 103 commits

    added 103 commits

    Compare with previous version

  • dimitriskr resolved all threads

    resolved all threads

  • dimitriskr added 1 commit

    added 1 commit

    • 3e85738b - switch assert to actual php code

    Compare with previous version

  • dimitriskr added 1 commit

    added 1 commit

    Compare with previous version

  • dimitriskr marked this merge request as ready

    marked this merge request as ready

  • 123 123 else {
    124 124 $result->cacheMaxAge = Cache::mergeMaxAges($this->cacheMaxAge, $other->cacheMaxAge);
    125 125 }
    126 assert($result instanceof CacheableMetadata);
  • 28 28 // All arguments requested. Use normalized query string to minimize
    29 29 // variations.
    30 30 $value = $this->requestStack->getCurrentRequest()->getQueryString();
    31 return ($value !== NULL) ? $value : '';
    31 return ($value !== NULL) ? (string) $value : '';
    32 32 }
    33 33 elseif ($this->requestStack->getCurrentRequest()->query->has($query_arg)) {
    34 34 $value = $this->requestStack->getCurrentRequest()->query->all()[$query_arg];
    35 35 if (is_array($value)) {
    36 return http_build_query($value);
    36 return http_build_query([$query_arg => $value], '', '&');
    Please register or sign in to reply
    Loading