Resolve #3410128 "Remove remaining unnecessary"
4 unresolved threads
Closes #3410128
Merge request reports
Activity
added 2 commits
added 1295 commits
-
67b9a537...9a6641de - 1273 commits from branch
project:11.x
- 9a6641de...46627c26 - 12 earlier commits
- dc324ff8 - Fix BlockManagerTest.
- 82661c99 - fix EntityDefinitionUpdateTest
- b9bfd64b - fix XssUnitTest
- 2dbec174 - fix LocaleUpdateTest
- cd84ff5f - BlockContentTest.php
- 1972545f - DateRangeFieldTest.php
- 240ff525 - migrate and migrate_drupal
- d3ac0fa1 - ProgrammaticTest.php
- f75318d3 - EntityViewsDataTest.php
- e5865158 - remove unused use statement
Toggle commit list-
67b9a537...9a6641de - 1273 commits from branch
added 219 commits
-
e5865158...302ee049 - 196 commits from branch
project:11.x
- 302ee049...ad1ce967 - 13 earlier commits
- a77190b5 - fix EntityDefinitionUpdateTest
- 5e322df9 - fix XssUnitTest
- ae63764e - fix LocaleUpdateTest
- e19168bd - BlockContentTest.php
- 8d6bd459 - DateRangeFieldTest.php
- 50be8547 - migrate and migrate_drupal
- 98cff324 - ProgrammaticTest.php
- 9fea31b8 - EntityViewsDataTest.php
- 1c8848e0 - remove unused use statement
- e4bf3e65 - Add stringtranslationtrait for 4 tests
Toggle commit list-
e5865158...302ee049 - 196 commits from branch
added 38 commits
-
7ec78bdd...35dbb2d4 - 5 commits from branch
project:11.x
- 35dbb2d4...2bdb15ff - 23 earlier commits
- 2b71fdb1 - typo
- a0737a4c - MigrateEntityContentValidationTest.php
- cd7e81fb - NavigationLogoTest.php
- 4dc7c1e3 - NodeTypeTranslationTest.php
- 3556a4c3 - ToolbarAdminMenuTest.php
- 4c76ef78 - more
- a463576d - 2 more
- 8feb7b5a - revert out of scope
- 826408c4 - restore blockmanagertest.php
- 72684da2 - restore componentrendertest.php
Toggle commit list-
7ec78bdd...35dbb2d4 - 5 commits from branch
added 171 commits
-
72684da2...ee585649 - 137 commits from branch
project:11.x
- ee585649...26e1029b - 24 earlier commits
- 91302ba1 - MigrateEntityContentValidationTest.php
- dc412a6e - NavigationLogoTest.php
- dba3eaf3 - NodeTypeTranslationTest.php
- 3a9d73f3 - ToolbarAdminMenuTest.php
- d97ae107 - more
- 15f5d2cb - 2 more
- 4da37152 - revert out of scope
- 89ab17a8 - restore blockmanagertest.php
- a8c2a7e8 - restore componentrendertest.php
- 73dbafff - 4 more files
Toggle commit list-
72684da2...ee585649 - 137 commits from branch
34 34 */ 35 35 public function fields() { 36 36 $fields = [ 37 'id' => $this->t('Id'), 38 'title' => $this->t('Title'), 39 'changed' => $this->t('Changed'), 37 'id' => 'Id', 38 'title' => 'Title', 39 'changed' => 'Changed', changed this line in version 13 of the diff
91 91 92 92 // Base fields for the test entity types. 93 93 $this->commonBaseFields['name'] = BaseFieldDefinition::create('string') 94 ->setLabel(t('Name')) 95 ->setDescription(t('The name of the test entity.')) 94 ->setLabel('Name') 95 ->setDescription('The name of the test entity.') The basefield definitions in this file are inconsistent with the use of t. The ones with t were added when this was converted from a unit test in this commit.
Searched core and this is the only usage outside of core/tests/Drupal/KernelTests/Core/Entity/EntityDefinitionUpdateTest.php and core/tests/Drupal/KernelTests/Core/Entity/FieldableEntityDefinitionUpdateTest.php both of which at least use the language module. This one does not.
All together I go for removing t. So left this for now.
85 85 86 86 $form['submit'] = [ 87 87 '#type' => 'submit', 88 '#value' => t('Submit'), 612 612 $this->assertEquals(1, $violations->count()); 613 613 614 614 // Test translating violation messages. 615 $message = t('This value should be %limit or more.', ['%limit' => 5]); 615 $message = 'This value should be 5 or more.'; changed this line in version 13 of the diff
added 59 commits
-
73dbafff...97f169b6 - 24 commits from branch
project:11.x
- 97f169b6...0f652f5a - 25 earlier commits
- e76ab9fb - NavigationLogoTest.php
- 402549b0 - NodeTypeTranslationTest.php
- 67c2cc85 - ToolbarAdminMenuTest.php
- a3c2aac9 - more
- 6ce8f29d - 2 more
- bb6abd55 - revert out of scope
- e2236df8 - restore blockmanagertest.php
- d871bbf5 - restore componentrendertest.php
- 0e3da393 - 4 more files
- 09476abf - respond to feedback
Toggle commit list-
73dbafff...97f169b6 - 24 commits from branch
assigned to @quietone
unassigned @quietone
added 161 commits
-
09476abf...4548e070 - 126 commits from branch
project:11.x
- 4548e070...dd0db282 - 25 earlier commits
- 67ec2afa - NavigationLogoTest.php
- 01c37ea6 - NodeTypeTranslationTest.php
- 6d685db9 - ToolbarAdminMenuTest.php
- 9ccd1fc0 - more
- c7fef99e - 2 more
- bb15469b - revert out of scope
- d294ae76 - restore blockmanagertest.php
- df4014cb - restore componentrendertest.php
- a8a85f98 - 4 more files
- 3ead9961 - respond to feedback
Toggle commit list-
09476abf...4548e070 - 126 commits from branch
Please register or sign in to reply