Resolve #3020422 "Toolbar style update"
Closes #3020422
Merge request reports
Activity
added 1 commit
440 440 } 441 441 } 442 442 } 443 444 if (isset($variables['theme_hook_original']) && substr($variables['theme_hook_original'], 0, 14) === 'links__toolbar' ) { PHPCS complained about this line:
Checking core/themes/claro/claro.theme FILE: /var/www/html/core/themes/claro/claro.theme ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 444 | ERROR | [x] There should be no white space before a closing | | ")" ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- Time: 322ms; Memory: 16MB
Here is a fix:
changed this line in version 4 of the diff
207 207 * Breadcrumb. 208 208 */ 209 209 --breadcrumb-height: 1.25rem; 210 /** 210 /* Toolbar */ postcss didn't like this line:
Checking core/themes/claro/css/base/variables.pcss.css yarn run v1.22.5 $ cross-env BABEL_ENV=legacy node ./scripts/css/postcss-build.js --check --file /var/www/html/core/themes/claro/css/base/variables.pcss.css [21:29:27] '/var/www/html/core/themes/claro/css/base/variables.pcss.css' is being checked. Done in 1.50s. themes/claro/css/base/variables.pcss.css 210:4 ✖ Expected indentation of 2 spaces indentation
Suggested fix:
Edited by Joe Parsonschanged this line in version 4 of the diff
243 --toolbar-tray-link-padding-start--level4: calc(var(--toolbar-tray-link-padding-start--level3) + var(--toolbar-tray-link-padding--vertical)); 244 --toolbar-tray-link-line-height: 1.25rem; /* Line height must be higher than horizontal to account for text wrapping. */ 245 --toolbar-icon-item-width--only-icon: calc(var(--toolbar-icon-width) * 3); 246 --toolbar-icon-item-padding-start: calc(var(--space-m) + var(--space-xs) + var(--toolbar-icon-position-start)); 247 --toolbar-icon-item-padding-end: calc(var(--toolbar-icon-item-width--only-icon) + var(--space-m)); 248 --toolbar-icon-width: var(--space-m); 249 --toolbar-icon-position-start: calc(var(--space-m) - 1px); 250 --toolbar-orientation-toggle-bg-color: var(--color-white); 251 --toolbar-orientation-toggle-size: 2.75rem; 252 --toolbar-handle-bg-color--hover: var(--color-bgblue-hover); 253 --toolbar-handle-bg-color--active: var(--color-bgblue-active); 254 --toolbar-tray-z-index: 501; 255 --toolbar-icon-z-index: calc(var(--toolbar-tray-z-index) + 1); 256 --toolbar-bar-z-index: calc(var(--toolbar-tray-z-index) + 1); 257 --toolbar-tray-z-index--active: calc(var(--toolbar-icon-z-index) + 1); 258 /** postcss didn't like this line:
Checking core/themes/claro/css/base/variables.pcss.css yarn run v1.22.5 $ cross-env BABEL_ENV=legacy node ./scripts/css/postcss-build.js --check --file /var/www/html/core/themes/claro/css/base/variables.pcss.css [21:29:27] '/var/www/html/core/themes/claro/css/base/variables.pcss.css' is being checked. Done in 1.50s. themes/claro/css/base/variables.pcss.css 258:5 ✖ Expected indentation of 2 spaces indentation
Suggested fix:
changed this line in version 4 of the diff
added 1 commit
- 1f98ce8a - perhaps this will be an easier custom commands debug
added 1 commit
- 726f527a - change svg path so it has case-sensitive pathname
added 362 commits
-
a364c137...213a5659 - 361 commits from branch
project:9.3.x
- dff2c017 - Merge remote-tracking branch 'origin/9.3.x' into 3020422-toolbar-style-update
-
a364c137...213a5659 - 361 commits from branch
added 462 commits
-
c1b65e34...88adf9c1 - 450 commits from branch
project:9.3.x
- c22e1ae0 - #3020422: Rerolling patch to initialize issue fork.
- 31812c84 - #3020422: Fixing small issue on patch apply.
- b6f2daaa - #3020422: Fixed two declaration of claro_preprocess_toolbar().
- 4fb82f1c - pulled
- b7b675fc - fix customcommands errors
- 45bc1ad9 - to debug custom command error
- 16241237 - perhaps this will be an easier custom commands debug
- 5de4ae67 - debug the correct variables
- accfa69e - change svg path so it has case-sensitive pathname
- 14fd7514 - merge cleanup
- dd0aaa79 - fix claro template so test passes
- 8475729f - Toolbar style update - #3020422
Toggle commit list-
c1b65e34...88adf9c1 - 450 commits from branch
added 187 commits
-
4bc0b451...45c63730 - 174 commits from branch
project:9.3.x
- a91d1650 - #3020422: Rerolling patch to initialize issue fork.
- c3059a5c - #3020422: Fixing small issue on patch apply.
- ef9d47da - #3020422: Fixed two declaration of claro_preprocess_toolbar().
- ac29ae08 - pulled
- ba7541f9 - fix customcommands errors
- 04ac5158 - to debug custom command error
- cd04ff93 - perhaps this will be an easier custom commands debug
- 56445c21 - debug the correct variables
- 96ebc007 - change svg path so it has case-sensitive pathname
- 62e7baa1 - merge cleanup
- 9de7b91d - fix claro template so test passes
- 9c6ff2b8 - Toolbar style update - #3020422
- eb942de3 - Toolbar style update
Toggle commit list-
4bc0b451...45c63730 - 174 commits from branch
Please register or sign in to reply