Skip to content
Snippets Groups Projects

Resolve #3020422 "Toolbar style update"

Open nicoloye requested to merge issue/drupal-3020422:3020422-toolbar-style-update into 9.4.x

Closes #3020422

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
440 440 }
441 441 }
442 442 }
443
444 if (isset($variables['theme_hook_original']) && substr($variables['theme_hook_original'], 0, 14) === 'links__toolbar' ) {
  • PHPCS complained about this line:

    Checking core/themes/claro/claro.theme
    
    FILE: /var/www/html/core/themes/claro/claro.theme
    ----------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------
     444 | ERROR | [x] There should be no white space before a closing
         |       |     ")"
    ----------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------
    
    Time: 322ms; Memory: 16MB

    Here is a fix:

    Suggested change
    444 if (isset($variables['theme_hook_original']) && substr($variables['theme_hook_original'], 0, 14) === 'links__toolbar' ) {
    444 if (isset($variables['theme_hook_original']) && substr($variables['theme_hook_original'], 0, 14) === 'links__toolbar') {
  • changed this line in version 4 of the diff

  • Please register or sign in to reply
  • 207 207 * Breadcrumb.
    208 208 */
    209 209 --breadcrumb-height: 1.25rem;
    210 /**
    210 /* Toolbar */
  • 243 --toolbar-tray-link-padding-start--level4: calc(var(--toolbar-tray-link-padding-start--level3) + var(--toolbar-tray-link-padding--vertical));
    244 --toolbar-tray-link-line-height: 1.25rem; /* Line height must be higher than horizontal to account for text wrapping. */
    245 --toolbar-icon-item-width--only-icon: calc(var(--toolbar-icon-width) * 3);
    246 --toolbar-icon-item-padding-start: calc(var(--space-m) + var(--space-xs) + var(--toolbar-icon-position-start));
    247 --toolbar-icon-item-padding-end: calc(var(--toolbar-icon-item-width--only-icon) + var(--space-m));
    248 --toolbar-icon-width: var(--space-m);
    249 --toolbar-icon-position-start: calc(var(--space-m) - 1px);
    250 --toolbar-orientation-toggle-bg-color: var(--color-white);
    251 --toolbar-orientation-toggle-size: 2.75rem;
    252 --toolbar-handle-bg-color--hover: var(--color-bgblue-hover);
    253 --toolbar-handle-bg-color--active: var(--color-bgblue-active);
    254 --toolbar-tray-z-index: 501;
    255 --toolbar-icon-z-index: calc(var(--toolbar-tray-z-index) + 1);
    256 --toolbar-bar-z-index: calc(var(--toolbar-tray-z-index) + 1);
    257 --toolbar-tray-z-index--active: calc(var(--toolbar-icon-z-index) + 1);
    258 /**
  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • c5291ca3 - to debug custom command error

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • 1f98ce8a - perhaps this will be an easier custom commands debug

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • 726f527a - change svg path so it has case-sensitive pathname

    Compare with previous version

  • nicoloye changed target branch from 9.2.x to 9.3.x

    changed target branch from 9.2.x to 9.3.x

  • Ben Mullins added 2 commits

    added 2 commits

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • a364c137 - fix claro template so test passes

    Compare with previous version

  • Ben Mullins added 362 commits

    added 362 commits

    • a364c137...213a5659 - 361 commits from branch project:9.3.x
    • dff2c017 - Merge remote-tracking branch 'origin/9.3.x' into 3020422-toolbar-style-update

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Konstantin Shupenko added 462 commits

    added 462 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Konstantin Shupenko added 187 commits

    added 187 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading