Skip to content
Snippets Groups Projects

Issue #2833116 by mohit_aghera, smustgrave, Ratan Priya: When Placing a Block...

Issue #2833116 by mohit_aghera, smustgrave, Ratan Priya: When Placing a Block...

Issue #2833116 by mohit_aghera, smustgrave, Ratan Priya: When Placing a Block on 'Configure Block' page the originally selected region is lost

Closes #2833116

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 18 commits

    • ce5db255...a6a0523e - 16 commits from branch project:11.x
    • 6d54578c - Merge branch '11.x' of git.drupal.org:project/drupal into 2833116-when-placing-a
    • 101a206b - Address feedback

    Compare with previous version

  • Stephen Mustgrave resolved all threads

    resolved all threads

  • Mohit Aghera added 1 commit

    added 1 commit

    Compare with previous version

  • Mohit Aghera added 1 commit

    added 1 commit

    Compare with previous version

  • added 37 commits

    • 4da577fb...e8778fb2 - 36 commits from branch project:11.x
    • 9d728667 - Merge branch '11.x' of git.drupal.org:project/drupal into 2833116-when-placing-a

    Compare with previous version

  • Stephen Mustgrave resolved all threads

    resolved all threads

  • I think if we limit the DI to the plugin that needs it we can reduce 75% of the patch changes here

  • added 67 commits

    • 9d728667...ba827d46 - 65 commits from branch project:11.x
    • 37903fcb - Merge branch '11.x' of git.drupal.org:project/drupal into 2833116-when-placing-a
    • 71835399 - address feedbackDrupalblock_contentPluginMenuLocalActionBlockContentAddLocalAction::

    Compare with previous version

  • Stephen Mustgrave resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • 10 13 * Modifies the 'Add content block' local action.
    11 14 */
    12 15 class BlockContentAddLocalAction extends LocalActionDefault {
    13 16
    17 /**
    18 * Constructs a LocalActionDefault object.
    19 *
    20 * @param array $configuration
    21 * A configuration array containing information about the plugin instance.
    22 * @param string $plugin_id
    23 * The plugin_id for the plugin instance.
    24 * @param mixed $plugin_definition
    25 * The plugin implementation definition.
    26 * @param \Drupal\Core\Routing\RouteProviderInterface $routeProvider
    27 * The route provider to load routes by name.
    28 * @param \Symfony\Component\HttpFoundation\RequestStack $requestStack
  • Stephen Mustgrave added 431 commits

    added 431 commits

    • b7b70963...331141c7 - 429 commits from branch project:11.x
    • db48ae21 - Merge branch '11.x' of git.drupal.org:project/drupal into 2833116-when-placing-a
    • c78a6189 - Address feedback

    Compare with previous version

  • 21 * A configuration array containing information about the plugin instance.
    22 * @param string $plugin_id
    23 * The plugin_id for the plugin instance.
    24 * @param mixed $plugin_definition
    25 * The plugin implementation definition.
    26 * @param \Drupal\Core\Routing\RouteProviderInterface $routeProvider
    27 * The route provider to load routes by name.
    28 * @param \Symfony\Component\HttpFoundation\RequestStack $requestStack
    29 * The current request.
    30 */
    31 public function __construct(
    32 array $configuration,
    33 $plugin_id,
    34 $plugin_definition,
    35 RouteProviderInterface $routeProvider,
    36 protected RequestStack $requestStack) {
  • added 1 commit

    • dbf5114e - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 2 commits

    • 6070d23c - PHPCS
    • a0d826d4 - Merge branch '2833116-when-placing-a' of git.drupal.org:issue/drupal-2833116...

    Compare with previous version

  • 11 14 */
    12 15 class BlockContentAddLocalAction extends LocalActionDefault {
    13 16
    17 /**
    18 * Constructs a LocalActionDefault object.
    19 *
    20 * @param array $configuration
    21 * A configuration array containing information about the plugin instance.
    22 * @param string $plugin_id
    23 * The plugin_id for the plugin instance.
    24 * @param mixed $plugin_definition
    25 * The plugin implementation definition.
    26 * @param \Drupal\Core\Routing\RouteProviderInterface $routeProvider
    27 * The route provider to load routes by name.
    28 * @param \Symfony\Component\HttpFoundation\RequestStack $requestStack
    29 * The current request.
    • Comment on lines +18 to +29
      Suggested change
      Applied
      18 * Constructs a LocalActionDefault object.
      19 *
      20 * @param array $configuration
      21 * A configuration array containing information about the plugin instance.
      22 * @param string $plugin_id
      23 * The plugin_id for the plugin instance.
      24 * @param mixed $plugin_definition
      25 * The plugin implementation definition.
      26 * @param \Drupal\Core\Routing\RouteProviderInterface $routeProvider
      27 * The route provider to load routes by name.
      28 * @param \Symfony\Component\HttpFoundation\RequestStack $requestStack
      29 * The current request.
      18 * Constructs a BlockContentAddLocalAction object.
    • Adam Bramley changed this line in version 14 of the diff

      changed this line in version 14 of the diff

    • Please register or sign in to reply
  • Stephen Mustgrave added 106 commits

    added 106 commits

    • a0d826d4...1e827843 - 105 commits from branch project:11.x
    • 4ec9d153 - Merge branch '11.x' of git.drupal.org:project/drupal into 2833116-when-placing-a

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Adam Bramley added 1 commit

    added 1 commit

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    • 2c936928 - Apply 3 suggestion(s) to 3 file(s)

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    • a256e2de - Apply 2 suggestion(s) to 2 file(s)

    Compare with previous version

  • Please register or sign in to reply
    Loading