Skip to content
Snippets Groups Projects

Issue #3123070: Fix 'PSR2.Classes.PropertyDeclaration.Underscore' coding standard

Closed Issue #3123070: Fix 'PSR2.Classes.PropertyDeclaration.Underscore' coding standard
issue/drupal-3123070:3123070-fix-psr2.classes.propertydeclaration.underscore-coding into 9.3.x
1 unresolved thread
Closed spokje requested to merge issue/drupal-3123070:3123070-fix-psr2.classes.propertydeclaration.underscore-coding into 9.3.x
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/phpcs.xml.dist
281 284 <severity>0</severity>
282 285 </rule>
283 286 <rule ref="Squiz.ControlStructures.ForLoopDeclaration"/>
284 <!-- Disable some error messages that we already cover. -->
  • quietone
    quietone @quietone
    Maintainer

    How is this related to the issue?

  • spokje
    spokje @Spokje
    Author

    Not at all, but it's a duplicate of line 276.

    Seemed overkill to create an issue for a one line deletion, but you're absolutely right that it is technically out of scope.

    Up to your discretion if you want this one in or not.

    Edited by spokje
  • Please register or sign in to reply
  • quietone
  • spokje added 11 commits

    added 11 commits

    Compare with previous version

  • spokje added 3 commits

    added 3 commits

    • 51f233f6 - Added explanatory remark
    • e7fc0994 - What was I (not) thinking here...
    • 51200de8 - Merge branch '3123070-fix-psr2.classes.propertydeclaration.underscore-coding'...

    Compare with previous version

  • spokje changed the description

    changed the description

  • spokje changed target branch from 9.1.x to 9.3.x

    changed target branch from 9.1.x to 9.3.x

  • spokje closed

    closed

    • Please register or sign in to reply