Issue #2924782: Missing @var annotation for arrays that provide default values
Merge request reports
Activity
added 8 commits
-
23b2810c...40a123ae - 4 commits from branch
project:9.2.x
- e3d12dcf - Removed sniff Drupal.Commenting.VariableComment.MissingVar from exclusion
- b55d2901 - Round 1
- 4b63964a - Round 2
- 4b1482c5 - Be more specific
Toggle commit list-
23b2810c...40a123ae - 4 commits from branch
added 21 commits
-
4b1482c5...528f1878 - 17 commits from branch
project:9.2.x
- 0c6b31f5 - Removed sniff Drupal.Commenting.VariableComment.MissingVar from exclusion
- c0106581 - Round 1
- ff1379dc - Round 2
- 1f255e0c - Be more specific
Toggle commit list-
4b1482c5...528f1878 - 17 commits from branch
added 41 commits
-
1f255e0c...20205709 - 37 commits from branch
project:9.2.x
- 46813da7 - Removed sniff Drupal.Commenting.VariableComment.MissingVar from exclusion
- b605be74 - Round 1
- a3b4b803 - Round 2
- 638c8aea - Be more specific
Toggle commit list-
1f255e0c...20205709 - 37 commits from branch
added 38 commits
-
70aa933f...a3ca88eb - 37 commits from branch
project:9.3.x
- d2393f7b - Merge branch '9.3.x' into 2924782-missing-var-annotation
-
70aa933f...a3ca88eb - 37 commits from branch
- Resolved by quietone
- Resolved by spokje
added 294 commits
-
092d1e2e...b6efcaf6 - 293 commits from branch
project:9.3.x
- 983e7b99 - Merge branch '9.3.x' into 2924782-missing-var-annotation
-
092d1e2e...b6efcaf6 - 293 commits from branch
added 452 commits
-
6aba761d...b8c9366c - 451 commits from branch
project:9.4.x
- fc9aaa8b - Merge branch '9.4.x' into 2924782-missing-var-annotation
-
6aba761d...b8c9366c - 451 commits from branch
added 12 commits
-
c0070839...10d7b48a - 11 commits from branch
project:9.4.x
- 63ef7da7 - Merge branch '9.4.x' into 2924782-missing-var-annotation
-
c0070839...10d7b48a - 11 commits from branch
- Resolved by spokje
65 65 * transliterates to more than one ASCII character require special 66 66 * treatment: we want to remove their accent and use the un- 67 67 * transliterated base character. 68 * 69 * @var string[] added 9 commits
-
63ef7da7...b1965205 - 8 commits from branch
project:9.4.x
- ce1cf8aa - Merge branch '9.4.x' into 2924782-missing-var-annotation
-
63ef7da7...b1965205 - 8 commits from branch
18 18 19 19 /** 20 20 * An array holding flood events, keyed by event name and identifier. 21 * 22 * @var object[] I am not sure this is an array of objects. See the usages at https://git.drupalcode.org/project/drupal/-/blob/9.4.x/core/lib/Drupal/Core/Flood/MemoryBackend.php#L44 and https://git.drupalcode.org/project/drupal/-/blob/9.4.x/core/lib/Drupal/Core/Flood/MemoryBackend.php#L78
33 33 */ 34 34 protected $defaultTheme = 'classy'; 35 35 36 /** 37 * @var array 38 */ 36 39 protected $regions; This variable is not used, it was added in 2013, [#1535868]. Probably best to make a followup for that and postpone on this to avoid re-rolls.
67 * 68 * @var \Drupal\user\Entity\User|false 61 69 */ 62 70 protected $webUser; 63 71 64 72 /** 65 73 * An administrative user who can bypass comment approval. 74 * 75 * @var \Drupal\user\Entity\User|false 66 76 */ 67 77 protected $postCommentUser; 68 78 69 79 /** 70 80 * An array representing a forum container. 81 * 82 * @var object[] I think string[]. It is populated by createForum() which does not return an object. The doc block for that method is incorrect.
Of course, it is friday afternoonn - I could be wrong.
66 76 */ 67 77 protected $postCommentUser; 68 78 69 79 /** 70 80 * An array representing a forum container. 81 * 82 * @var object[] 71 83 */ 72 84 protected $forumContainer; 73 85 74 86 /** 75 87 * An array representing a forum. 88 * 89 * @var object[] 76 90 */ 77 91 protected $forum; 88 * 89 * @var object[] 76 90 */ 77 91 protected $forum; 78 92 79 93 /** 80 94 * An array representing a root forum. 95 * 96 * @var array 81 97 */ 82 98 protected $rootForum; 83 99 84 100 /** 85 101 * An array of forum topic node IDs. 102 * 103 * @var array 68 68 <rule ref="Drupal.Commenting.FunctionComment"> 69 69 <exclude name="Drupal.Commenting.FunctionComment.InvalidNoReturn"/> 70 70 <exclude name="Drupal.Commenting.FunctionComment.Missing"/> 71 <exclude name="Drupal.Commenting.FunctionComment.MissingParamComment"/> changed this line in version 19 of the diff
78 79 <rule ref="Drupal.Commenting.GenderNeutralComment"/> 79 80 <rule ref="Drupal.Commenting.InlineVariableComment"/> 80 81 <rule ref="Drupal.Commenting.VariableComment"> 81 <!-- Sniff for: DuplicateVar, EmptyVar, IncorrectVarType, InlineVariableName, WrongStyle --> 82 <!-- Sniff for: DuplicateVar, EmptyVar, IncorrectVarType, InlineVariableName, 83 MissingVar, WrongStyle --> changed this line in version 19 of the diff
added 848 commits
-
5b99a4d8...1b1d4314 - 841 commits from branch
project:9.4.x
- 555c16dc - Removed sniff Drupal.Commenting.VariableComment.MissingVar from exclusion
- b51b1632 - Round 1
- 39572803 - Round 2
- 16e8fbfe - Be more specific
- 0ea79dea - Added new offender
- 7e9a8190 - Resolving threads opened by quietone
- 38861df3 - Resolving thread
Toggle commit list-
5b99a4d8...1b1d4314 - 841 commits from branch