Skip to content
Snippets Groups Projects

Issue #2924782: Missing @var annotation for arrays that provide default values

Issue #2924782: Missing @var annotation for arrays that provide default values

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • quietone
  • spokje added 294 commits

    added 294 commits

    Compare with previous version

  • spokje added 1 commit

    added 1 commit

    Compare with previous version

  • spokje added 1 commit

    added 1 commit

    • 6aba761d - Resolving threads opened by quietone

    Compare with previous version

  • spokje changed target branch from 9.3.x to 9.4.x

    changed target branch from 9.3.x to 9.4.x

  • spokje added 452 commits

    added 452 commits

    Compare with previous version

  • spokje added 2 commits

    added 2 commits

    • 567f483a - 1 commit from branch project:9.4.x
    • c0070839 - Merge branch '9.4.x' into 2924782-missing-var-annotation

    Compare with previous version

  • spokje added 12 commits

    added 12 commits

    Compare with previous version

  • quietone
  • quietone
  • 65 65 * transliterates to more than one ASCII character require special
    66 66 * treatment: we want to remove their accent and use the un-
    67 67 * transliterated base character.
    68 *
    69 * @var string[]
    • The array it two dimensional, shouldn't this be string[][]? Or do I have that wrong?

    • AFAIK: string[][] is an array like this:

      ['string1' => ['string2' => 'string3']]

      Grepping Core for string[][] seem to back this idea up, however I'm not a 100% sure.

    • Please register or sign in to reply
  • quietone
  • 38 38
    39 39 /**
    40 40 * Array of access checks which only will be run on the incoming request.
    41 *
    42 * @var string[]
  • spokje added 9 commits

    added 9 commits

    Compare with previous version

  • spokje added 1 commit

    added 1 commit

    Compare with previous version

  • quietone
  • 18 18
    19 19 /**
    20 20 * An array holding flood events, keyed by event name and identifier.
    21 *
    22 * @var object[]
  • quietone
  • 33 33 */
    34 34 protected $defaultTheme = 'classy';
    35 35
    36 /**
    37 * @var array
    38 */
    36 39 protected $regions;
  • quietone
  • 28 28
    29 29 /**
    30 30 * Set default values for the filters.
    31 *
    32 * @var string[]
    31 33 */
    32 34 protected $filters = [
  • quietone
  • 67 *
    68 * @var \Drupal\user\Entity\User|false
    61 69 */
    62 70 protected $webUser;
    63 71
    64 72 /**
    65 73 * An administrative user who can bypass comment approval.
    74 *
    75 * @var \Drupal\user\Entity\User|false
    66 76 */
    67 77 protected $postCommentUser;
    68 78
    69 79 /**
    70 80 * An array representing a forum container.
    81 *
    82 * @var object[]
  • quietone
  • 66 76 */
    67 77 protected $postCommentUser;
    68 78
    69 79 /**
    70 80 * An array representing a forum container.
    81 *
    82 * @var object[]
    71 83 */
    72 84 protected $forumContainer;
    73 85
    74 86 /**
    75 87 * An array representing a forum.
    88 *
    89 * @var object[]
    76 90 */
    77 91 protected $forum;
  • quietone
  • 71 83 */
    72 84 protected $forumContainer;
    73 85
    74 86 /**
    75 87 * An array representing a forum.
    88 *
    89 * @var object[]
    76 90 */
    77 91 protected $forum;
    78 92
    79 93 /**
    80 94 * An array representing a root forum.
    95 *
    96 * @var array
    81 97 */
    82 98 protected $rootForum;
  • quietone
  • 88 *
    89 * @var object[]
    76 90 */
    77 91 protected $forum;
    78 92
    79 93 /**
    80 94 * An array representing a root forum.
    95 *
    96 * @var array
    81 97 */
    82 98 protected $rootForum;
    83 99
    84 100 /**
    85 101 * An array of forum topic node IDs.
    102 *
    103 * @var array
  • quietone
  • 26 26
    27 27 /**
    28 28 * A user able to create languages and export translations.
    29 *
    30 * @var \Drupal\user\Entity\User|false
    29 31 */
    30 32 protected $adminUser = NULL;
  • quietone
  • 28 28
    29 29 /**
    30 30 * Set default values for the filters.
    31 *
    32 * @var string[]
    31 33 */
    32 34 protected $filters = [
  • quietone
  • 48 48 /**
    49 49 * Contains the actual value of the field,either configured in the views ui
    50 50 * or entered in the exposed filters.
    51 *
    52 * @var string
  • 68 68 <rule ref="Drupal.Commenting.FunctionComment">
    69 69 <exclude name="Drupal.Commenting.FunctionComment.InvalidNoReturn"/>
    70 70 <exclude name="Drupal.Commenting.FunctionComment.Missing"/>
    71 <exclude name="Drupal.Commenting.FunctionComment.MissingParamComment"/>
  • 78 79 <rule ref="Drupal.Commenting.GenderNeutralComment"/>
    79 80 <rule ref="Drupal.Commenting.InlineVariableComment"/>
    80 81 <rule ref="Drupal.Commenting.VariableComment">
    81 <!-- Sniff for: DuplicateVar, EmptyVar, IncorrectVarType, InlineVariableName, WrongStyle -->
    82 <!-- Sniff for: DuplicateVar, EmptyVar, IncorrectVarType, InlineVariableName,
    83 MissingVar, WrongStyle -->
  • quietone added 848 commits

    added 848 commits

    Compare with previous version

  • quietone changed target branch from 9.4.x to 10.1.x

    changed target branch from 9.4.x to 10.1.x

  • quietone changed target branch from 10.1.x to 9.4.x

    changed target branch from 10.1.x to 9.4.x

  • closed

  • Please register or sign in to reply
    Loading