Skip to content
Snippets Groups Projects

Issue #3382423: oEmbed field formatter creates wrong hash when leaving empty dimensions

Issue #3382423: oEmbed field formatter creates wrong hash when leaving empty dimensions

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
267 ResourceController::setResourceUrl('https://vimeo.com/7073899', $this->getFixturesDirectory() . '/video_vimeo.json');
268 UrlResolver::setEndpointUrl('https://vimeo.com/7073899', 'video_vimeo.json');
269
270 $entity = Media::create([
271 'bundle' => $media_type->id(),
272 $source_field->getName() => 'https://vimeo.com/7073899',
273 ]);
274 $entity->save();
275
276 $this->drupalGet($entity->toUrl());
277 $assert = $this->assertSession();
278 $assert->statusCodeEquals(200);
279 // Check that the width and height attributes are not empty.
280 $element = $assert->elementExists('css', 'iframe');
281 $this->assertNotEmpty($element->getAttribute('width'));
282 $this->assertNotEmpty($element->getAttribute('height'));
  • Chris Wu added 29 commits

    added 29 commits

    Compare with previous version

  • Chris Wu added 1 commit

    added 1 commit

    • 7b1e580d - Assert the width/height attributes are 0

    Compare with previous version

  • Chris Wu added 1 commit

    added 1 commit

    Compare with previous version

  • added 1 commit

    • bd450cbb - Extend existing test to cover formatter's dimensions settings, in place of new standalone test.

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Please register or sign in to reply
    Loading