Issue #3227518: Never show a "Not supported!" version as "Recommended"
3 open threads
Merge request reports
Activity
added 1 commit
- 32a938c1 - Fix PHPStan error, change drupalci to run update module
410 410 * the installed version is in a supported branch or not. This test relies on 411 411 * 2 test XML fixtures that are identical except for the 'supported_branches' 412 412 * value: 413 413 * - [::$updateProject].1.0.xml changed this line in version 5 of the diff
- Resolved by quietone
272 281 * @param string $label 273 282 * The label for the update, for example "Recommended version:" or 274 283 * "Latest version:". 284 * @param int $index 285 * (optional) The index of the element. 275 286 * 276 287 * @return \Behat\Mink\Element\NodeElement 277 288 * The update element. 278 289 */ 279 protected function findUpdateElementByLabel($label) { 290 protected function findUpdateElementByLabel($label, int $index = 0) { 280 291 $update_elements = $this->getSession()->getPage() 281 292 ->findAll('css', $this->updateTableLocator . " .project-update__version:contains(\"$label\")"); 282 $this->assertCount(1, $update_elements); 283 return $update_elements[0]; 293 $this->assertGreaterThanOrEqual($index, count($update_elements)); - Resolved by quietone
added 73 commits
-
5d0ae020...12dabf05 - 65 commits from branch
project:11.x
- 6fe474d7 - changed logic and test
- 305756ae - resolved failing test
- 20602291 - added new assertion assertNotEmpty($newer_version)
- c84e33eb - changed comment in fixtures and improvements in UpdateTestBase
- 57fdb3a3 - Removed <tag> from fixtures files and removed out of scope changes from MR.
- 5a304f4c - reverted out of scope change
- fa2168c6 - Fix PHPStan error, change drupalci to run update module
- 587aa9f9 - Text changes and swap an 'if' around
Toggle commit list-
5d0ae020...12dabf05 - 65 commits from branch
added 1299 commits
-
587aa9f9...820d76b2 - 1292 commits from branch
project:11.x
- a919196c - changed logic and test
- 52634db6 - added new assertion assertNotEmpty($newer_version)
- ba168d9c - changed comment in fixtures and improvements in UpdateTestBase
- bd9cf2a9 - Removed <tag> from fixtures files and removed out of scope changes from MR.
- 4c355a32 - reverted out of scope change
- b7d17fe6 - Fix PHPStan error, change drupalci to run update module
- 6fa7ffdc - Text changes and swap an 'if' around
Toggle commit list-
587aa9f9...820d76b2 - 1292 commits from branch
added 1 commit
- 2561626d - Fix method invoked with wrong number of parameters
assigned to @quietone
unassigned @quietone
504 495 505 496 // If we were unable to find a recommended version, then make the latest 506 497 // version the recommended version if possible. 507 if (!isset($project_data['recommended']) && isset($project_data['latest_version'])) { 498 if (!isset($project_data['recommended']) && isset($project_data['latest_version']) && $release_is_supported) { 508 499 $project_data['recommended'] = $project_data['latest_version']; 509 500 } 510 501 502 // The release is not supported. Check for a recommended versions. 503 if (!$release_is_supported) { changed this line in version 11 of the diff
added 1 commit
- b76cad99 - Revert "Move block to after recommended is set"
added 150 commits
-
b76cad99...68628cce - 137 commits from branch
project:11.x
- 68628cce...d030d425 - 3 earlier commits
- 66dd539a - Removed <tag> from fixtures files and removed out of scope changes from MR.
- a5591e59 - reverted out of scope change
- 1cb1d2bf - Fix PHPStan error, change drupalci to run update module
- b2b2ab23 - Text changes and swap an 'if' around
- 1fa1307e - restore core/drupalci.yml
- bb29f108 - Fix method invoked with wrong number of parameters
- e537abda - s/Disabling/Uninstalling/
- 0a23b0e6 - Add comments and some cleanup
- 88e7cb2a - Move block to after recommended is set
- 198237e6 - Revert "Move block to after recommended is set"
Toggle commit list-
b76cad99...68628cce - 137 commits from branch
Please register or sign in to reply