Skip to content
Snippets Groups Projects

Issue #3376293: WorkspacePublishForm $redirectDestination parameter appears not to be used

Open Issue #3376293: WorkspacePublishForm $redirectDestination parameter appears not to be used
1 unresolved thread
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Couple of minor optimisations, fine to self RTBC those changes

  • Lee Rowlands resolved all threads

    resolved all threads

  • Nathan Lisgo added 1 commit

    added 1 commit

    • 220c3b11 - use $this->getDestinationArray() instead of trying to inject the redirect destination service

    Compare with previous version

  • Nathan Lisgo added 42 commits

    added 42 commits

    • 220c3b11...cdd3e5ef - 37 commits from branch project:11.x
    • 6aadaca7 - If redirectDestination argument is supplied then use it!
    • d6365b90 - If redirectDestination argument is supplied then use it!
    • 03f9d789 - cs
    • 570a247d - Add test for publish form
    • 48fc3d1c - use $this->getDestinationArray() instead of trying to inject the redirect destination service

    Compare with previous version

  • Nathan Lisgo added 8 commits

    added 8 commits

    • 48fc3d1c...87afd2c3 - 3 commits from branch project:11.x
    • 51e2d375 - If redirectDestination argument is supplied then use it!
    • 82f42d1d - If redirectDestination argument is supplied then use it!
    • 1073777d - cs
    • d5e69148 - Add test for publish form
    • 2e0806b5 - use $this->getDestinationArray() instead of trying to inject the redirect destination service

    Compare with previous version

  • Nathan Lisgo added 7 commits

    added 7 commits

    • 2e0806b5...e646c8e5 - 2 commits from branch project:11.x
    • b007d1d2 - If redirectDestination argument is supplied then use it!
    • e67ca6d3 - If redirectDestination argument is supplied then use it!
    • 55914cd0 - cs
    • 806a6d40 - Add test for publish form
    • c0598437 - use $this->getDestinationArray() instead of trying to inject the redirect destination service

    Compare with previous version

  • 52 51 * The workspace operation factory service.
    53 52 * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
    54 53 * The entity type manager.
    55 * @param \Drupal\Core\Routing\RedirectDestinationInterface|null $redirectDestination
    56 * The redirect destination service.
    57 54 */
    58 public function __construct(WorkspaceOperationFactory $workspace_operation_factory, EntityTypeManagerInterface $entity_type_manager, ?RedirectDestinationInterface $redirectDestination = NULL) {
    55 public function __construct(WorkspaceOperationFactory $workspace_operation_factory, EntityTypeManagerInterface $entity_type_manager) {
    59 56 $this->workspaceOperationFactory = $workspace_operation_factory;
    60 57 $this->entityTypeManager = $entity_type_manager;
    61 if ($redirectDestination === NULL) {
  • Have asked for some clarification about how we handle rescinding the old CR

  • Lee Rowlands added 19 commits

    added 19 commits

    • c0598437...92abbb59 - 14 commits from branch project:11.x
    • df79836d - If redirectDestination argument is supplied then use it!
    • c35f6ebf - If redirectDestination argument is supplied then use it!
    • be2ca27e - cs
    • 4c408a9e - Add test for publish form
    • a6a03545 - use $this->getDestinationArray() instead of trying to inject the redirect destination service

    Compare with previous version

  • Please register or sign in to reply
    Loading