Skip to content
Snippets Groups Projects

Issue #2924782: Fix remaining VariableComment.MissingVar annotation

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • quietone added 109 commits

    added 109 commits

    • 50855573...4e9a6028 - 96 commits from branch project:11.x
    • 4e9a6028...031c8022 - 3 earlier commits
    • f5ce11bb - Added new offender
    • 1cff1266 - Resolving threads opened by quietone
    • ab7656be - Fix order in phpcs.xml.dist
    • c05e5704 - Remaining fixes to enable sniff
    • e1083639 - more test files
    • 89499c51 - InstallerConfigDirectoryTestBase.php
    • ac2ebc16 - remove those with default value
    • 95c21aac - restore phpcs.xml.dist
    • 3394d918 - properly restore phpcs.xml
    • cc184ea9 - fix mistakes

    Compare with previous version

  • quietone added 70 commits

    added 70 commits

    Compare with previous version

  • quietone added 1 commit

    added 1 commit

    • 1f3b56b5 - enable sniff for some patterns

    Compare with previous version

  • quietone added 16 commits

    added 16 commits

    Compare with previous version

  • quietone added 73 commits

    added 73 commits

    Compare with previous version

  • 24 24 * This is set by the profile in the core.extension extracted.
    25 25 *
    26 26 * If set to FALSE, then the install will proceed without an install profile.
    27 *
    28 * @var string|null
    27 29 */
    28 30 protected $profile = NULL;
    29 31
    30 32 /**
    31 * @todo Fill out docblock.
    33 * @var bool
    • Comment on lines -31 to +33
      Suggested change
      29 * @var bool
      29 * @todo Fill out docblock.
      30 *
      31 * @var bool

      The todo is still to be done. Let's leave that alone - it is out-of-scope.

    • Author Maintainer

      Now this one does match the MR.

    • Author Maintainer

      Actually, leaving it in causes an error because the @var must be the first annotation in the comment block. And there is no need for a followup because the problem will be detected by Drupal.Commenting.VariableComment.Missing"

    • Please register or sign in to reply
  • Author Maintainer

    This is a bit of mess.

  • quietone added 59 commits

    added 59 commits

    Compare with previous version

  • Lee Rowlands
  • 24 24 * This is set by the profile in the core.extension extracted.
    25 25 *
    26 26 * If set to FALSE, then the install will proceed without an install profile.
    27 *
    28 * @var string|null
    27 29 */
    28 30 protected $profile = NULL;
  • 20 20 * The first iteration does not change the directory mtime so this class will
    21 21 * include the hacked file on the first try but the second test will change
    22 22 * the directory mtime and so on the second try the file will not be included.
    23 *
    24 * @var bool[]
    23 25 */
    24 26 protected array $expected = [TRUE, FALSE];
    25 27
    26 28 /**
    27 29 * The PHP storage class to test.
    30 *
    31 * @var string
  • 19 19 *
    20 20 * The default implementation protects against even the filemtime change so
    21 21 * both iterations will return FALSE.
    22 *
    23 * @var bool[]
    22 24 */
    23 25 protected array $expected = [FALSE, FALSE];
    24 26
    25 27 /**
    26 28 * The PHP storage class to test.
    29 *
    30 * @var string
  • couple of minor issues

  • added 1 commit

    Compare with previous version

  • Kul Pratap Singh added 136 commits

    added 136 commits

    • bcc4b2ae...10154d1a - 135 commits from branch project:11.x
    • b70eaeb0 - Merge branch '11.x' into '2924782-missing-var-annotation-10.1.x'

    Compare with previous version

  • quietone
  • quietone
  • quietone
  • 95 95 <rule ref="Drupal.Commenting.PostStatementComment"/>
    96 96 <rule ref="Drupal.Commenting.TodoComment" />
    97 97 <rule ref="Drupal.Commenting.VariableComment">
    98 <!-- Sniff for: DuplicateVar, EmptyVar, IncorrectVarType, InlineVariableName, WrongStyle -->
    99 <exclude name="Drupal.Commenting.VariableComment.MissingVar"/>
    98 <!-- Sniff for: DuplicateVar, EmptyVar, IncorrectVarType, InlineVariableName, MissingVar, WrongStyle -->
    99 <exclude name="Drupal.Commenting.VariableComment.Missing"/>
    100 100 </rule>
    101 101 <rule ref="Drupal.Commenting.VariableComment.Missing">
    102 102 <exclude-pattern>./core/tests/*</exclude-pattern>
    103 103 <exclude-pattern>./core/*/tests/*</exclude-pattern>
    104 104 </rule>
    105 105 <rule ref="Drupal.ControlStructures.ControlSignature"/>
    • Author Maintainer
      Suggested change
      119 <rule ref="Drupal.ControlStructures.ControlSignature"/>
      119 <rule ref="Drupal.Commenting.VariableComment.MissingVar">
      120 <exclude-pattern>./*/Plugin/*</exclude-pattern>
      121 </rule>
      122 <rule ref="Drupal.ControlStructures.ControlSignature"/>

      Recent commits are failing for this sniff, so limit the scope of the sniff.

    • Please register or sign in to reply
  • added 1 commit

    Compare with previous version

  • quietone added 98 commits

    added 98 commits

    Compare with previous version

  • quietone added 64 commits

    added 64 commits

    Compare with previous version

  • quietone added 1 commit

    added 1 commit

    Compare with previous version

  • Please register or sign in to reply
    Loading