Issue #2924782: Fix remaining VariableComment.MissingVar annotation
5 open threads
Merge request reports
Activity
added 33 commits
-
1d57fe06...20369405 - 26 commits from branch
project:10.1.x
- cfcf35a1 - Removed sniff Drupal.Commenting.VariableComment.MissingVar from exclusion
- a68addff - Round 1
- 925376d5 - Round 2
- 0483539e - Be more specific
- 30dd0b7d - Added new offender
- 6b5ea689 - Resolving threads opened by quietone
- edb5df91 - Resolving thread
Toggle commit list-
1d57fe06...20369405 - 26 commits from branch
added 2794 commits
-
e862bc7e...b6aef35b - 277 commits from branch
project:10.1.x
- b6aef35b...a605aef9 - 2507 earlier commits
- 9e755dd7 - Round 2
- dea55dff - Be more specific
- a50fabdc - Added new offender
- 30e2c4a2 - Resolving threads opened by quietone
- c9b3882f - Resolving thread
- 7cb80731 - Fix order in phpcs.xml.dist
- fb3f30c0 - Suggestions from review last year
- edc28de4 - Enable sniff
- 7830ad4c - Remaining fixes to enable sniff
- 48f8100d - more test files
Toggle commit list-
e862bc7e...b6aef35b - 277 commits from branch
added 19 commits
-
48f8100d...ae308e40 - 6 commits from branch
project:11.x
- ae308e40...473a3122 - 3 earlier commits
- 29f5c41a - Be more specific
- eb4c68f0 - Added new offender
- 1b48953d - Resolving threads opened by quietone
- 0133f15a - Resolving thread
- 33e4e903 - Fix order in phpcs.xml.dist
- f0991f37 - Suggestions from review last year
- 5980ea79 - Enable sniff
- 18752b5b - Remaining fixes to enable sniff
- a3a40ace - more test files
- 7258fc8f - InstallerConfigDirectoryTestBase.php
Toggle commit list-
48f8100d...ae308e40 - 6 commits from branch
added 2 commits
added 87 commits
-
a0d9794e...ee585649 - 73 commits from branch
project:11.x
- ee585649...3c7e439a - 4 earlier commits
- f23be4c6 - Added new offender
- 7aa077bb - Resolving threads opened by quietone
- 859978b4 - Resolving thread
- 0d6694d1 - Fix order in phpcs.xml.dist
- ee6ab9dc - Suggestions from review last year
- 6621b224 - Remaining fixes to enable sniff
- c89e5871 - more test files
- 95ba2263 - InstallerConfigDirectoryTestBase.php
- 6258757f - remove those with default value
- 3a250ca3 - restore phpcs.xml.dist
Toggle commit list-
a0d9794e...ee585649 - 73 commits from branch
added 42 commits
-
3a250ca3...143acfe4 - 28 commits from branch
project:11.x
- 143acfe4...10b70fac - 4 earlier commits
- eb21c7bb - Added new offender
- be29ec0a - Resolving threads opened by quietone
- 187fa1a8 - Resolving thread
- 8d9e2b5e - Fix order in phpcs.xml.dist
- b4c7e140 - Suggestions from review last year
- adc5da13 - Remaining fixes to enable sniff
- c7e65c5e - more test files
- 5360f2d0 - InstallerConfigDirectoryTestBase.php
- e299b7e1 - remove those with default value
- f0499791 - restore phpcs.xml.dist
Toggle commit list-
3a250ca3...143acfe4 - 28 commits from branch
added 21 commits
-
f0499791...3b29a90b - 20 commits from branch
project:11.x
- 50855573 - Merge branch '11.x' into '2924782-missing-var-annotation-10.1.x'
-
f0499791...3b29a90b - 20 commits from branch
- Resolved by Alex Pott
added 109 commits
-
50855573...4e9a6028 - 96 commits from branch
project:11.x
- 4e9a6028...031c8022 - 3 earlier commits
- f5ce11bb - Added new offender
- 1cff1266 - Resolving threads opened by quietone
- ab7656be - Fix order in phpcs.xml.dist
- c05e5704 - Remaining fixes to enable sniff
- e1083639 - more test files
- 89499c51 - InstallerConfigDirectoryTestBase.php
- ac2ebc16 - remove those with default value
- 95c21aac - restore phpcs.xml.dist
- 3394d918 - properly restore phpcs.xml
- cc184ea9 - fix mistakes
Toggle commit list-
50855573...4e9a6028 - 96 commits from branch
- Resolved by Stephen Mustgrave
- Resolved by Stephen Mustgrave
- Resolved by Stephen Mustgrave
added 70 commits
-
cc184ea9...ec1b6713 - 56 commits from branch
project:11.x
- ec1b6713...0191a10c - 4 earlier commits
- 2fb796ac - Resolving threads opened by quietone
- 291e1ef2 - Fix order in phpcs.xml.dist
- 5319c6a6 - Remaining fixes to enable sniff
- ab1410a8 - more test files
- 3ae9c750 - InstallerConfigDirectoryTestBase.php
- 1f825834 - remove those with default value
- df111f51 - restore phpcs.xml.dist
- 325bc05a - properly restore phpcs.xml
- 38aefc59 - fix mistakes
- 1c56333b - more fixes
Toggle commit list-
cc184ea9...ec1b6713 - 56 commits from branch
added 16 commits
-
2ae1c018 - 1 commit from branch
project:11.x
- 2ae1c018...d27ae0e9 - 5 earlier commits
- fe64132b - Fix order in phpcs.xml.dist
- 2e659b02 - Remaining fixes to enable sniff
- a8428c1b - more test files
- 2ac37113 - InstallerConfigDirectoryTestBase.php
- 6d3d890b - remove those with default value
- 5f80c46c - restore phpcs.xml.dist
- 11c54fda - properly restore phpcs.xml
- a4edc982 - fix mistakes
- 4caa7a6c - more fixes
- 430736f9 - enable sniff for some patterns
Toggle commit list-
2ae1c018 - 1 commit from branch
added 73 commits
-
430736f9...b5c5a2a3 - 59 commits from branch
project:11.x
- b5c5a2a3...eccf7679 - 4 earlier commits
- bbdc2d7d - Fix order in phpcs.xml.dist
- 9358e98f - Remaining fixes to enable sniff
- 221638f9 - more test files
- 434e3b42 - InstallerConfigDirectoryTestBase.php
- 749f947d - remove those with default value
- b34c5b8c - restore phpcs.xml.dist
- ded8a6f9 - properly restore phpcs.xml
- 35a1c684 - fix mistakes
- 6d9628ee - more fixes
- 384caf1a - enable sniff for some patterns
Toggle commit list-
430736f9...b5c5a2a3 - 59 commits from branch
24 24 * This is set by the profile in the core.extension extracted. 25 25 * 26 26 * If set to FALSE, then the install will proceed without an install profile. 27 * 28 * @var string|null 27 29 */ 28 30 protected $profile = NULL; 29 31 30 32 /** 31 * @todo Fill out docblock. 33 * @var bool - Comment on lines -31 to +33
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
added 59 commits
-
384caf1a...38a6bcd7 - 44 commits from branch
project:11.x
- 38a6bcd7...01a0a311 - 5 earlier commits
- 10bd388c - Remaining fixes to enable sniff
- 03504e63 - more test files
- 6b93c8e7 - InstallerConfigDirectoryTestBase.php
- 2f4e24fe - remove those with default value
- 222e7dfe - restore phpcs.xml.dist
- 00009b6d - properly restore phpcs.xml
- 1acdbf5d - fix mistakes
- 936df57a - more fixes
- f813b353 - enable sniff for some patterns
- 9fd12af7 - start over
Toggle commit list-
384caf1a...38a6bcd7 - 44 commits from branch
- Resolved by Stephen Mustgrave
- Resolved by Stephen Mustgrave
24 24 * This is set by the profile in the core.extension extracted. 25 25 * 26 26 * If set to FALSE, then the install will proceed without an install profile. 27 * 28 * @var string|null 27 29 */ 28 30 protected $profile = NULL; 20 20 * The first iteration does not change the directory mtime so this class will 21 21 * include the hacked file on the first try but the second test will change 22 22 * the directory mtime and so on the second try the file will not be included. 23 * 24 * @var bool[] 23 25 */ 24 26 protected array $expected = [TRUE, FALSE]; 25 27 26 28 /** 27 29 * The PHP storage class to test. 30 * 31 * @var string changed this line in version 19 of the diff
19 19 * 20 20 * The default implementation protects against even the filemtime change so 21 21 * both iterations will return FALSE. 22 * 23 * @var bool[] 22 24 */ 23 25 protected array $expected = [FALSE, FALSE]; 24 26 25 27 /** 26 28 * The PHP storage class to test. 29 * 30 * @var string changed this line in version 19 of the diff
added 136 commits
-
bcc4b2ae...10154d1a - 135 commits from branch
project:11.x
- b70eaeb0 - Merge branch '11.x' into '2924782-missing-var-annotation-10.1.x'
-
bcc4b2ae...10154d1a - 135 commits from branch
- Resolved by quietone
- Resolved by quietone
95 95 <rule ref="Drupal.Commenting.PostStatementComment"/> 96 96 <rule ref="Drupal.Commenting.TodoComment" /> 97 97 <rule ref="Drupal.Commenting.VariableComment"> 98 <!-- Sniff for: DuplicateVar, EmptyVar, IncorrectVarType, InlineVariableName, WrongStyle --> 99 <exclude name="Drupal.Commenting.VariableComment.MissingVar"/> 98 <!-- Sniff for: DuplicateVar, EmptyVar, IncorrectVarType, InlineVariableName, MissingVar, WrongStyle --> 99 <exclude name="Drupal.Commenting.VariableComment.Missing"/> 100 100 </rule> 101 101 <rule ref="Drupal.Commenting.VariableComment.Missing"> 102 102 <exclude-pattern>./core/tests/*</exclude-pattern> 103 103 <exclude-pattern>./core/*/tests/*</exclude-pattern> 104 104 </rule> 105 105 <rule ref="Drupal.ControlStructures.ControlSignature"/> Recent commits are failing for this sniff, so limit the scope of the sniff.
added 98 commits
-
c48931e9...ee894196 - 80 commits from branch
project:11.x
- ee894196...27f8269b - 8 earlier commits
- fc67660e - remove those with default value
- abe50795 - restore phpcs.xml.dist
- e17cdb3b - properly restore phpcs.xml
- cb46e036 - fix mistakes
- 0e630d22 - more fixes
- 7f82e9d2 - enable sniff for some patterns
- c14be386 - start over
- 8267269d - Issue #2924782: Fix minor issues
- b600d79d - Issue #2924782:Revert changes
- 5530e32d - exclude Plugin files
Toggle commit list-
c48931e9...ee894196 - 80 commits from branch
added 64 commits
-
5530e32d...0be56730 - 46 commits from branch
project:11.x
- 0be56730...899c5c05 - 8 earlier commits
- 5b940e06 - remove those with default value
- 8ee8ab13 - restore phpcs.xml.dist
- 305ea9ab - properly restore phpcs.xml
- 86bf1916 - fix mistakes
- 57ffcf42 - more fixes
- 5c7886b0 - enable sniff for some patterns
- 1e297eaa - start over
- 4dba73a4 - Issue #2924782: Fix minor issues
- 8fea0b28 - Issue #2924782:Revert changes
- 08dd00ad - exclude Plugin files
Toggle commit list-
5530e32d...0be56730 - 46 commits from branch
Please register or sign in to reply