Skip to content
Snippets Groups Projects

Refactored table file multiple widget pcss file

Open
Gauravrequested to merge
issue/drupal-3332473:3332473-refactor-claros-table--file-multiple-widget into 10.1.x
7 open threads

Closes #3332473

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/themes/claro/css/components/table--file-multiple-widget.pcss.css
48 padding-block: var(--space-xs);
49 }
50 & .checkbox .form-type--boolean {
51 line-height: calc(var(--space-m) * 3);
52 }
69 53 }
70 54
71 .table-file-multiple-widget .checkbox .form-type--boolean {
72 line-height: calc(var(--space-m) * 3);
55 [dir="rtl"] {
56 & .table-file-multiple-widget {
57 & .tabledrag-handle {
58 float: right;
59 }
60 & .tabledrag-changed {
61 float: left;
  • Gaurav added 1 commit

    added 1 commit

    Compare with previous version

  • Lauri Timmanee
    Lauri Timmanee @lauriii started a thread on the diff
    • core/themes/claro/css/components/table--file-multiple-widget.pcss.css
    96 90 * Take as much space as possible.
    97 91 */
    98 92 @media screen and (max-width: 37.5em) {
    99 .claro-details__wrapper .file-widget-multiple__table-wrapper {
    100 margin-right: calc(var(--space-m) * -1);
    101 margin-left: calc(var(--space-m) * -1);
    102 }
    103
    104 .claro-details__wrapper .file-widget-multiple__table-wrapper > :not(table) {
    105 margin-right: var(--space-m);
    106 margin-left: var(--space-m);
    93 .claro-details__wrapper {
    94 & .file-widget-multiple__table-wrapper {
    95 margin-inline: calc(var(--space-m) * -1);
    96 }
    97 & > :not(table) {
  • Lauri Timmanee
    Lauri Timmanee @lauriii started a thread on an old version of the diff
    • core/themes/claro/css/components/table--file-multiple-widget.pcss.css
    88 78 * Remove the border for the last table row if upload is not possible.
    89 79 * (A full file widget with limited cardinality.)
    90 80 */
    91 .table-file-multiple-widget--no-upload > tbody:last-child > tr:last-child {
    92 border-bottom: 0;
    81 .table-file-multiple-widget--no-upload {
  • Lauri Timmanee
    Lauri Timmanee @lauriii started a thread on an old version of the diff
    • core/themes/claro/css/components/table--file-multiple-widget.pcss.css
    46 height: calc(var(--space-m) * 2);
    47 color: var(--color-gray-800);
    48 background: var(--color-gray-050);
    49 font-size: var(--font-size-s);
    50 }
    51 & .tabledrag-cell {
    52 padding-block: var(--space-xs);
    53 }
    54 & .checkbox .form-type--boolean {
    55 line-height: calc(var(--space-m) * 3);
    56 }
    73 57 }
    74 58
    75 .no-touchevents .table-file-multiple-widget .checkbox .form-type--boolean {
    76 line-height: var(--line-height);
    59 .no-touchevents {
  • Lauri Timmanee
    Lauri Timmanee @lauriii started a thread on an old version of the diff
    • core/themes/claro/css/components/table--file-multiple-widget.pcss.css
    64 }
    65
    66 .table-file-multiple-widget .tabledrag-cell {
    67 padding-top: var(--space-xs);
    68 padding-bottom: var(--space-xs);
    69 }
    6 .table-file-multiple-widget {
    7 & tbody {
    8 vertical-align: top;
    9 }
    10 & .tabledrag-cell-content {
    11 position: relative;
    12 display: block;
    13 height: auto;
    14 }
    15 & .tabledrag-cell-content > * {
  • Lauri Timmanee
  • Gaurav added 1 commit

    added 1 commit

    • 559db194 - Table file selectors updated and addressed feedbacks

    Compare with previous version

  • Gaurav added 1 commit

    added 1 commit

    • d7eb913b - Float logical property updated

    Compare with previous version

  • Gaurav added 704 commits

    added 704 commits

    • d7eb913b...6bccf5b0 - 700 commits from branch project:10.1.x
    • eca29d43 - Refactored table file multiple widget pcss file
    • 50209058 - Used logical properties
    • e7588dad - Table file selectors updated and addressed feedbacks
    • 622f33e1 - Float logical property updated

    Compare with previous version

    Toggle commit list
  • Rupesh Gharat added 1 commit

    added 1 commit

    • 220fb7d9 - Refactor css for table file multiple widget.

    Compare with previous version

  • Théodore Biadala
    Théodore Biadala @nod_ started a thread on the diff
    • core/themes/claro/css/components/table--file-multiple-widget.css
    28 28 padding: 0;
    29 29 }
    30 30
    31 .table-file-multiple-widget .tabledrag-handle {
    32 float: left; /* LTR */
    33 }
    34
    35 [dir="rtl"] .table-file-multiple-widget .tabledrag-handle {
    36 float: right;
    31 .table-file-multiple-widget .tabledrag-handle,
    32 .table-file-multiple-widget .tabledrag-changed {
    33 float: left;
    • Théodore Biadala
      Théodore Biadala @nod_
      Maintainer

      missing the RTL style, post css doesn't appear to support inline-start as a float value. we need explicit RTL styles here or find a way for postcss to not replace the value.

    • Please register or sign in to reply
  • Mithun S added 1 commit

    added 1 commit

    • 9a78718b - 3332473: Add the [dir=rtl] css for float properties.

    Compare with previous version

  • Théodore Biadala changed target branch from 10.1.x to 11.x

    changed target branch from 10.1.x to 11.x

  • Théodore Biadala changed target branch from 11.x to 10.4.x

    changed target branch from 11.x to 10.4.x

  • Théodore Biadala changed target branch from 10.4.x to 10.1.x

    changed target branch from 10.4.x to 10.1.x

  • Théodore Biadala
    Théodore Biadala @nod_ started a thread on an old version of the diff
    • core/themes/claro/css/components/table--file-multiple-widget.pcss.css
    46 font-size: var(--font-size-s);
    47 }
    48 & .tabledrag-cell {
    49 padding-block: var(--space-xs);
    50 }
    51 & .checkbox .form-type--boolean {
    52 line-height: calc(var(--space-m) * 3);
    53 }
    69 54 }
    70 55
    71 .table-file-multiple-widget .checkbox .form-type--boolean {
    72 line-height: calc(var(--space-m) * 3);
    56 [dir="rtl"] .table-file-multiple-widget {
    57 & .tabledrag-handle,
    58 & .tabledrag-changed {
    59 float: inline-end;
  • Mithun S added 1 commit

    added 1 commit

    • 8c6c095f - 3332473: Update the float values in table-file-multiple-widget file.

    Compare with previous version

  • Mithun S added 177 commits

    added 177 commits

    • 8c6c095f...32f75653 - 170 commits from branch project:10.1.x
    • 83cfe2d1 - Refactored table file multiple widget pcss file
    • e1af980e - Used logical properties
    • 102be87c - Table file selectors updated and addressed feedbacks
    • bea65cb3 - Float logical property updated
    • 909f858d - Refactor css for table file multiple widget.
    • 62c244ee - 3332473: Add the [dir=rtl] css for float properties.
    • c838d8c9 - 3332473: Update the float values in table-file-multiple-widget file.

    Compare with previous version

    Toggle commit list
    • Please register or sign in to reply