GD toolkit & operations should catch \Throwable
2 open threads
Closes #2583041
Merge request reports
Activity
added 76 commits
-
064662e1...754b8ffa - 73 commits from branch
project:9.2.x
- 1cc6fa5c - 88
- 67b5912d - Add GDToolkit::isMemoryAvailable
- b4b70077 - fixes
Toggle commit list-
064662e1...754b8ffa - 73 commits from branch
added 106 commits
-
b4b70077...b6fe1335 - 103 commits from branch
project:9.2.x
- 0b5eac1e - 88
- f9fe8085 - Add GDToolkit::isMemoryAvailable
- b7d623b6 - fixes
Toggle commit list-
b4b70077...b6fe1335 - 103 commits from branch
added 2277 commits
-
b7d623b6...f7e9cbbc - 2276 commits from branch
project:10.1.x
- 587334f4 - Merge branch '10.1.x' into 2583041-gd-toolkit-
-
b7d623b6...f7e9cbbc - 2276 commits from branch
added 96 commits
-
587334f4...8a36ace5 - 94 commits from branch
project:10.1.x
- 100b1303 - Merge branch '10.1.x' into 2583041-gd-toolkit-
- 932f67a2 - Added catching of image save errors
-
587334f4...8a36ace5 - 94 commits from branch
498 545 return [IMAGETYPE_PNG, IMAGETYPE_JPEG, IMAGETYPE_GIF, IMAGETYPE_WEBP]; 499 546 } 500 547 548 /** 549 * Checks that there is enough memory available for a GD operation. IMHO here we should be seeing this as a safety net for very significant miscalculations of dimensions - I have seen this reported sometimes for % rescaling, where one dimension was much smaller then the other and then a x times resizing would blow everything. The problem is that at the moment we only get WSOD and no info of what's wrong. Anyway, added a gc_collect_cycles() as a last resort before failing.
452 452 $this->assertTrue($image->isValid(), 'CreateNew with valid arguments validates the Image.'); 453 453 } 454 454 455 /** 456 * Tests creation of an image that will exceed the memory limit. 457 */ 458 public function testInsufficientMemory(): void { 459 $image = $this->imageFactory->get('core/tests/fixtures/files/image-test.png'); 460 461 $oldGdImage = $image->getToolkit()->getResource(); 462 $this->assertFalse($image->createNew(200000, 200000)); changed this line in version 9 of the diff
added 17 commits
-
093af20e...5f9abc4f - 16 commits from branch
project:10.1.x
- a71dc012 - Merge branch '10.1.x' into 2583041-gd-toolkit-
-
093af20e...5f9abc4f - 16 commits from branch
Please register or sign in to reply