Skip to content
Snippets Groups Projects

Issue #3191699: MAINTAINERS.txt role descriptions outdated, topic maintainer description missing, provisional maintainership incorrect

Open Issue #3191699: MAINTAINERS.txt role descriptions outdated, topic maintainer description missing, provisional maintainership incorrect

Merge request reports

Approval is optional
Merge blocked: 1 check failed
Merge conflicts must be resolved.

Merge details

  • The source branch is 712 commits behind the target branch.
  • 1 commit will be added to 9.2.x.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
509 513 Initiative coordinators
510 514 -----------------------
511 515
512 The Drupal Core Initiative coordinators oversee approved projects that
516 The Drupal Core initiative coordinators oversee approved projects that
  • Comment on lines -512 to +516
    Maintainer

    I don't much understand the scope of this issue, but...

    If we're standardizing on lowercasing "Initiative" and so forth (such that these are not Titles of Roles), "Core" should also be lowercased everywhere according to our content standards. It is lowercase in the first line of the file, but not in the copy-pasted descriptive sections that were added later.

    (The project on Drupal.org is "Drupal core", not "Drupal Core". Core is a modifier, not part of the title -- the title is just "Drupal".)

    Edited by Jess
  • Author Maintainer

    Re "If we're standardizing on lowercasing "Initiative" and so forth", I am not introducing a new thing here. Currently in the file, all the other role names use the same casing, eg. "Drupal Core committers", "Drupal Core subsystem maintainers" and "Drupal Core mentors". All are lowercase from "Drupal Core" onwards. This is not something I am making up.

    There was also an instance of "The initiative coordinators" on top of that.

    Since the patch was touching almost every line of this role's description, it did not feel logical to submit another issue for this single character. I had no idea it would be a contentious issue, since all the other roles use the same "lowercase after Drupal Core" pattern. It is not new.

  • Please register or sign in to reply
  • Jess
    Jess @xjm started a thread on the diff
  • 525 529 Media Initiative
    526 530 - Janez Urevc 'slashrsm' https://www.drupal.org/u/slashrsm
    527 531
    528 Provisional membership: None at this time.
    529
    • Comment on lines -528 to -529
      Maintainer

      I still think that if we're removing this here we should also remove the one remaining instance in the file. Teams are per initiative or per topic; a provisional topic maintainer does not provisionally maintain all of the topics. Either that or we should fix the indentation/locations of the lines. These lines were added on a whim when we updated the governance in 2015 and clearly are not properly maintained when the file is updated, so we should just get rid of them. This is blocking for me.

    • Author Maintainer

      All three instances in the file are removed in the patch, there are not any more to remove as far as I can see.

    • Please register or sign in to reply
    Please register or sign in to reply
    Loading