Skip to content
Snippets Groups Projects

Issue #3227824: Add the decoupled menus module to core

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • John
  • John
  • John
  • John
  • John
  • John
  • Suresh Prabhu added 1 commit

    added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Théodore Biadala added 25 commits

    added 25 commits

    Compare with previous version

  • added 1 commit

    • d34c7171 - removing non existing module

    Compare with previous version

  • Théodore Biadala added 117 commits

    added 117 commits

    Compare with previous version

  • Théodore Biadala changed the description

    changed the description

  • Théodore Biadala changed target branch from 9.3.x to 9.4.x

    changed target branch from 9.3.x to 9.4.x

  • Théodore Biadala added 303 commits

    added 303 commits

    • 9b05611d...bd8f2172 - 183 commits from branch project:9.4.x
    • bd80b71a - Issue #3248600 by andypost, longwave: Update dependencies for 9.3.x
    • 5082060f - Issue #3244621 by mherchel, rikki_iki, catch, cathwaldron, rachel_norfolk,...
    • 4ddfac11 - Issue #3243041 by Gábor Hojtsy: Mark Olivero stable
    • 68f2ce3c - Issue #3248649 by alexpott:...
    • cfb51063 - Issue #3231364 by Wim Leers, lauriii, bnjmnm, webchick, xjm, tim.plunkett,...
    • 56fa4e20 - Drupal 9.3.0-beta1
    • 460665f7 - Back to dev.
    • f436f7c0 - Issue #3222251 by bbrala, longwave: [November 8, 2021] Replace all isset...
    • e125ce28 - Issue #3222769 by bbrala, alexpott, longwave, Matroskeen: [November 8, 2021]...
    • 6af996bb - Issue #3231781 by longwave, mondrake, Feuerwagen, larowlan, TR, nlisgo,...
    • 266679c6 - Issue #3249263 by alexpott, andypost, Wim Leers: CKEditor 5 needs validate the...
    • 910dedc3 - Issue #3249233 by longwave: Update 9.3's Symfony 5 components to 5.4
    • 4657f661 - Issue #3249240 by alexpott, andypost, Wim Leers: HTMLRestrictionsUtilities::...
    • 93f04169 - Issue #2707163 by quietone, chishah92, jhodgdon, AndrewHD, xjm, dww,...
    • 71b89659 - Issue #3248801 by daffie, rakesh.gectcr, bbrala, longwave: [Symfony 6] The...
    • 5939914c - Issue #3248809 by daffie, larowlan: [Symfony 6] The...
    • 72459cd0 - Issue #3248013 by daffie, longwave: [Symfony6] The...
    • 5cf24e8a - Issue #3248816 by bsuttis, danflanagan8, quietone:...
    • 580535ba - Issue #3248810 by daffie: [Symfony 6] The...
    • 92e176d4 - Issue #3056409 by rkostov, larowlan, maximpodorov:...
    • 9de422ea - SA-CORE-2021-011 by jbogdanski, Wim Leers, xjm, greggles, lauriii, tedbow
    • 159085e5 - Drupal 9.3.0-beta2
    • aa988ef4 - Back to dev.
    • ce8e734a - Issue #3248014 by daffie, andypost: [Symfony 6] The...
    • 2126f4c7 - Issue #3207567 by Spokje, quietone, guilhermevp, yogeshmpawar, daffie,...
    • 17999022 - Issue #3221082 by Wim Leers, lauriii, bnjmnm: Build Drupal's CKEditor 5...
    • 3f5645f3 - Issue #3250335 by alexpott, beatrizrodrigues, paulocs, longwave:...
    • 5cc55e82 - Issue #3250349 by alexpott:...
    • afc5a87e - Issue #3231040 by alexpott, Anul, longwave, bbrala, catch: (revert) Remove...
    • 2eec3dc4 - Issue #3171570 by kostyashupenko, mherchel: Remove Olivero's custom...
    • 37a54000 - Issue #3138078 by mondrake, larowlan, longwave, xjm: [D9.3 beta - w/c Nov 8,...
    • f6ffe6ae - Issue #3250629 by paulocs, longwave: MockBuilder::setMethods is deprecated in...
    • af165d2a - Issue #3250587 by lauriii, bnjmnm:...
    • 4b233f80 - Issue #3250482 by quietone, daffie: The docblock of...
    • b2b0f12b - Issue #3247414 by anagomes, Beakerboy: Incorrect docblock types for...
    • 59d8ab1f - Issue #3184619 by neclimdul, quietone: Fix unreachable logic in UrlGenerator::getRoute
    • d4bf8fb7 - Issue #3250743 by alexpott, longwave: [PHP 8.1] NumberFieldTest fails
    • f5154362 - Issue #3061074 by longwave, cilefen, chr.fritsch, acbramley, jungle, larowlan:...
    • 88adf9c1 - Issue #3032275 by alexpott, dww, bendeguz.csirmaz, tedbow: Create a...
    • 2ed1f629 - Issue #3251000 by alexpott, andypost: Update dependencies for 9.1.x/9.2.x/9.3.x/9.4.x
    • 43e9d14a - Drupal 9.3.0-beta3
    • 6c607c1d - Back to dev.
    • f325f8e2 - Issue #3238763 by longwave, Spokje, Krzysztof Domański, tstoeckler, quietone:...
    • 1ce94975 - Issue #3214924 by catch: Increase DRUPAL_RECOMMENDED_PHP to 8.0 in Drupal 9.3 or 9.4
    • 74c604a2 - Drupal 9.3.0-rc1
    • af4f79e8 - Back to dev.
    • 38a6e2c0 - Issue #3251768 by longwave: Update Symfony 5 dependencies to 5.4.0
    • 81690f84 - Issue #3251625 by alexpott, Berdir: Including settings.php a second time and...
    • 22ccab65 - Issue #2871357 by alexpott, kriboogh: Installer tasks using multiple batch...
    • 8ee62fe9 - Issue #2925203 by alexpott: LocaleConfigSubscriber can result in data loss during install
    • aeb8420a - Issue #2886615 by scott_euser, clemens.tolboom, quietone, joachim, alexpott,...
    • dbe62991 - Issue #3252214 by Spokje: Move tests for integrations between QuickEdit and...
    • e1cbad3f - Revert "Issue #2934995 by benjifisher, larowlan, paulocs, AaronMcHale,...
    • 72d15850 - Issue #3251034 by lauriii, bnjmnm, longwave: Core Yarn watch builds CK5...
    • 698ee686 - Drupal 9.3.0
    • 4d7c1ebc - Back to dev.
    • e1dcff57 - Issue #3253824 by juli sh, Matroskeen: Minor typo in d7_field_formatter_settings.yml comment
    • bf1fc45b - Issue #3252067 by tedbow, Spokje: Remove duplicate loading of update reports...
    • fbc65b3b - Issue #3250648 by Beakerboy, daffie: Avoid comparing fields with different...
    • fcc9a6b1 - Issue #3253683 by andypost, Spokje, Gábor Hojtsy: Improve compatibility with composer 2.2
    • 9ab4ed2b - Issue #3239287 by alexpott, longwave: Fix...
    • 698e3a8c - Issue #3253568 by Spokje, paul121, rviner, longwave, alexpott, quietone:...
    • 2193f990 - Issue #3246157 by ChrisDarke, rachel_norfolk: Add Chris Darke (ChrisDarke) as...
    • 0ee2379b - Issue #3246158 by rachel_norfolk, volkswagenchick: Add AmyJune Hineline...
    • eeb1436e - Issue #3246156 by realityloop, rachel_norfolk: Add Brian Gilbert (realityloop)...
    • 51d7a6cf - Issue #3253889 by BR0kEN, murilohp, longwave: `?check_logged_in=1` causes...
    • 08a4f0fb - Issue #3254403 by paulmckibben, ranjith_kumar_k_u, longwave, Lendude, cilefen:...
    • 20deaf43 - Issue #3080819 by beatrizrodrigues, ankithashetty, lucienchalom, quietone,...
    • 9a569871 - Issue #3248309 by danflanagan8: AssertBreadcrumbTrait should not rely on Classy
    • cd71d737 - Issue #3251125 by Beakerboy, daffie, mondrake: Do not uninstall the database...
    • 81257146 - Issue #3245383 by Beakerboy, daffie: If the database driver is provided by a...
    • 8278566b - Issue #3064890 by danflanagan8, mpp, mottihoresh, scott_euser, peonboyos,...
    • 678734f8 - Issue #3247269 by Sakthivel M, mherchel: Olivero: Alignment of primary menu...
    • 8a3528fe - Issue #3255836 by alexpott, clayfreeman, dww, benjifisher, Spokje: Test fails due to Composer 2.2
    • 03d919b0 - Issue #3247039 by joachim, quietone: MigrateDestinationInterface::import()...
    • 23fc2b7d - Issue #2793169 by Matroskeen, Manuel Garcia, anmolgoyal74, Pooja Ganjage,...
    • 00e48f5b - Issue #3205909 by kunal.sachdev, tedbow, phenaproxima: Ensure only needed...
    • d764daae - Issue #3092430 by quietone, shrutidkadam, RdeBoer, bgprior, danflanagan8:...
    • 3246a76f - Issue #2675006 by danflanagan8, robpowell, quietone: Write UnitTest for...
    • 3e6bdf7e - Issue #3212470 by JeroenT, Gauravmahlawat: Placeholder CSS selector in...
    • 1c0246c7 - Issue #2675006 by danflanagan8, robpowell, quietone, alexpott: Write UnitTest...
    • 950da2e9 - Issue #3136388 by dww, jyotimishra-developer, nitesh624: Fix phpdocs in...
    • 3f59ee8a - Issue #3255504 by anagomes, Chi, cilefen: Remove jQuery dependency from date.js
    • aaa470ee - Issue #3131348 by Spokje, jungle, mondrake, vsujeetkumar, sja112,...
    • 90bd6795 - Issue #3251835 by beatrizrodrigues, joachim, mikelutz, quietone: Fix incorrect...
    • 543dc50b - Issue #3249859 by apaderno: The documentation page for...
    • e537bf66 - Issue #3174570 by quietone, anmolgoyal74, skudderk: Fix documentation comment...
    • 923ad861 - Issue #3175287 by murilohp, quietone, SivaprasadC, ankithashetty,...
    • f15f24ad - Issue #2853183 by quietone, darvanen, slootjes, Munavijayalakshmi,...
    • 7ef26e67 - Issue #3256581 by cburschka: PHPdoc in update.authorize.inc
    • 39a075f3 - Issue #3213928 by RoSk0: LoggerChannelInterface documentation
    • d277261d - Issue #2916142 by beatrizrodrigues, Chi, yogeshmpawar, tobiberlin, quietone,...
    • 5cd38822 - Issue #3256591 by yassermussa, Chi: Fix Element/Table documentation
    • 47d0aa0e - Issue #3190261 by danflanagan8, doostinharrell, phenaproxima, larowlan,...
    • ee025067 - Issue #3207907 by quietone, Berdir, alexpott: Ensure functional tests use the test mail collector
    • 66130f62 - Issue #3014629 by quietone, Wim Leers, xurizaemon: Document that Configuration...
    • a5552052 - Issue #2879293 by digitaldonkey, tobiasb, Mac_Weber, paulocs, Meenakshi_j,...
    • 77d5784a - Issue #3247619 by Lendude, danflanagan8, FiNeX, beatrizrodrigues: "Place a...
    • 2c712eb4 - Drupal 9.3.1
    • db6ccbac - Back to dev.
    • 5376e4c4 - Drupal 9.3.2
    • 0c610b46 - Back to dev.
    • fa4a632f - Issue #2612876 by leolandotan, NickDickinsonWilde, victoria-marina,...
    • 7f3ab430 - Issue #3257654 by mondrake: Fix PHPStan L0 failures that cannot be included in baseline
    • 879b39ee - Issue #3254553 by Leon Kessler, Berdir, Bladedu, cmlara:...
    • 4bb9f46b - Issue #3255245 by Spokje, longwave, daffie, Gábor Hojtsy, Taran2L, murilohp:...
    • fbd3adf9 - Issue #3255077 by JoshaHubbers, Gauravmahlawat, beatrizrodrigues: Small typos in CKEditor 5 module
    • 4711b764 - Issue #3258371 by nod_, Wim Leers: fix yarn vendor-update command
    • d672dfa5 - Issue #3228778 by nod_, Wim Leers: Drupal-specific CKEditor 5 plugins should...
    • 6c0fe615 - Issue #3238257 by hooroomoo, Wim Leers: Fragment link pointing to <textarea>...
    • 26b81c40 - Issue #3254328 by GoZ, GOT intermedia, PapaGrande: Update to Drupal 9.3.0...
    • a5ff2b77 - SA-CORE-2022-001 by lauriii, cilefen, mcdruid, effulgentsia, bnjmnm, xjm, nod_
    • b6c79dbc - Drupal 9.3.3
    • 97420431 - Merged 9.3.3.
    • 19449f60 - Back to dev.
    • 2b17322f - Simplify
    • 1c6a8b84 - Merge branch '9.3.x' of https://git.drupalcode.org/project/drupal into 3227824-add-the-decoupled
    • 29f8f938 - Merge branch '9.4.x' into 3227824-add-the-decoupled
    • 62b319ad - move to 9.4.x branch
    • 98df14d1 - remove format

    Compare with previous version

  • added 1 commit

    • ccf91269 - Removing test for an out of scope feature

    Compare with previous version

  • Brian Perry added 2 commits

    added 2 commits

    • 82f6c017 - Rename drupal-menu-hierarchy attribute to hierarchy
    • d9b1d9f1 - Rename drupal-menu-machine-name attribute to machine-name

    Compare with previous version

  • Brian Perry added 1 commit

    added 1 commit

    • c206a352 - Remove Hal dependency from test module

    Compare with previous version

  • Yogesh Pawar added 1 commit

    added 1 commit

    Compare with previous version

  • Brian Perry added 1 commit

    added 1 commit

    • 30cbe014 - Convert Linkset hierarchy to array of strings

    Compare with previous version

  • Brian Perry added 318 commits

    added 318 commits

    Compare with previous version

  • Brian Perry added 4 commits

    added 4 commits

    • dfa5b2c6 - Make menu linkset endpoint opt-in via configuration.
    • ae79b88b - Set route rebuild when linkset endpoint is enabled or disabled
    • 461c221f - Remove unnecessary dependencies injected into MenuLinksetRoutes class
    • 3c46c330 - Update tests to enable endpoint, add test for disabled endpoint

    Compare with previous version

  • Brian Perry added 1 commit

    added 1 commit

    Compare with previous version

  • Brian Perry added 2 commits

    added 2 commits

    • b1e3b660 - Refactor MenuLinksetRoutes to use dependency injection
    • 6caaf774 - Refactor event subscriber to use dependency injection

    Compare with previous version

  • Brian Perry added 1 commit

    added 1 commit

    • e06eb62f - Comment cleanup and moved json to fixtures directory

    Compare with previous version

  • Brian Perry added 1 commit

    added 1 commit

    • 587b00f7 - Revert "Refactor event subscriber to use dependency injection"

    Compare with previous version

  • Björn Brala added 1 commit

    added 1 commit

    • 7e883329 - Small comment fix we overlooked

    Compare with previous version

  • Théodore Biadala resolved all threads

    resolved all threads

  • Lauri Timmanee added 1 commit

    added 1 commit

    • 1c52b94e - Use dependency injection for getting config factory in Drupal\system\Routing\EventSubscriber

    Compare with previous version

  • Théodore Biadala resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Théodore Biadala added 52 commits

    added 52 commits

    Compare with previous version

  • 168 // cacheability metadata also.
    169 $url = $element->link->getUrlObject();
    170 $generated_url = $url->toString(TRUE);
    171 $cacheability = $cacheability->addCacheableDependency($generated_url);
    172 // Take the hierarchy value for the current element and append it
    173 // to the link element parent's hierarchy value. See this method's
    174 // docblock for more context on why this value is the way it is.
    175 $hierarchy = $hierarchy_ancestors;
    176 array_push($hierarchy, strval($index));
    177 $link_options = $element->link->getOptions();
    178 $link_attributes = ($link_options['attributes'] ?? []);
    179 $link_rel = $link_attributes['rel'] ?? 'item';
    180 // Encode the link.
    181 $link = [
    182 'href' => $generated_url->getGeneratedUrl(),
    183 // @todo should this use the "title*" key if it is internationalized?
  • 277 $link_items = Json::decode((string) $response->getBody())['linkset'][0]['item'];
    278 $titles = array_column($link_items, 'title');
    279 $this->assertNotContains('Our name', $titles);
    280 // Redo the request, but authenticate as the unpublished page's author.
    281 $response = $this->doRequest(Request::create('/system/menu/main/linkset'), 200, $this->authorAccount);
    282 $expected_cacheability = new CacheableMetadata();
    283 $expected_cacheability->addCacheContexts(['user']);
    284 $expected_cacheability->addCacheTags([
    285 'config:system.menu.main',
    286 'http_response',
    287 'node:1',
    288 'node:2',
    289 'node:3',
    290 ]);
    291 $this->assertDrupalResponseCacheability(FALSE, $expected_cacheability, $response);
    292 // Ensure the "Our name" menu link is no longer visible.
  • Lee Rowlands
  • 520 520 _controller: '\Drupal\system\Controller\CsrfTokenController::csrfToken'
    521 521 requirements:
    522 522 _access: 'TRUE'
    523
    524 system.linkset_settings:
    525 path: '/admin/config/services/linkset'
    526 defaults:
    527 _title: 'Menu Linkset Settings'
    528 _form: 'Drupal\system\Form\MenuLinksetSettingsForm'
    529 requirements:
    530 _permission: 'access administration pages'
    • Comment on lines +529 to +530

      this permission is too broad, it needs to be something less permissive (ideally something that is restricted?) and we should have a test for this form, there's not one that I can see

    • We wrote tests for the settings logic in a way. But indeed no form test from what I remember seeing.

      This was modeled somewhat like the JSON:API config form I think. Would something like this work for you? Administer site configuration.

      jsonapi.settings:
        path: '/admin/config/services/jsonapi'
        defaults:
          _form: '\Drupal\jsonapi\Form\JsonApiSettingsForm'
          _title: 'JSON:API'
        requirements:
          _permission: 'administer site configuration'
    • Administer site configuration is fine, 'access administration pages' is too broad

    • Brian Perry changed this line in version 26 of the diff

      changed this line in version 26 of the diff

    • Please register or sign in to reply
  • Brian Perry added 2 commits

    added 2 commits

    • 63ac7f22 - Minor revisions based on most recent MR review feedback
    • f9b33cf9 - Add test for menu_linkset_settings form

    Compare with previous version

  • Brian Perry added 1 commit

    added 1 commit

    Compare with previous version

  • Ravi Shankar added 1 commit

    added 1 commit

    • 9f82ed48 - Removed content entity save.

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading