Convert system_requirements() into OOP hooks
Closes #3493718
Merge request reports
Activity
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by Derek Wright
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by Sascha Grossenbacher
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
389 389 } 390 390 $install_state['database_verified'] = install_verify_database_settings($site_path); 391 391 // A valid settings.php has database settings and a hash_salt value. Other 392 // settings will be checked by system_requirements(). 392 // settings will be checked by 393 // \Drupal\system\Install\SystemRequirements. 45 * Implements hook_runtime_requirements(). 46 */ 47 #[Hook('runtime_requirements')] 48 public function runtimeRequirements(): array { 49 return $this->checkRequirements('runtime'); 50 } 51 52 /** 53 * Check requirements. 54 * 55 * @param string $phase 56 * The phase to check for. 57 * 58 * @return array 59 * Requirements. 60 */ - Comment on lines +52 to +60
I know these things are documented elsewhere, and that this is just a protected helper method, but the descriptions are not really useful at all. Maybe something like this would be better?
52 /** 53 * Check requirements. 54 * 55 * @param string $phase 56 * The phase to check for. 57 * 58 * @return array 59 * Requirements. 60 */ 52 /** 53 * Check requirements for a given phase. 54 * 55 * @param string $phase 56 * The phase in which requirements are checked, as documented in 57 * hook_requirements(). 58 * 59 * @return array 60 * An associative array of requirements, as documented in 61 * hook_requirements(). 62 */ Otherwise I'd rather leave off the docblock if we were allowed to.
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
- Resolved by nicxvan
Please register or sign in to reply