Issue #3494634 by pdureau, grimreaper: POC Compatibility between SDC and the Form API.

Closes #3494634

added 1 commit

• db28b8ef - Issue #3494634 by grimreaper: Remove what is only for #3508641

Compare with previous version

added 1 commit

• fc780eec - Issue #3494634 by grimreaper, pdureau: dont alter name behavior anymore

Compare with previous version

added 15 commits

• fc780eec...1a2079a4 - 12 commits from branch project:11.x
• 27a9cc6a - Issue #3494634 by pdureau, grimreaper: POC Compatibility between SDC and the Form API.
• c545cb3e - Issue #3494634 by grimreaper: Remove what is only for #3508641
• 9d9eebb4 - Issue #3494634 by grimreaper, pdureau: dont alter name behavior anymore

Compare with previous version

added 1 commit

• b9d82dbd - Issue #3494634: Apply fix from #3520242

Compare with previous version

marked this merge request as ready

added 53 commits

• b9d82dbd...09633691 - 48 commits from branch project:11.x
• 0dedb454 - Issue #3494634 by pdureau, grimreaper: POC Compatibility between SDC and the Form API.
• 74a01480 - Issue #3494634 by grimreaper: Remove what is only for #3508641
• 00aef86d - Issue #3494634 by grimreaper, pdureau: dont alter name behavior anymore
• 8df8cb32 - Issue #3494634: Apply fix from #3520242
• 47cfa9f5 - Issue #3494634 by grimreaper: Add test

Compare with previous version

added 1 commit

• a673226c - Issue #3494634 by grimreaper: Fix pipeline

Compare with previous version

added 1 commit

• ea10dcf8 - Issue #3494634 by grimreaper: Addressing code review feedbacks

Compare with previous version

I agree with catch's concern about #type specific logic in the renderer

The test changes are a nice to have

left review comments

added 25 commits

• ea10dcf8...28357f55 - 23 commits from branch project:11.x
• 786102d0 - Issue #3494634 by pdureau, grimreaper: POC Compatibility between SDC and the Form API.
• 25bd6ce4 - Issue #3494634 by grimreaper: Review feedbacks.

Compare with previous version

added 1 commit

• 751c9c5b - Issue #3494634 by grimreaper: Fix CI

Compare with previous version

resolved all threads

added 1 commit

• b589291e - Issue #3494634 by grimreaper: Fix CI

Compare with previous version

added 1 commit

• 089d7db7 - Issue #3494634 by grimreaper: small improvement

Compare with previous version

added 16 commits

• 089d7db7...9456d921 - 9 commits from branch project:11.x
• 5edb5e23 - Issue #3494634 by pdureau, grimreaper: POC Compatibility between SDC and the Form API.
• b496b156 - Issue #3494634 by grimreaper: Review feedbacks.
• d829505c - Issue #3494634 by grimreaper: Fix CI
• 63535caf - Issue #3494634 by grimreaper: Fix CI
• 8d32f790 - Issue #3494634 by grimreaper: small improvement
• 1d4d8cfd - Revert early render
• ad9049b6 - Simpler approach

Compare with previous version

@pdureau indicated he wasn't convinced the new approach was any better. I took a look and came up with a different approach that just unsets the children after we move them into the slots. Tests pass. It's equivalent to what we were doing in the Renderer in the earlier patches (ie. just rendering the inline-template child) but without any special casing of the ComponentElement type in the renderer.

left review comments

added 1 commit

• bd3a8571 - Empty commit

Compare with previous version

added 1 commit

• 8d3c2c59 - Empty commit

Compare with previous version

added 1 commit

• afc2c385 - Simpler approach

Compare with previous version

resolved all threads