Skip to content
Snippets Groups Projects

Issue #3494634 by pdureau, grimreaper: POC Compatibility between SDC and the Form API.

Issue #3494634 by pdureau, grimreaper: POC Compatibility between SDC and the Form API.
All threads resolved!

Closes #3494634

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • I agree with catch's concern about #type specific logic in the renderer

    The test changes are a nice to have

  • Lee Rowlands left review comments

    left review comments

  • added 25 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Florent Torregrosa resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • godotislate
  • Lee Rowlands added 16 commits

    added 16 commits

    Compare with previous version

  • @pdureau indicated he wasn't convinced the new approach was any better. I took a look and came up with a different approach that just unsets the children after we move them into the slots. Tests pass. It's equivalent to what we were doing in the Renderer in the earlier patches (ie. just rendering the inline-template child) but without any special casing of the ComponentElement type in the renderer.

  • Lee Rowlands left review comments

    left review comments

  • Lee Rowlands added 1 commit

    added 1 commit

    Compare with previous version

  • Lee Rowlands added 1 commit

    added 1 commit

    Compare with previous version

  • Lee Rowlands added 1 commit

    added 1 commit

    Compare with previous version

  • Florent Torregrosa resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading