Skip to content
Snippets Groups Projects

Removed todo line from MigrateControllerTest

Open Removed todo line from MigrateControllerTest
issue/drupal-3515189:3515189-remove-todo into 11.x
2 unresolved threads
Open Jordon Davidson requested to merge issue/drupal-3515189:3515189-remove-todo into 11.x
2 unresolved threads

Closes #3515189

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #499447 passed

Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-3515189

#499451

    Merge request pipeline passed for c9ac1ed4

    Approval is optional
    Code Quality is loading
    Test summary results are being parsed
    Full report
    Ready to merge by members who can write to the target branch.
    • The source branch is 284 commits behind the target branch.
    • 1 commit will be added to 11.x.
    • Source branch will not be deleted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    core/modules/migrate_drupal_ui/tests/src/Functional/MigrateControllerTest.php
    25 25
    26 26 /**
    27 27 * {@inheritdoc}
  • quietone
    quietone @quietone started a thread on an old version of the diff
    • core/modules/migrate_drupal_ui/tests/src/Functional/MigrateControllerTest.php
    25 25
    26 26 /**
    27 27 * {@inheritdoc}
    28 *
    29 * @todo Remove and fix test to not rely on super user.
    30 * @see https://www.drupal.org/project/drupal/issues/3437620
    31 28 */
    32 29 protected bool $usesSuperUserAccessPolicy = TRUE;
    33 30
  • quietone left review comments

    left review comments

  • KOUSTAV MONDAL added 1 commit

    added 1 commit

    • 473d27a0 - Issue #3515189 by koustav_mondal: MigrateControllerTest requires root user, remove @todo.

    Compare with previous version

  • Brandon Lira added 1 commit

    added 1 commit

    • 64b3bad7 - Issue #3515189: Restore super user access policy for MigrateControllerTest

    Compare with previous version

  • Brandon Lira added 1 commit

    added 1 commit

    • 8f6aee64 - Issue #3515189: Replace UID 1 check with permission for upgrade log route

    Compare with previous version

  • Brandon Lira added 1 commit

    added 1 commit

    • 8dc018ba - Issue #3515189: Replace UID 1 usage with permission check in MigrateControllerTest

    Compare with previous version

  • Brandon Lira added 1 commit

    added 1 commit

    • 573adb39 - Issue #3515189: Replace UID 1 usage with permission check in MigrateControllerTest

    Compare with previous version

  • Brandon Lira added 1 commit

    added 1 commit

    Compare with previous version

  • Brandon Lira added 1 commit

    added 1 commit

    Compare with previous version

  • M
    Matthew Radcliffe @mradcliffe
    Developer

    We'll also need to change

    $this->drupalLogin($this->rootUser) and the comment above it in MigrateControllerTest to something like

    $account = $this->createUser(['access site reports', 'administer views']);
$this->drupalLogin($account);
  • Brandon Lira added 1 commit

    added 1 commit

    • c9ac1ed4 - Issue #3515189: Replace super user access with proper permissions in MigrateControllerTest

    Compare with previous version

    • Please register or sign in to reply