Skip to content
Snippets Groups Projects

Use a better container cache key

Open Alex Pott requested to merge issue/drupal-3509069:3509069-container-cache-key into 11.x
3 unresolved threads

Closes #3509069

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    • bd038abb - Move the pre autoload dump code to somewhere its runs for all Drupal projects

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • 19 20 * The event.
    20 21 */
    21 22 public static function preAutoloadDump(Event $event) {
    22 // Get the configured vendor directory.
    23 $vendor_dir = $event->getComposer()->getConfig()->get('vendor-dir');
    • Comment on lines 21 to -23
      Author Maintainer

      So interestingly none of this was ever running for sites built from core recommended because this only works via the scripts in the root composer.json of the core repo. I think moving this code to scaffold will solve this - but scaffold does not run if you install Drupal from core git repo... so we need to link the two... fun.

    • Please register or sign in to reply
  • 192 $autoload['classmap'] = array_merge($autoload['classmap'], [
    193 $vendor_dir . '/symfony/http-kernel/HttpKernel.php',
    194 $vendor_dir . '/symfony/http-kernel/HttpKernelInterface.php',
    195 $vendor_dir . '/symfony/http-kernel/TerminableInterface.php',
    196 ]);
    197 }
    198 if ($repository->findPackage('symfony/dependency-injection', $constraint)) {
    199 $autoload['classmap'] = array_merge($autoload['classmap'], [
    200 $vendor_dir . '/symfony/dependency-injection/ContainerInterface.php',
    201 ]);
    202 }
    203 if ($repository->findPackage('psr/container', $constraint)) {
    204 $autoload['classmap'] = array_merge($autoload['classmap'], [
    205 $vendor_dir . '/psr/container/src/ContainerInterface.php',
    206 ]);
    207 }
  • Dave Long
  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • Alex Pott added 104 commits

    added 104 commits

    Compare with previous version

  • Stephen Mustgrave
  • Stephen Mustgrave left review comments

    left review comments

  • Alex Pott added 399 commits

    added 399 commits

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • godotislate
  • godotislate
  • godotislate
  • godotislate
  • godotislate
  • godotislate
  • Alex Pott added 1 commit

    added 1 commit

    • 75eef85d - Apply 6 suggestion(s) to 2 file(s)

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    • 027ec232 - Make drupal/core dependent on drupal/core-composer-scaffold

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 03f65de7 - Added comment about file being generated.

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    • 3cb9a813 - Borrowing code from \Composer\Autoload\AutoloadGenerator and...

    Compare with previous version

  • Alex Pott added 61 commits

    added 61 commits

    Compare with previous version

  • Alex Pott added 67 commits

    added 67 commits

    Compare with previous version

  • catch @catch started a thread on the diff
  • 203 204 */
    204 205 public static function getApcuPrefix($identifier, $root, $site_path = '') {
    205 206 if (static::get('apcu_ensure_unique_prefix', TRUE)) {
    206 return 'drupal.' . $identifier . '.' . \Drupal::VERSION . '.' . static::get('deployment_identifier') . '.' . hash_hmac('sha256', $identifier, static::get('hash_salt') . '.' . $root . '/' . $site_path);
    207 return 'drupal.' . $identifier . '.' . DrupalInstalled::VERSIONS_HASH . '.' . static::get('deployment_identifier') . '.' . hash_hmac('sha256', $identifier, static::get('hash_salt') . '.' . $root . '/' . $site_path);
  • assigned to @alexpott

  • Please register or sign in to reply
    Loading