Skip to content
Snippets Groups Projects

Added the Mr with the Druapl 11 Updats also Added Mr Form Patch #38 suggestion of 40 .

Added the Mr with the Druapl 11 Updats also Added Mr Form Patch #38 suggestion of 40 .
issue/drupal-2205027:2205027-version-in-library into 11.x
1 open thread
Open
Prem Sutharrequested to merge
issue/drupal-2205027:2205027-version-in-library into 11.x
1 open thread

Closes #2205027

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php
166 187 if (isset($library['version'])) {
167 188 // @todo Retrieve version of a non-core extension.
168 189 if ($library['version'] === 'VERSION') {
169 $library['version'] = \Drupal::VERSION;
190 if ($extension_type === 'core' || $extension === 'system') {
191 $real_version = 'VERSION';
192 }
193 elseif ($extension_type === 'theme') {
194 $info = $this->themeHandler->getTheme($extension)->info ?? $this->infoParser->parse($this->themeHandler->getTheme($extension)->getPathname());
195 $real_version = $info['version'] ?? ($info ? NULL : 'VERSION');
  • Dezső Biczó
    Dezső Biczó @mxr576

    I would challenge if the fallback to VERSION is necessary when the version information is not defined for a package, because when that happens, the package is probably is a custom theme/module on a downstream project/local dev env and in that case omitting the asset version guessing and letting the system to hash the asset files to generate the hashed url would be probably better.

  • Please register or sign in to reply
Please register or sign in to reply