Skip to content
Snippets Groups Projects

#3493872: Standardize HttpKernel property name across middleware classes

Merged #3493872: Standardize HttpKernel property name across middleware classes
All threads resolved!
  • Rename property app to httpKernel in NegotiationMiddleware
  • Rename property kernel to httpKernel in StackedHttpKernel
  • Update constructor parameter names from kernel to http_kernel
  • Rename property app to httpKernel in AcceptHeaderMiddleware
  • Rename property kernel to httpKernel in TestMiddleware
  • Update constructor parameter names to match core convention

Closes #3493872

Edited by Heissen Lopez

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Heissen Lopez added 3 commits

    added 3 commits

    • 15e0b591 - Revert #3493872: Modernize middleware classes with constructor property promotion
    • 71326cc1 - #3493872: Standardize HttpKernel property name across middleware classes
    • 4abfbc23 - #3493872: Update test middleware to use consistent HttpKernel property name

    Compare with previous version

  • Heissen Lopez changed title from #3493872: Modernize middleware classes with constructor property promotion to #3493872: Standardize HttpKernel property name across middleware classes

    changed title from #3493872: Modernize middleware classes with constructor property promotion to #3493872: Standardize HttpKernel property name across middleware classes

  • Heissen Lopez added 1 commit

    added 1 commit

    • 3884d619 - #3493872: Fix property reference in NegotiationMiddleware handle method

    Compare with previous version

  • Heissen Lopez changed the description

    changed the description

  • Heissen Lopez resolved all threads

    resolved all threads

  • Kyle Wolford added 2 commits

    added 2 commits

    • 26a0e282 - #3493872: Update NegotiationMiddlewareTest to use consistent HttpKernel property name
    • f16693b4 - #3493872: Update ContentLengthTest to use consistent HttpKernel property name

    Compare with previous version

  • Kyle Wolford added 451 commits

    added 451 commits

    Compare with previous version

  • closed

  • Please register or sign in to reply
    Loading