Issue #3493914: Add test coverage for block visibility vertical tabs
2 open threads
Closes #3493914
Merge request reports
Activity
added 1 commit
- 0a9759ee - Update BlockAddTest.php Simplify: only check that text is not in the tab titles
47 47 $assert_session->assertWaitOnAjaxRequest(); 48 48 $assert_session->pageTextNotContains('The submitted value Pre-content in the Region element is not allowed.'); 49 49 $assert_session->optionExists('Region', '- Select -'); 50 // Check whether the text "Response status" or "Not restricted" is present in the tab titles. -
It would be better to explain that this is checking the summary line. Also changed to wrap at 80, per coding standards.
changed this line in version 3 of the diff
47 47 $assert_session->assertWaitOnAjaxRequest(); 48 48 $assert_session->pageTextNotContains('The submitted value Pre-content in the Region element is not allowed.'); 49 49 $assert_session->optionExists('Region', '- Select -'); 50 // Check whether the text "Response status" or "Not restricted" is present in the tab titles. 51 $assert_session->elementTextNotContains('css', '.vertical-tabs__menu-item-title', 'Response status'); 52 $assert_session->elementTextNotContains('css', '.vertical-tabs__menu-item-title', 'Not restricted'); - Comment on lines +51 to +52
51 $assert_session->elementTextNotContains('css', '.vertical-tabs__menu-item-title', 'Response status'); 52 $assert_session->elementTextNotContains('css', '.vertical-tabs__menu-item-title', 'Not restricted'); 51 $summary_text = $this->getSession()->getPage()->find('css', 'li.vertical-tabs__menu-item:nth-child(1) > a:nth-child(1) > span:nth-child(2)')->getText(); 52 $assert_session->elementTextContains('css', '.vertical-tabs__menu-item-title', 'Response status'); 53 $assert_session->elementTextNotContains('css', '.vertical-tabs__menu-item-title', $summary_text); Maybe we should get the summary line first and then compare? Also, 'Response status' should be in the title text for the first tab.
changed this line in version 4 of the diff
added 13 commits
-
1241e0c9...51ae0389 - 9 commits from branch
project:11.x - dc7a7c41 - Issue #3493914: Add test coverage for block visibility vertical tabs
- 54a86552 - Update BlockAddTest.php Simplify: only check that text is not in the tab titles
- fbfd6a57 - Apply 1 suggestion(s) to 1 file(s)
- f961020a - Apply 1 suggestion(s) to 1 file(s)
Toggle commit list-
1241e0c9...51ae0389 - 9 commits from branch
added 133 commits
-
f961020a...873f84fc - 128 commits from branch
project:11.x - 19ca4a41 - Issue #3493914: Add test coverage for block visibility vertical tabs
- 53f8edb6 - Update BlockAddTest.php Simplify: only check that text is not in the tab titles
- a96751c7 - Apply 1 suggestion(s) to 1 file(s)
- df3b4878 - Apply 1 suggestion(s) to 1 file(s)
- 59d7761d - Removed unused variable and directly called method.
Toggle commit list-
f961020a...873f84fc - 128 commits from branch
Please register or sign in to reply