Skip to content
Snippets Groups Projects

[#3471194] Remove extra slash from generate sample value

All threads resolved!

Closes #3471194

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User added 1 commit

    added 1 commit

    • 9b4e4551 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Ghost User added 1 commit

    added 1 commit

    • 6ab79d8a - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Ghost User added 1 commit

    added 1 commit

    • 465ffa0a - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Ghost User added 1 commit

    added 1 commit

    • 6b5ff097 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Stephen Mustgrave resolved all threads

    resolved all threads

  • Ghost User added 1 commit

    added 1 commit

    • 63fa0d45 - Issue-3471194-filegeneratesamplevalue-makes-bad: Made suggested changes on MR.

    Compare with previous version

  • Stephen Mustgrave resolved all threads

    resolved all threads

  • Lee Rowlands
  • shalini jha added 1 commit

    added 1 commit

    • 8fa88aaf - Update the assertion to ensure proper testing

    Compare with previous version

  • shalini jha added 213 commits

    added 213 commits

    • 8fa88aaf...ee894196 - 204 commits from branch project:11.x
    • 8f2a8098 - [#3471194] Remove extra slash from generate sample value
    • 06dbbfdf - Add test group annotation
    • cd6c96f8 - Apply 1 suggestion(s) to 1 file(s)
    • efde61c1 - Apply 1 suggestion(s) to 1 file(s)
    • 3d040657 - Apply 1 suggestion(s) to 1 file(s)
    • cad39b17 - Apply 1 suggestion(s) to 1 file(s)
    • 291e445f - Issue-3471194-filegeneratesamplevalue-makes-bad: Made suggested changes on MR.
    • 175af319 - Update the assertion to ensure proper testing
    • 6c613c5e - Updated the logic in doGetUploadLocation method

    Compare with previous version

  • shalini jha added 1 commit

    added 1 commit

    • 5929274e - Fix extra slash in ImageItem class and add test coverage

    Compare with previous version

  • shalini jha added 96 commits

    added 96 commits

    • 5929274e...e2b97e56 - 86 commits from branch project:11.x
    • 44caf2a2 - [#3471194] Remove extra slash from generate sample value
    • 8bd7f388 - Add test group annotation
    • 7cfebef8 - Apply 1 suggestion(s) to 1 file(s)
    • 689fbfdc - Apply 1 suggestion(s) to 1 file(s)
    • 18a143b1 - Apply 1 suggestion(s) to 1 file(s)
    • 0930d57b - Apply 1 suggestion(s) to 1 file(s)
    • 7bdfd00b - Issue-3471194-filegeneratesamplevalue-makes-bad: Made suggested changes on MR.
    • 398a07fe - Update the assertion to ensure proper testing
    • 21886a42 - Updated the logic in doGetUploadLocation method
    • 19b6be26 - Fix extra slash in ImageItem class and add test coverage

    Compare with previous version

  • shalini jha added 1 commit

    added 1 commit

    Compare with previous version

  • shalini jha added 1 commit

    added 1 commit

    Compare with previous version

  • shalini jha added 1 commit

    added 1 commit

    • b94016a8 - Update comment for file directory validation

    Compare with previous version

  • shalini jha added 441 commits

    added 441 commits

    • b94016a8...1a2079a4 - 428 commits from branch project:11.x
    • 1a2079a4...e2115cd2 - 3 earlier commits
    • db13d9f8 - Apply 1 suggestion(s) to 1 file(s)
    • 11c06047 - Apply 1 suggestion(s) to 1 file(s)
    • 41398abb - Apply 1 suggestion(s) to 1 file(s)
    • fda9b197 - Issue-3471194-filegeneratesamplevalue-makes-bad: Made suggested changes on MR.
    • c92cf916 - Update the assertion to ensure proper testing
    • 22d1c17b - Updated the logic in doGetUploadLocation method
    • 90a002f8 - Fix extra slash in ImageItem class and add test coverage
    • 05082164 - Updated comment
    • a316a1e3 - Address feedback
    • 471852b5 - Update comment for file directory validation

    Compare with previous version

  • shalini jha added 1 commit

    added 1 commit

    • 94d56dd7 - Refactored trailing slash handling within the same function instead of doGetUploadLocation.

    Compare with previous version

  • Stephen Mustgrave left review comments

    left review comments

  • Kim Pepper
  • Kim Pepper
  • Kim Pepper
  • Kim Pepper left review comments

    left review comments

  • shalini jha added 17 commits

    added 17 commits

    • 94d56dd7...23301df6 - 2 commits from branch project:11.x
    • 23301df6...99f47b41 - 5 earlier commits
    • f72a4597 - Apply 1 suggestion(s) to 1 file(s)
    • 852fbfde - Issue-3471194-filegeneratesamplevalue-makes-bad: Made suggested changes on MR.
    • 798488ee - Update the assertion to ensure proper testing
    • 9af115f3 - Updated the logic in doGetUploadLocation method
    • 88f28c5e - Fix extra slash in ImageItem class and add test coverage
    • dda200af - Updated comment
    • 3075a5ba - Address feedback
    • 6c21f09b - Update comment for file directory validation
    • 89e25740 - Refactored trailing slash handling within the same function instead of doGetUploadLocation.
    • b9f914c8 - Addressed feedback

    Compare with previous version

  • Kim Pepper resolved all threads

    resolved all threads

  • We normally do this with rtrim() which results in less complexity so changing.

  • Alex Pott left review comments

    left review comments

  • Alex Pott resolved all threads

    resolved all threads

  • Alex Pott resolved all threads

    resolved all threads

  • Alex Pott added 1 commit

    added 1 commit

    • 88f7060d - Apply 3 suggestion(s) to 2 file(s)

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    • 9dee5994 - Revert "Apply 3 suggestion(s) to 2 file(s)"

    Compare with previous version

  • Please register or sign in to reply
    Loading