Skip to content
Snippets Groups Projects

Resolve #2885278 "New 11.x"

Closes #2885278

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Also these changes seem to be tying comment, translations, and node modules together which I don't believe we want.

  • added 1 commit

    • eab4b903 - fix: remove type hiting and node update hooks

    Compare with previous version

  • @smustgrave I updated the MR to remove the type hinting and the node hooks you mentioned. I used these changes on my local site and saw the local menu. Note: I didn't remove this because nothing was mentioned, so I left it there.

    !10289 (diffs)

  • 669 679 \Drupal::service('search.index')->markForReindex('node_search', $nid);
    670 680 }
    671 681 }
    682
    683 /**
    684 * Implements hook_config_translation_info_alter().
    685 */
    686 function node_config_translation_info_alter(&$info): void {
    687 $info['node_type']['class'] = 'Drupal\node\ConfigTranslation\NodeTypeMapper';
  • added 2 commits

    • 5f5bd029 - feat: convert local menu alter into hook object
    • cbb19f52 - fix: remove menu hook from node module

    Compare with previous version

  • added 1 commit

    • 1a3fb764 - fix: remove unused use statements

    Compare with previous version

  • added 1 commit

    • 3438bd2d - fix: lint error add return type

    Compare with previous version

  • 1 <?php
    2
    3 namespace Drupal\node\Hook;
    4
    5 use Drupal\Core\Hook\Attribute\Hook;
    6 use Drupal\Core\Cache\CacheableMetadata;
    7 use Drupal\Core\Cache\RefinableCacheableDependencyInterface;
    8
    9 /**
    10 * Local task menu alter for revisions page.
    11 */
    12 #[Hook('menu_local_tasks_alter')]
  • 678 686 \Drupal::service('search.index')->markForReindex('node_search', $nid);
    679 687 }
    680 688 }
    689
    690 /**
    691 * Implements hook_config_translation_info_alter().
    692 */
    693 function node_config_translation_info_alter(&$info): void {
  • Stephen Mustgrave left review comments

    left review comments

  • Steven Stapleton added 3 commits

    added 3 commits

    • 07afca30 - fix: remove extra hook file
    • 23ac9d3e - fix: remove hook implementations into hook objects
    • fcd1614d - feat: add node hook objects

    Compare with previous version

  • Steven Stapleton added 910 commits

    added 910 commits

    Compare with previous version

  • added 1 commit

    • 246c6ab6 - fix: lint error with missing line after function

    Compare with previous version

  • added 1 commit

    • bb82b9fe - fix: lint error missing new line in mode module file

    Compare with previous version

  • Please register or sign in to reply
    Loading