Skip to content
Snippets Groups Projects

Issue #3484564: Define the 3 areas the Top Bar will provide

Issue #3484564: Define the 3 areas the Top Bar will provide
All threads resolved!

Closes #3484564

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Looking good, a few cleanups that I think go a long way

  • Pablo López added 11 commits

    added 11 commits

    • d9f769d5 - 1 earlier commit
    • 15e83114 - Add deriver property to TopBarItem
    • 4bb429e2 - Use FQCN instead of service alias
    • d088a5bc - Simplify cahceability logic
    • 7d2e750a - Add return typehint
    • 2c9b7048 - Inject current_user service
    • 80352de6 - Remove unnecessary cast
    • 8e7fa2a9 - Simplfy getTopBarItemDefinitionsByRegion method
    • e83dfa3a - Refactor uasort implementation
    • 6ab84779 - Improve enum based type-hinting
    • ca837c5a - Remove unnecessary render array sort

    Compare with previous version

  • Thank you for your reviews.

    I think all the comments have been addressed.

  • Théodore Biadala
  • Pablo López added 2 commits

    added 2 commits

    Compare with previous version

  • Lee Rowlands resolved all threads

    resolved all threads

  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Only minor nits here, this looks good to go to me

  • Pablo López added 1 commit

    added 1 commit

    Compare with previous version

  • Pablo López added 1 commit

    added 1 commit

    • 54877ed2 - Add Plugin system test coverage

    Compare with previous version

  • Pablo López added 1 commit

    added 1 commit

    Compare with previous version

  • Pablo López added 58 commits

    added 58 commits

    • 55166e33...1c33460a - 57 commits from branch project:11.x
    • c92f7afd - Merge remote-tracking branch 'origin/11.x' into 3484564-define-top-bar-regions

    Compare with previous version

  • Pablo López added 1 commit

    added 1 commit

    • f00bed60 - Issue #3484564: Define the 3 areas the Top Bar will provide - Remove...

    Compare with previous version

  • Ivan Berdinsky added 25 commits

    added 25 commits

    Compare with previous version

  • reopened

  • m4olivei
  • m4olivei
  • m4olivei
  • m4olivei added 14 commits

    added 14 commits

    Compare with previous version

  • m4olivei added 1 commit

    added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Pablo López added 1 commit

    added 1 commit

    Compare with previous version

  • Pablo López resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Please register or sign in to reply
    Loading