Issue #3348679 by Anybody: Remove entity_browser dependency, now where...

Issue #3348679 by Anybody: Remove entity_browser dependency, now where media_browser is used everywhere

composer.json

@@ -16,19 +16,15 @@
     "require": {
         "drupal/blazy": ">=2.9",
         "drupal/crop": ">=2.2",
-        "drupal/entity_browser": ">=2.6",
         "drupal/media_entity_file_replace": ">=1",
         "drupal/media_library_edit": ">=2",
         "drupal/fences": "^2 || ^3",
         "drupal/field_group": ">=3.2",
         "drupal/focal_point": ">=1.5",
-        "drupal/inline_entity_form": ">=1.0",
         "drupal/metatag": ">=1.19",
         "drupal/pathauto": ">=1.9",
-        "drupal/rabbit_hole": ">=1.0",
         "drupal/smart_trim": ">=1.3",
         "drupal/views_bulk_operations": ">=4",
-        "drupal/views_linkarea": ">=1.3",
-        "drupal/viewsreference": ">=1.7"
+        "drupal/views_linkarea": ">=1.3"
     }
 }

drowl_media.module

@@ -104,7 +104,6 @@ function drowl_media_field_widget_form_alter(&$element, FormStateInterface $form
   $admin_theme = \Drupal::config('system.theme')->get('admin');
 
   if (!empty($context['widget']) && in_array($context['widget']->getPluginId(), [
-    'entity_browser_entity_reference',
     'media_library_widget',
   ])) {
     // Attach in media library widget:

modules/drowl_media_types/config/install/core.entity_form_display.media.slideshow.default.yml

@@ -2,7 +2,6 @@ langcode: en
 status: true
 dependencies:
   config:
-    - entity_browser.browser.media_browser_slide
     - field.field.media.slideshow.field_media_folder
     - field.field.media.slideshow.field_media_slides_ref
     - field.field.media.slideshow.field_media_tags
@@ -14,28 +13,11 @@ dependencies:
     - field.field.media.slideshow.field_slide_infinite
     - media.type.slideshow
   module:
-    - entity_browser
     - field_group
+    - media_library
+    - media_library_edit
 third_party_settings:
   field_group:
-    group_medien:
-      children:
-        - langcode
-        - name
-        - field_media_slides_ref
-        - field_slide_height
-        - group_slideshow_options
-        - field_notes
-      label: Medien
-      region: content
-      parent_name: ''
-      weight: 0
-      format_type: fieldset
-      format_settings:
-        classes: ''
-        id: ''
-        description: ''
-        required_fields: true
     group_structure:
       children:
         - field_media_folder
@@ -43,7 +25,7 @@ third_party_settings:
       label: Einordnung
       region: content
       parent_name: ''
-      weight: 1
+      weight: 10
       format_type: fieldset
       format_settings:
         classes: ''
@@ -58,8 +40,8 @@ third_party_settings:
         - field_slide_infinite
       label: 'Override slideshow options'
       region: content
-      parent_name: group_medien
-      weight: 17
+      parent_name: ''
+      weight: 4
       format_type: details
       format_settings:
         classes: ''
@@ -80,20 +62,14 @@ content:
     settings: {  }
     third_party_settings: {  }
   field_media_slides_ref:
-    type: entity_browser_entity_reference
-    weight: 15
+    type: media_library_widget
+    weight: 2
     region: content
     settings:
-      entity_browser: media_browser_slide
-      field_widget_display: rendered_entity
-      field_widget_edit: true
-      field_widget_remove: true
-      field_widget_replace: false
-      open: true
-      field_widget_display_settings:
-        view_mode: media_library
-      selection_mode: selection_append
-    third_party_settings: {  }
+      media_types: {  }
+    third_party_settings:
+      media_library_edit:
+        show_edit: '1'
   field_media_tags:
     type: entity_reference_autocomplete_tags
     weight: 4

modules/drowl_media_types/config/install/entity_browser.browser.media_browser_slide.yml

-langcode: en
-status: true
-dependencies:
-  config:
-    - views.view.media_library
-  module:
-    - entity_browser_entity_form
-    - views
-name: media_browser_slide
-label: 'Media Browser Slide'
-display: modal
-display_configuration:
-  width: ''
-  height: ''
-  link_text: 'Select Slides'
-  auto_open: false
-selection_display: no_display
-selection_display_configuration: {  }
-widget_selector: tabs
-widget_selector_configuration: {  }
-widgets:
-  1b281986-64f5-49ee-b79e-171d5149c3c6:
-    id: entity_form
-    uuid: 1b281986-64f5-49ee-b79e-171d5149c3c6
-    label: 'Create new slide'
-    weight: -9
-    settings:
-      submit_text: 'Create Slide'
-      entity_type: media
-      bundle: slide
-      form_mode: default
-  25ada27e-3607-4b84-b9dc-0d3e6ea9d30e:
-    id: view
-    uuid: 25ada27e-3607-4b84-b9dc-0d3e6ea9d30e
-    label: 'From Media Library'
-    weight: -10
-    settings:
-      submit_text: 'Select slides'
-      auto_select: false
-      view: media_library
-      view_display: entity_browser_media_slideshow_slide

modules/drowl_media_types/drowl_media_types.info.yml

@@ -23,8 +23,6 @@ dependencies:
   - 'drupal:text'
   - 'drupal:views'
   - 'entity_access_by_role_field:entity_access_by_role_field'
-  - 'entity_browser:entity_browser'
-  - 'entity_browser:entity_browser_entity_form'
   - 'fences:fences'
   - 'field_group:field_group'
   - 'file_download_link:file_download_link'

tests/src/Functional/DrowlMediaTypesFunctionalTests.php

@@ -40,22 +40,17 @@ class DrowlMediaTypesFunctionalTests extends BrowserTestBase {
     // Contrib modules:
     'blazy',
     'crop',
-    'entity_browser',
-    'entity_browser_entity_form',
     'media_entity_file_replace',
     'media_library_edit',
     'micon',
     'fences',
     'field_group',
     'focal_point',
-    'inline_entity_form',
     'metatag',
     'pathauto',
-    'rabbit_hole',
     'responsive_image',
     'smart_trim',
     'views_linkarea',
-    'viewsreference',
     'drowl_media',
     'drowl_media_types',
   ];