Update DraggableViews.php
Open
requested to merge issue/draggableviews-3346320:3346320-undefined-draggableviewsstructureparent into 2.1.x
1 unresolved thread
Closes #3346320
Merge request reports
Activity
56 56 return 0; 57 57 } 58 58 $row = $this->view->result[$index]; 59 $parentIndex = (int) $this->getIndex($row->draggableviews_structure_parent); 59 $parentIndex = (isset($row->draggableviews_structure_parent)) ? (int) $this->getIndex($row->draggableviews_structure_parent) : 0; -
Using
isset()will returnTRUEifdraggableviews_structure_parentisNULL, so we should probably protect against that as well. -
Using property_exists() would be a bit cleaner. Something like this:
$parentIndex = property_exists($row, 'draggableviews_structure_parent') ? (int) $this->getIndex($row->draggableviews_structure_parent) : 0;
-
Looks like this was fixed upstream yay!
Edited by Casey Grzecka
Please register or sign in to reply