Skip to content
Snippets Groups Projects

Issue #3411259: Run and correct PHPCS issues

Open Alberto Paderno requested to merge issue/domain-3411259:3411259-branch-2-0-x into 2.0.x
7 unresolved threads

Closes #3411259

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
118 117 '#default_value' => $domain->label(),
119 118 '#description' => $this->t('The human-readable name is shown in domain lists and may be used as the title tag.'),
120 119 ];
121 // Do not use the :// suffix when storing data.
122 $add_suffix = FALSE;
123 120 $form['scheme'] = [
124 121 '#type' => 'radios',
125 122 '#title' => $this->t('Domain URL scheme'),
126 123 '#options' => [
127 'http' => 'http://',
128 'https' => 'https://',
129 'variable' => 'Variable',
124 'http' => $this->t('http://'),
125 'https' => $this->t('https://'),
  • Tobias Bähr added 1 commit

    added 1 commit

    • f43db56f - Manually fixes and phpcs.xml to stop useless standard checks.

    Compare with previous version

  • Tobias Bähr added 1 commit

    added 1 commit

    • 5cdea426 - Switch to login form before try to login

    Compare with previous version

  • Tobias Bähr added 1 commit

    added 1 commit

    Compare with previous version

  • Tobias Bähr added 1 commit

    added 1 commit

    • b2017bc3 - Use waitForText to wait until the redirect via ajax was done

    Compare with previous version

  • Tobias Bähr added 1 commit

    added 1 commit

    Compare with previous version

  • Tobias Bähr added 1 commit

    added 1 commit

    Compare with previous version

  • Tobias Bähr added 1 commit

    added 1 commit

    Compare with previous version

  • Tobias Bähr added 1 commit

    added 1 commit

    • 788212fb - Do not exclude rules. Only extends the lineLimit for comments.

    Compare with previous version

  • phpcs.xml 0 → 100644
    1 <?xml version="1.0" encoding="UTF-8"?>
    2 <ruleset name="drupal-project">
    3 <description>Default PHP CodeSniffer configuration for Drupal project.</description>
    4 <arg name="colors"/>
    5 <rule ref="Drupal">
    6 <properties>
    7 <property name="lineLimit" value="120"/>
    8 </properties>
    9 </rule>
    10
    11 <exclude-pattern>/.ddev</exclude-pattern>
    12 <exclude-pattern>/.lando</exclude-pattern>
    13 <arg name="extensions" value="php,inc,module,install"/>
  • phpcs.xml 0 → 100644
    1 <?xml version="1.0" encoding="UTF-8"?>
    2 <ruleset name="drupal-project">
  • phpcs.xml 0 → 100644
    1 <?xml version="1.0" encoding="UTF-8"?>
    2 <ruleset name="drupal-project">
    3 <description>Default PHP CodeSniffer configuration for Drupal project.</description>
  • phpcs.xml 0 → 100644
    1 <?xml version="1.0" encoding="UTF-8"?>
    2 <ruleset name="drupal-project">
    3 <description>Default PHP CodeSniffer configuration for Drupal project.</description>
    4 <arg name="colors"/>
  • phpcs.xml 0 → 100644
    1 <?xml version="1.0" encoding="UTF-8"?>
    2 <ruleset name="drupal-project">
    3 <description>Default PHP CodeSniffer configuration for Drupal project.</description>
    4 <arg name="colors"/>
    5 <rule ref="Drupal">
    6 <properties>
    7 <property name="lineLimit" value="120"/>
    8 </properties>
    9 </rule>
    10
  • Thanks for your changes, added some suggestion for phpcs.xml. Please check.

  • Tobias Bähr added 1 commit

    added 1 commit

    Compare with previous version

  • 6 6 use Drupal\Core\Form\FormStateInterface;
    7 7
    8 8 /**
    9 * Class DomainSettingsForm.
    9 * Provides the settings form for domain module.
  • Tobias Bähr added 1 commit

    added 1 commit

    Compare with previous version

  • Tobias Bähr added 1 commit

    added 1 commit

    Compare with previous version

  • Tobias Bähr added 1 commit

    added 1 commit

    • 6c035819 - More upper case module names

    Compare with previous version

  • Please register or sign in to reply
    Loading