Issue #3612550: Backport the entity-storage getters from 4.x to 3.x

Frank Mablyrequested to merge
issue/domain-3612550:3612550-backport-the-entity-storage into 3.x

Backports the entity-storage getter pattern from 4.x so 3.x is ready for the 4.0.0 constructor refactor, with no BC break.

  • Each storage property and its initialization are kept and marked @deprecated.
  • A getter returning a fresh storage instance is added, and every internal read is routed through it.
  • Direct-injection constructor parameters (removed in 4.0.0 in favor of injecting the entity type manager) cannot be changed here without a BC-breaking signature change, so they carry a targeted inline @phpstan-ignore drupal.entityStorageDirectInjection.
  • Test classes drop the storage property entirely in favor of a property-less getter, so they need no ignore.

phpstan [OK] (0 errors, storage rules un-suppressed), phpcs 0 errors, cspell clean, kernel suites green (117 tests, 328 assertions).

Merge request reports