Issue #3241340 by gaurav.kapoor: Add more tests for the module

src/Controller/OverviewController.php

@@ -69,7 +69,7 @@ class OverviewController extends ControllerBase {
 
       if ($plugin->available()) {
         $elements = $plugin->elements();
-        foreach ($elements as $key => $element) {
+        foreach ($elements as $element) {
           if (!empty($element['value'])) {
             $row_count = $row_count + 1;
             if ($element['type'] == 'paragraph') {

tests/src/Functional/GenerateFormTest.php

@@ -20,7 +20,7 @@ class GenerateFormTest extends BrowserTestBase {
    *
    * @var array
    */
-  public static $modules = [
+  protected static $modules = [
     'documentation_generator',
   ];
 

tests/src/Unit/Controller/OverviewControllerTest.php

+<?php
+
+namespace Drupal\Tests\documentation_generator\Unit\Controller;
+
+use Drupal\documentation_generator\Controller\OverviewController;
+use Drupal\forum\Form\Overview;
+use Drupal\Tests\UnitTestCase;
+
+/**
+ * @coversDefaultClass \Drupal\documentation_generator\Controller/OverviewViewController
+ * @group documentation_generator
+ */
+class OverviewControllerTest extends UnitTestCase {
+
+  /**
+   * Tests the resolveParameters method.
+   */
+  public function testModuleDependencies() {
+    $documentationGeneratorChapterManager = $this->createMock('Drupal\documentation_generator\Plugin\DocumentationGeneratorChapterManager');
+    $renderer = $this->createMock('Drupal\Core\Render\RendererInterface');
+    $overviewController = new OverviewController($documentationGeneratorChapterManager, $renderer);
+    $output = $overviewController->resolveParameter('This section provides information about Node Types : @parameter', [
+      0 => [
+        'type' => 'link',
+        'text' => '/admin/content',
+        'src' => '/admin/content',
+      ],
+    ]);
+    $this->assertEquals('This section provides information about Node Types : <a href=/admin/content>/admin/content</a>', $output);
+    $items = [
+      'Menu Item 1',
+      'Menu Item 2',
+    ];
+    $output = $overviewController->resolveParameter('This menu is displayed : @parameter', [
+      0 => [
+        'type' => 'list',
+        'items' => $items,
+      ],
+    ]);
+    $this->assertEquals('This menu is displayed : <ul><li>Menu Item 1</li><li>Menu Item 2</li></ul>', $output);
+
+  }
+
+}

tests/src/Unit/Plugin/DocumentationGeneratorChapter/BlockContentTypeTest.php

@@ -16,14 +16,15 @@ class BlockContentTypeTest extends UnitTestCase {
    */
   public function testModuleDependencies() {
     $entityTypeManager = $this->createMock('Drupal\Core\Entity\EntityTypeManagerInterface');
+    $entityFieldManager = $this->createMock('Drupal\Core\Entity\EntityFieldManagerInterface');
     $moduleHandler = $this->createMock('Drupal\Core\Extension\ModuleHandlerInterface');
     $configFactory = $this->createMock('Drupal\Core\Config\ConfigFactoryInterface');
 
-    $blockContentType = new BlockContentType([], '', [], $entityTypeManager, $moduleHandler, $configFactory);
+    $blockContentType = new BlockContentType([], '', [], $entityTypeManager, $entityFieldManager, $moduleHandler, $configFactory);
 
     $dependencies = $blockContentType->moduleDependencies();
 
-    $this->assertInternalType('array', $dependencies);
+    $this->assertIsArray($dependencies);
   }
 
 }