Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
D
diff
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
diff
Merge requests
!32
Issue
#3385760
: compareNodeRevisions ignore the node parameter
Code
Review changes
Check out branch
Open in Workspace
Download
Patches
Plain diff
Expand sidebar
Open
Issue
#3385760
: compareNodeRevisions ignore the node parameter
issue/diff-3385760:3385760-comparenoderevisions-ignore-the
into
2.x
Overview
0
Commits
4
Pipelines
1
Changes
2
Open
Issue #3385760: compareNodeRevisions ignore the node parameter
Philippe Joulot
requested to merge
issue/diff-3385760:3385760-comparenoderevisions-ignore-the
into
2.x
Sep 7, 2023
Overview
0
Commits
4
Pipelines
1
Changes
2
0
0
Merge request reports
Compare
2.x
version 4
0750d673
7 months ago
version 3
0750d673
Sep 7, 2023
version 2
bc3f15ba
Sep 7, 2023
version 1
e00afb0e
Sep 7, 2023
2.x (HEAD)
and
latest version
latest version
82d9bfe4
4 commits,
7 months ago
version 4
0750d673
3 commits,
7 months ago
version 3
0750d673
3 commits,
Sep 7, 2023
version 2
bc3f15ba
2 commits,
Sep 7, 2023
version 1
e00afb0e
1 commit,
Sep 7, 2023
2 files
+
9
−
21
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
src/Controller/NodeRevisionController.php
+
2
−
5
View file @ 48e163a1
Edit in single-file editor
Open in Web IDE
Show full file
@@ -55,13 +55,10 @@ class NodeRevisionController extends PluginRevisionController {
throw
new
AccessDeniedHttpException
();
}
$storage
=
$this
->
entityTypeManager
()
->
getStorage
(
'node'
);
$route_match
=
\Drupal
::
routeMatch
();
$left_revision
=
$storage
->
loadRevision
(
$left_revision
);
$right_revision
=
$storage
->
loadRevision
(
$right_revision
);
if
(
$left_revision
instanceof
ContentEntityInterface
&&
$right_revision
instanceof
ContentEntityInterface
)
{
return
$this
->
compareEntityRevisions
(
$route_match
,
$left_revision
,
$right_revision
,
$filter
);
}
return
[];
$build
=
$this
->
compareEntityRevisions
(
$node
,
$left_revision
,
$right_revision
,
$filter
);
return
$build
;
}
}
Loading