Issue #3296959: Drupal 10 compatibility
4 open threads
4 open threads
Closes #3296959
Merge request reports
Activity
added 1 commit
added 1 commit
- Resolved by Balint Pekker
- Resolved by Balint Pekker
- Resolved by Nejc Koporec
- Resolved by Balint Pekker
- Resolved by Balint Pekker
- Resolved by Balint Pekker
- Resolved by Balint Pekker
added 1 commit
33 33 $edit['status[value]'] = 1; 34 34 } 35 35 } 36 $this->drupalPostForm($path, $edit, $submit); 36 if (!is_null($path)) { 37 $this->drupalGet($path); 38 } 39 $this->submitForm($edit, $submit); - Comment on lines -36 to +39
The release of 8.x-1.0 includes its own version of this method. This isn't needed.
Edited by Matt Glaman changed this line in version 8 of the diff
31 31 if ($this->configuration['compare_format'] == 1) { 32 32 if (isset($values['format'])) { 33 33 $controller = $this->entityTypeManager->getStorage('filter_format'); 34 /** @var \Drupal\filter\Entity\FilterFormat $format */ 34 35 $format = $controller->load($values['format']); 35 36 // The format loaded successfully. 36 37 $label = $this->t('Format'); 37 38 if ($format != NULL) { 38 $result[$field_key][] = $label . ": " . $format->name; 39 $result[$field_key][] = $label . ": " . $format->get('name')->value; changed this line in version 8 of the diff
185 185 $bundles = $field_storage_definition->getBundles(); 186 186 $query->condition('bundle', (array) $bundles, 'IN'); 187 187 } 188 $result = $query->exists($field_key)->range(0, 1)->execute(); 188 $result = $query 189 ->exists($field_key) 190 ->range(0, 1) 191 ->accessCheck() 192 ->execute(); - Comment on lines -188 to +192
Access checks are only required for content entities, not config entities: https://www.drupal.org/node/3201242
changed this line in version 8 of the diff
81 81 $this->submitForm([], 'Compare selected revisions'); 82 82 $this->clickLink('Split fields'); 83 83 // Assert breadcrumbs are properly displayed. 84 $this->assertSession()->responseContains('<nav class="breadcrumb"'); 84 $this->assertSession()->responseContains('<h2 id="system-breadcrumb" class="visually-hidden">Breadcrumb</h2>'); hardcoding something like this tends to be fairly fragile if attribute order changes. One option would be to have a css selector based assert on the id or maybe the block. I'm not even quite sure why we even test the breadcrumb in those tests. Alternatively, a common trick to fix classy tests is to switch to starterkit_base, that has the same markup for the most part.
Please register or sign in to reply