Skip to content
Snippets Groups Projects

Updated base theme image component

Merged Updated base theme image component
issue/demo_design_system-3479196:3479196-integrate-sdds-base into 1.0.x
1 unresolved thread
Merged jacobadeutsch requested to merge issue/demo_design_system-3479196:3479196-integrate-sdds-base into 1.0.x
1 unresolved thread

Closes #3479196

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kristen Pol
  • Kristen Pol
  • Kristen Pol
    Kristen Pol @kepol ·
    Maintainer

    Some minor tweaks

  • Kristen Pol requested changes

    requested changes

  • jacobadeutsch resolved all threads

    resolved all threads

  • jacobadeutsch added 1 commit

    added 1 commit

    • 8bf3ad3c - made changes based on comments

    Compare with previous version

  • Kristen Pol
    Kristen Pol @kepol started a thread on the diff
    • components/01-atoms/image/image.component.yml
    20 20 type: object
    21 21 title: Image
    22 22 examples:
    23 - src: 'https://placehold.co/600x400.png'
    24 alt: 'Placeholder image'
    23 - src: '/themes/contrib/demo_design_system/assets/backgrounds/starshot_placeholder_image_1.jpg'
    24 alt: 'Starshot placeholder image'
  • Kristen Pol
  • Kristen Pol
    Kristen Pol @kepol ·
    Maintainer

    Needs some work but let's ask Alan first.

  • Kristen Pol requested changes

    requested changes

  • jacobadeutsch added 1 commit

    added 1 commit

    Compare with previous version

  • Kristen Pol added 43 commits

    added 43 commits

    Compare with previous version

  • Kristen Pol added 1 commit

    added 1 commit

    • be55b5bb - Switch CT image back to obsolete.

    Compare with previous version

  • Kristen Pol changed title from created image upload with w & h props. 2 glitches currently present to Updated base theme image component

    changed title from created image upload with w & h props. 2 glitches currently present to Updated base theme image component

  • Kristen Pol bypassed reviews on this merge request

    bypassed reviews on this merge request

  • Kristen Pol merged

    merged

    • Please register or sign in to reply