Skip to content
Snippets Groups Projects

Starshot Design v2

Branch for adding in component for new design

Screenshot

Screen_Shot_2024-08-23_at_11.27.15-fullpage

Edited by Kristen Pol

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alan Cole requested review from @alan.cole

    requested review from @alan.cole

  • assigned to @alan.cole

  • Alan Cole changed the description

    changed the description

  • Alan Cole added 1 commit

    added 1 commit

    • dd45ee66 - Added feature cards sections.

    Compare with previous version

  • Alan Cole added 1 commit

    added 1 commit

    Compare with previous version

  • Alan Cole changed title from Added hero and case study sections. to Starshot Design v2

    changed title from Added hero and case study sections. to Starshot Design v2

  • Alan Cole changed the description

    changed the description

  • Alan Cole added 1 commit

    added 1 commit

    Compare with previous version

  • Alan Cole changed the description

    changed the description

  • Feb Dao added 1 commit

    added 1 commit

    • 4d8f15d6 - [V2] Adding list item component.

    Compare with previous version

  • Feb Dao added 1 commit

    added 1 commit

    • b277af6d - [V2] Adding Testimonial component.

    Compare with previous version

  • Alan Cole added 6 commits

    added 6 commits

    • 1c479b1a - Move original starshot to 'old-starshot'.
    • 5e995214 - [V2] Adding list item component.
    • 45e01dac - [V2] Adding Testimonial component.
    • 2fda3b08 - Reverting changes. New starshot shouldn't use/change old components.
    • e3724db8 - Updates to testimonial to avoid use of old components.
    • bcf39750 - Fixed font colours on testimonials.

    Compare with previous version

  • Alan Cole changed the description

    changed the description

  • Alan Cole added 1 commit

    added 1 commit

    • 8069c1f6 - Added CTA sectuib and moved components into their own folder.

    Compare with previous version

  • Alan Cole changed the description

    changed the description

  • Alan Cole added 20 commits

    added 20 commits

    • 8069c1f6...ae4c1ac0 - 9 commits from branch 1.0.x
    • 2501de30 - 1 earlier commit
    • 30f9847b - Added feature cards sections.
    • 77a862e8 - Fixed some link styles.
    • 121fdbb5 - Added stat section.
    • 47829c57 - Move original starshot to 'old-starshot'.
    • 26f9b9e2 - [V2] Adding list item component.
    • 12cdff78 - [V2] Adding Testimonial component.
    • 25bcac28 - Reverting changes. New starshot shouldn't use/change old components.
    • 48a3a88d - Updates to testimonial to avoid use of old components.
    • 01f7fd47 - Fixed font colours on testimonials.
    • 6c9ad099 - Added CTA sectuib and moved components into their own folder.

    Compare with previous version

  • Alan Cole added 1 commit

    added 1 commit

    Compare with previous version

  • Alan Cole added 1 commit

    added 1 commit

    • 11a8406c - Add stories for hero and case study.

    Compare with previous version

  • Alan Cole added 1 commit

    added 1 commit

    Compare with previous version

  • Alan Cole added 1 commit

    added 1 commit

    Compare with previous version

  • Alan Cole added 1 commit

    added 1 commit

    Compare with previous version

  • Alan Cole added 1 commit

    added 1 commit

    • 646282f0 - Add story for feature cards.

    Compare with previous version

  • Alan Cole added 1 commit

    added 1 commit

    • 3806a5bb - Add story for listing testimonial cards.

    Compare with previous version

  • Alan Cole added 1 commit

    added 1 commit

    • 3a5440fd - Fixed cards as configurable on testimonial cards.

    Compare with previous version

  • I'll try to figure it out but pasting here:

    ==> Started adding of PHPCS exclusions to files in directories dist,storybook-static.
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/dist/scripts.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/7.979c04396ce6fa168484.manager.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/1.125e593543b41c79a5ff.manager.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/5.a4562d9dcf43c41f61d9.manager.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/main.a8aedb4c9b0fdd2501e5.manager.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/vendors~main.280c72a66a177dd28b34.manager.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/0.824c7673a027efe99ccb.manager.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/6.92edef193857fd6c6640.manager.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/vendors~main.f7988e70.iframe.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/4.dab7c5b3.iframe.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/9.419599d816facd84ab90.manager.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/main.1c61f13d.iframe.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/0.ce3fc93b.iframe.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/8.a89cba52ad83b06a6049.manager.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/runtime~main.fc3407c98ffdf00fdd3f.manager.bundle.js
      > [ADDED] /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static/runtime~main.274609a9.iframe.bundle.js
    ==> Finished adding of PHPCS exclusions to files in directory /Users/kristenpol/Sites/salsa/starshot/starshot-v2/web/themes/contrib/demo_design_system/starshot_demo/storybook-static.
    kristens-mbp-2:starshot_demo kristenpol$ ddcr
    PHP Deprecated:  basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    
    Deprecated: basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    PHP Deprecated:  basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    
    Deprecated: basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    PHP Deprecated:  basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    
    Deprecated: basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    PHP Deprecated:  basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    
    Deprecated: basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    PHP Deprecated:  basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    
    Deprecated: basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    PHP Deprecated:  basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    
    Deprecated: basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    PHP Deprecated:  basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    
    Deprecated: basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
    
    In Component.php line 58:
                                                                                            
      Unable to find the Twig template for the component "starshot_demo:starshot-one-col".  
                                                                                            
    
    Failed to run drush cr: exit status 1
    
  • Kristen Pol added 1 commit

    added 1 commit

    Compare with previous version

  • I fixed the SDC YAML files but not sure why the basename deprecations are showing up now. I don't remember them doing that before.

  • Kristen Pol added 1 commit

    added 1 commit

    • 8e57820c - Rename the rest of the SDC YAML files.

    Compare with previous version

  • Here's what Storybook is looking like from within Drupal (images missing)

    screencapture-starshot-v2-ddev-site-themes-contrib-demo-design-system-starshot-demo-storybook-static-iframe-html-2024-08-23-21_35_35

    Edited by Kristen Pol
  • But it seems fine with standalone storybook (other than maybe the overhang on the right)

    Screenshot_2024-08-23_at_11.01.49_PM

    Edited by Kristen Pol
  • Alan Cole added 1 commit

    added 1 commit

    Compare with previous version

  • Alan Cole added 28 commits

    added 28 commits

    Compare with previous version

  • Alan Cole added 23 commits

    added 23 commits

    Compare with previous version

  • Alan Cole added 1 commit

    added 1 commit

    Compare with previous version

  • Alan Cole added 25 commits

    added 25 commits

    Compare with previous version

  • Alan Cole added 1 commit

    added 1 commit

    • c4f1c0f9 - Fixed assets to be referenced relatively (fixes static storybook build).

    Compare with previous version

  • @kepol I've fixed the overhang and the images not appearing on the static build.

  • Alan Cole requested review from @kepol and removed review request for @alan.cole

    requested review from @kepol and removed review request for @alan.cole

  • Kristen Pol added 3 commits

    added 3 commits

    Compare with previous version

  • Kristen Pol added 1 commit

    added 1 commit

    Compare with previous version

  • Kristen Pol added 1 commit

    added 1 commit

    • 63d2fb8a - Use UI Kit images for banner props examples.

    Compare with previous version

  • Kristen Pol added 2 commits

    added 2 commits

    • b1676e66 - 1 commit from branch 1.0.x
    • 6b9f8189 - Merge branch '1.0.x' into feature/design-2

    Compare with previous version

  • Kristen Pol changed the description

    changed the description

  • merged

Please register or sign in to reply
Loading