Skip to content
Snippets Groups Projects

Fix PHPCS warnings and errors

All threads resolved!

Closes #3411164

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Taras Korpach

      Let's revert last commit. Instead of creating phpcs.xml I would use phpcs:ignore, phpcs:disable directly on the place where we want to fix it. And if there is an issue that will change this, adding comment with link to this issue is good idea.

  • Taras Korpach added 2 commits

    added 2 commits

    • 0867308d - 1 commit from branch project:9.0.x
    • b1a13bb9 - Merge branch date_range_formatter:9.0.x into 3411164-fix-cs-errors

    Compare with previous version

  • Taras Korpach added 2 commits

    added 2 commits

    • d0a27a14 - Revert "#3411164: Fixing translation warnings."
    • e9fa79dc - Remove phpcs.xml file and use phpcs:ignore instead

    Compare with previous version

  • Taras Korpach resolved all threads

    resolved all threads

  • Taras Korpach added 1 commit

    added 1 commit

    • 0aede185 - Add a comment explaining why phpcs:ignore is used

    Compare with previous version

  • Taras Korpach resolved all threads

    resolved all threads

  • Thanks, looks good. Please check my question.

  • Taras Korpach added 1 commit

    added 1 commit

    Compare with previous version

  • Taras Korpach resolved all threads

    resolved all threads

  • SUDISHTH KUMAR approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading