Skip to content
Snippets Groups Projects

Replacing enum based on coding standards

Merged nterbogt requested to merge issue/data_pipelines-3511499:data_pipelines-3511499 into 2.x
4 files
+ 66
68
Compare changes
  • Side-by-side
  • Inline
Files
4
@@ -65,9 +65,9 @@ class ElasticsearchDestinationQueueTest extends DatasetKernelTestBase {
// The ES destination index items in bulk so only one process chunk.
$this->assertEquals(3, $process_queue->numberOfItems());
$this->processQueueWithWait($queue_id, $this->destination->id(), [
ProcessingOperationEnum::BEGIN,
ProcessingOperationEnum::PROCESS_CHUNK,
ProcessingOperationEnum::END,
ProcessingOperationEnum::Begin,
ProcessingOperationEnum::ProcessChunk,
ProcessingOperationEnum::End,
]);
$this->assertTrue($this->client->indices()->exists(['index' => 'foo_' . $this->dataset->getMachineName()])->asBool());
$this->assertEquals(1, $this->destinationPlugin->getLastDelta($this->dataset));
@@ -84,9 +84,9 @@ class ElasticsearchDestinationQueueTest extends DatasetKernelTestBase {
// The ES destination index items in bulk so only one process chunk.
$this->assertEquals(3, $process_queue->numberOfItems());
$this->processQueueWithWait($queue_id, $this->destination->id(), [
ProcessingOperationEnum::BEGIN,
ProcessingOperationEnum::PROCESS_CHUNK,
ProcessingOperationEnum::END,
ProcessingOperationEnum::Begin,
ProcessingOperationEnum::ProcessChunk,
ProcessingOperationEnum::End,
]);
$this->assertTrue($this->client->indices()->exists(['index' => 'foo_' . $this->dataset->getMachineName()])->asBool());
$this->assertEquals(1, $this->destinationPlugin->getLastDelta($this->dataset));
@@ -108,9 +108,9 @@ class ElasticsearchDestinationQueueTest extends DatasetKernelTestBase {
// The elastic destination index all items at once.
$this->assertEquals(3, $process_queue->numberOfItems());
$this->processQueueWithWait($queue_id, $this->destination->id(), [
ProcessingOperationEnum::BEGIN,
ProcessingOperationEnum::PROCESS_CHUNK,
ProcessingOperationEnum::END,
ProcessingOperationEnum::Begin,
ProcessingOperationEnum::ProcessChunk,
ProcessingOperationEnum::End,
]);
$this->assertEquals(1, $this->destinationPlugin->getLastDelta($this->dataset));
// Add some more data to the dataset including some invalid data.
@@ -129,9 +129,9 @@ CSV;
// still we have no clean up item as we want to retain them.
$this->assertEquals(3, $process_queue->numberOfItems());
$this->processQueueWithWait($queue_id, $this->destination->id(), [
ProcessingOperationEnum::BEGIN,
ProcessingOperationEnum::PROCESS_CHUNK,
ProcessingOperationEnum::END,
ProcessingOperationEnum::Begin,
ProcessingOperationEnum::ProcessChunk,
ProcessingOperationEnum::End,
]);
// Only 4 valid items are indexed.
$this->assertEquals(4, $this->destinationPlugin->getLastDelta($this->dataset));
@@ -149,9 +149,9 @@ CSV;
// still we have no clean up item as we want to retain them.
$this->assertEquals(3, $process_queue->numberOfItems());
$this->processQueueWithWait($queue_id, $this->destination->id(), [
ProcessingOperationEnum::BEGIN,
ProcessingOperationEnum::PROCESS_CHUNK,
ProcessingOperationEnum::END,
ProcessingOperationEnum::Begin,
ProcessingOperationEnum::ProcessChunk,
ProcessingOperationEnum::End,
]);
// Three older items and two new item all are indexed.
$this->assertEquals(4, $this->destinationPlugin->getLastDelta($this->dataset));
@@ -171,9 +171,9 @@ CSV;
// The elastic destination index all items at once.
$this->assertEquals(3, $process_queue->numberOfItems());
$this->processQueueWithWait($queue_id, $this->destination->id(), [
ProcessingOperationEnum::BEGIN,
ProcessingOperationEnum::PROCESS_CHUNK,
ProcessingOperationEnum::END,
ProcessingOperationEnum::Begin,
ProcessingOperationEnum::ProcessChunk,
ProcessingOperationEnum::End,
]);
$this->assertEquals(1, $this->destinationPlugin->getLastDelta($this->dataset));
// Add some more data to the dataset including some invalid data.
@@ -191,10 +191,10 @@ CSV;
// The elastic destination index all items at once. Item 3 is invalid.
$this->assertEquals(4, $process_queue->numberOfItems());
$this->processQueueWithWait($queue_id, $this->destination->id(), [
ProcessingOperationEnum::BEGIN,
ProcessingOperationEnum::PROCESS_CHUNK,
ProcessingOperationEnum::PROCESS_CLEANUP,
ProcessingOperationEnum::END,
ProcessingOperationEnum::Begin,
ProcessingOperationEnum::ProcessChunk,
ProcessingOperationEnum::ProcessCleanup,
ProcessingOperationEnum::End,
]);
$this->assertEquals(4, $this->destinationPlugin->getLastDelta($this->dataset));
// Remove some more data to the dataset.
@@ -210,13 +210,13 @@ CSV;
// The elastic destination index all items at once. Item 1 is valid.
$this->assertEquals(5, $process_queue->numberOfItems());
$this->processQueueWithWait($queue_id, $this->destination->id(), [
ProcessingOperationEnum::BEGIN,
ProcessingOperationEnum::PROCESS_CHUNK,
ProcessingOperationEnum::Begin,
ProcessingOperationEnum::ProcessChunk,
// One clean up to remove the invalid.
ProcessingOperationEnum::PROCESS_CLEANUP,
ProcessingOperationEnum::ProcessCleanup,
// Second clean up to remove the outdated.
ProcessingOperationEnum::PROCESS_CLEANUP,
ProcessingOperationEnum::END,
ProcessingOperationEnum::ProcessCleanup,
ProcessingOperationEnum::End,
]);
$this->assertEquals(2, $this->destinationPlugin->getLastDelta($this->dataset));
}
Loading