Skip to content
Snippets Groups Projects

Do not unset 'view-mode' attribute while normalizing.

1 unresolved thread

Closes #3474707

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
61 61 $result['element'] = $result['is'];
62 62 unset($result['is']);
63 63 }
64 unset($result['view-mode']);
  • I feel like the 'is' handling right above here can also be removed.

    I don't know exactly why it was introduced... it seems like someone found it better to write setAttribute("is", VALUE) in backend code, rather than setTag(VALUE). But now that we are moving to CE display config to set attributes... this has a chance of adding confusion.

    However, that's not up to me to decide.

    Edited by Roderik Muit
  • Please register or sign in to reply
  • added 3 commits

    Compare with previous version

  • Please register or sign in to reply
    Loading