Issue #3449151 by fago: Improve default CE-naming pattern for content entities.
Merged
requested to merge issue/custom_elements-3449151:3449151-improve-custom-element-default into 3.x
1 unresolved thread
Closes #3449151
Merge request reports
Activity
265 263 $custom_element = $this->getCustomElementGenerator() 266 264 ->generate($this->node, 'full'); 267 265 $markup = $this->renderCustomElement($custom_element); 268 // @todo This should be drupal-media. Create issue and fix. 269 266 $expected_markup = <<<EOF 270 <node type="article" view-mode="full" created="{$this->node->created->value}" title="test" uid="0"> 271 <drupal-media-image-full type="image" view-mode="full" slot="teaser-media"> 272 <field-image slot="image"> 273 <div> 274 <img loading="lazy" src="{$this->image->uri->url}" width="88" height="100" /> 275 </div> 276 </field-image> 277 </drupal-media-image-full> 278 </node> 267 <node-article created="{$this->node->created->value}" title="test" uid="0"> 268 <field-image slot="teaser-media"> -
The wrapping drupal-media element is gone here - I've no idea how the renaming causes that. But since the test does not pre-configure the article display I'm not sure we need to care. I'd be fine to add a follow-up to pre-configure the node article display in the thunder module + improve the test for it then.
Yes, seems reasonable to not dive into that right now. Created https://www.drupal.org/project/custom_elements/issues/3469196.
Please register or sign in to reply